Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp3169076pxa; Tue, 18 Aug 2020 08:16:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxGdqQzZw08xNU0JPln9oCcPCcrqx1uR/8wS6lIVxK7IZw04SUNnUuHgYszmZuEi6t1+Hnj X-Received: by 2002:a17:906:7e06:: with SMTP id e6mr21697918ejr.236.1597763803025; Tue, 18 Aug 2020 08:16:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597763803; cv=none; d=google.com; s=arc-20160816; b=bkubQJvT3eTHJGzlRDqL+DohvRgqQdazlbsJ2+y83hKWt3pDa3ZMNOd/NrqLfGI/p0 ul5dtd4rDLWFQSBiD/qkMQZJD4JqAAEnW3n1gPkjKdpAHo1Yeq3ujZgp1FNNBLF3Iva1 TnltuLWznPDxLcoc0H28+RPlVRjcV6ewMm/KxDHKzlz4Jrc64zvtn15peVkiYNKRO+xb IXI69Cqd1bQ4sLrbNP6zsh2762LAwrXVL4tJdixMRD2GXEemk6aJwx+V+qc5vF5fEY8t ldCElIJasWHMfIMozLOWvPfd9aBF0yq1FrDt9lSQ88eEmFQSRyG5A5wXfcovdh/KT8fD K6rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=Xgr+8VTheGa1OiF/QzzIH3knjPVUWa27Z6xVmgiPMkQ=; b=NQIvB07nQ1pJz4ESEwfsKAzEhC1QJPDuXqBibMaMM8da0rG1FzzDWpIp061Sa5Av4B xDMnNueAbzdYfCJa0fCa7602sqRDBhw0Ia8Isw3ZDXQjHkFVocJchTZgJqesdG5JzXRD Mp3DqVtPNz940ETkwJJVEfa4TJ9FdG++/G5cWB6a+b9erSzeZGxkjNe2aXFSwekBg/NK Gh0lwBCkR+O8NAzRcJSL0G+/9W6sPMBs5EZyVm0fFmhI6LT7glUSjedlbS+ezWUTlhIU Y1g6JdWvmrsZ6igiKS1r4o689oJhxEuTCXewcaCfxCC8scJRT4DJZwyxbLn9a465MU6X UpjQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n19si13696546ejc.243.2020.08.18.08.16.18; Tue, 18 Aug 2020 08:16:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727019AbgHRPPY (ORCPT + 99 others); Tue, 18 Aug 2020 11:15:24 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:9768 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726879AbgHRPPV (ORCPT ); Tue, 18 Aug 2020 11:15:21 -0400 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 136A3657FB312DBF5056; Tue, 18 Aug 2020 23:15:15 +0800 (CST) Received: from localhost (10.174.179.108) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.487.0; Tue, 18 Aug 2020 23:15:08 +0800 From: YueHaibing To: , , , , , , CC: , , , , YueHaibing Subject: [PATCH v2] net: stmmac: Fix signedness bug in stmmac_probe_config_dt() Date: Tue, 18 Aug 2020 23:15:00 +0800 Message-ID: <20200818151500.51548-1-yuehaibing@huawei.com> X-Mailer: git-send-email 2.10.2.windows.1 In-Reply-To: <20200818143952.50752-1-yuehaibing@huawei.com> References: <20200818143952.50752-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.174.179.108] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The "plat->phy_interface" variable is an enum and in this context GCC will treat it as an unsigned int so the error handling is never triggered. Fixes: b9f0b2f634c0 ("net: stmmac: platform: fix probe for ACPI devices") Signed-off-by: YueHaibing --- v2: use rc to do err handling --- drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c index f32317fa75c8..a6052e980ec5 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c @@ -412,10 +412,11 @@ stmmac_probe_config_dt(struct platform_device *pdev, const char **mac) *mac = NULL; } - plat->phy_interface = device_get_phy_mode(&pdev->dev); - if (plat->phy_interface < 0) - return ERR_PTR(plat->phy_interface); + rc = device_get_phy_mode(&pdev->dev); + if (rc < 0) + return ERR_PTR(rc); + plat->phy_interface = rc; plat->interface = stmmac_of_get_mac_mode(np); if (plat->interface < 0) plat->interface = plat->phy_interface; -- 2.17.1