Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp3191640pxa; Tue, 18 Aug 2020 08:50:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxgtud2uotdJ6zNuSY3lidqvOA4qi8UetvH9Ap1ClcqZ3GzGUMGVFEM60GB9ny+w0wGVQ8S X-Received: by 2002:a50:ed84:: with SMTP id h4mr20685290edr.278.1597765837915; Tue, 18 Aug 2020 08:50:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597765837; cv=none; d=google.com; s=arc-20160816; b=y9ccEwnq3vLNAWNPVe63vdQzcmTjW9fgt1TYYSzaWhdGZwFDihKzatizZc0ehiQeFL MIY2JZQsbto6TS5VN0Ya7Us+fTEc515s7ZV9eEW/FFN18te54Ti1fugYeaDu1kkTYYcB sIvaGEfBHWUuLKMnBuk4YM8Q5unYqQd8NKTk4yne5mWL5Rejt+kpP6FDmVVaqzJw+zEl DbSbRWX5NvIs0R1TKYF76rwKYXTo3d3cGjWEBH/0XTuj9SgeriuFtue9BhMR3XVFQ4Wt d6q4niJhl4vVUM+6JIICN8dpelgW1KN9LLl0Uzo0Hxe+HA1xRJesJO1PjFHFekUjk7rN LAsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:ironport-sdr:ironport-sdr; bh=ywIrwdDiXNXspRRDiY1ttcFDYmTm5G7xX6/J26v+Tms=; b=BzPM4GqWBlZZAZ1t1SJG2kV77PlnV7VTHGXEw4JCtx/A2Mtf6MlFvIZgbbZEbFJ4BA QkDf4JeNyrQevTrhmcDxwTg2bxhtiRUf0n1RV14+6/VrVijQkaoRmv5YWf09OcUUTGtm i+NiuIqWGowH/uka2m4GriCS6pPpkEvfnQsD2O7FGoTMpRPe9Xx5XAwUFc4gPGP4tdmI TGDxZaIl6kFKLP6BmWbSNqdPqxB67RRPfNTWfPJCO0tBTNPljWRS+bdP9kCpAWNVq7vh xpbtUIc3BnWT+BmujGWMUb4u7VoppJ44xdPG3afsJWxqfhsC1XUg3UgYrfhy41eBl6x/ /tNA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 38si14243860edq.297.2020.08.18.08.50.14; Tue, 18 Aug 2020 08:50:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727045AbgHRPs4 (ORCPT + 99 others); Tue, 18 Aug 2020 11:48:56 -0400 Received: from mga04.intel.com ([192.55.52.120]:8521 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728153AbgHRPrM (ORCPT ); Tue, 18 Aug 2020 11:47:12 -0400 IronPort-SDR: LDzOuy/P6ioik2EGMnuyeHlqLnzZMZQzmjGtcbZeaPC/XeTbt6DPsb5qfGTdRGsKxzOkmRLiKI Lox1xo0o0SVg== X-IronPort-AV: E=McAfee;i="6000,8403,9716"; a="152345542" X-IronPort-AV: E=Sophos;i="5.76,327,1592895600"; d="scan'208";a="152345542" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Aug 2020 08:47:11 -0700 IronPort-SDR: 5qv3GD2RoO6VHR6djUlkpNAv06/Wj5U/JiCgJZEspJjW3l6OVL/WMe016Qj9YG7Oi/j/3KwWgM AMgU3O1Bn/9g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,327,1592895600"; d="scan'208";a="400530251" Received: from pg-nxl3.altera.com ([10.142.129.93]) by fmsmga001.fm.intel.com with ESMTP; 18 Aug 2020 08:47:09 -0700 From: "Ooi, Joyce" To: "David S . Miller" , Jakub Kicinski Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Dalon Westergreen , Joyce Ooi , Tan Ley Foon , See Chin Liang , Dinh Nguyen , Dalon Westergreen Subject: [PATCH v6 03/10] net: eth: altera: fix altera_dmaops declaration Date: Tue, 18 Aug 2020 23:46:06 +0800 Message-Id: <20200818154613.148921-4-joyce.ooi@intel.com> X-Mailer: git-send-email 2.13.0 In-Reply-To: <20200818154613.148921-1-joyce.ooi@intel.com> References: <20200818154613.148921-1-joyce.ooi@intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dalon Westergreen The declaration of struct altera_dmaops does not have identifier names. Add identifier names to confrom with required coding styles. Signed-off-by: Dalon Westergreen Signed-off-by: Joyce Ooi Reviewed-by: Thor Thayer --- v2: no change v3: no change v4: no change v5: no change v6: no change --- drivers/net/ethernet/altera/altera_tse.h | 30 ++++++++++++++++-------------- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/drivers/net/ethernet/altera/altera_tse.h b/drivers/net/ethernet/altera/altera_tse.h index f17acfb579a0..7d0c98fc103e 100644 --- a/drivers/net/ethernet/altera/altera_tse.h +++ b/drivers/net/ethernet/altera/altera_tse.h @@ -385,20 +385,22 @@ struct altera_tse_private; struct altera_dmaops { int altera_dtype; int dmamask; - void (*reset_dma)(struct altera_tse_private *); - void (*enable_txirq)(struct altera_tse_private *); - void (*enable_rxirq)(struct altera_tse_private *); - void (*disable_txirq)(struct altera_tse_private *); - void (*disable_rxirq)(struct altera_tse_private *); - void (*clear_txirq)(struct altera_tse_private *); - void (*clear_rxirq)(struct altera_tse_private *); - int (*tx_buffer)(struct altera_tse_private *, struct tse_buffer *); - u32 (*tx_completions)(struct altera_tse_private *); - void (*add_rx_desc)(struct altera_tse_private *, struct tse_buffer *); - u32 (*get_rx_status)(struct altera_tse_private *); - int (*init_dma)(struct altera_tse_private *); - void (*uninit_dma)(struct altera_tse_private *); - void (*start_rxdma)(struct altera_tse_private *); + void (*reset_dma)(struct altera_tse_private *priv); + void (*enable_txirq)(struct altera_tse_private *priv); + void (*enable_rxirq)(struct altera_tse_private *priv); + void (*disable_txirq)(struct altera_tse_private *priv); + void (*disable_rxirq)(struct altera_tse_private *priv); + void (*clear_txirq)(struct altera_tse_private *priv); + void (*clear_rxirq)(struct altera_tse_private *priv); + int (*tx_buffer)(struct altera_tse_private *priv, + struct tse_buffer *buffer); + u32 (*tx_completions)(struct altera_tse_private *priv); + void (*add_rx_desc)(struct altera_tse_private *priv, + struct tse_buffer *buffer); + u32 (*get_rx_status)(struct altera_tse_private *priv); + int (*init_dma)(struct altera_tse_private *priv); + void (*uninit_dma)(struct altera_tse_private *priv); + void (*start_rxdma)(struct altera_tse_private *priv); }; /* This structure is private to each device. -- 2.13.0