Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp3196667pxa; Tue, 18 Aug 2020 08:58:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxarl1jz1skDw5iafDgAaLUIfjatwE4pxrvs4ojUxFDTRP8yLd3Rtw8TLBLPKWDuKxQqhWT X-Received: by 2002:a17:906:b248:: with SMTP id ce8mr20161679ejb.85.1597766331994; Tue, 18 Aug 2020 08:58:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597766331; cv=none; d=google.com; s=arc-20160816; b=EQ+O+uXSwD92jW1OwWQYa+sKrbEMGV2DblpXzONC6shbrpbzLApwTHyW3IyZ6hghB/ 68N3CO/WpMt9p2c7hZ6Pn75Y2gpjVleHUQ438TbrL6r1HSL9gpB6wa5sD4Il/u/O0G+X EZgqNHxoTQAYlIHCERxP9ORyuoCia0wwE7xJ34I2aWBjyJ2DseA+yiNJLApV+Jp4IO8E 1qbTTNd/mSokEVFcvEFoA9zpiR2x/PIWf0Y0U74R1G5EYYzYFogIUu6IIfXcWmNXJM7D Sg1oF9CO5IR3Y+SH/Z7zy+xu4okPfc6MDcaHy79wxZU7BiVFH35GLss9rV3S7ltv/2FX f6+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:ironport-sdr:ironport-sdr; bh=WU1G13GbeR2PkA4HvuIUqa7CHAK/NBOUAyJsI89pDhU=; b=bVnkgBJRgYWQn9Ap8caoDffMxEapsbNarrdwzMAfSe6at4hHJ54/FFdXpiaHfmNS4u npin4w0RaiqiH1LCtyd9j8NGJ9ZI6lJt70kcmd0oHMTVX0gIc91nKIFYepmrURlLTwCd h+1AqD9KkXaONCdzlccdikNuwQVaf6Z9zpdXSeY+mQnVDk5tVPEUCyszEin3ixs4deo9 39x/lLo8ta5w+3cr0iEo80FCaAqEX0I7ebALyc3E6cy9MlJq9CunCBro2RcbfpuL3j1o Npu35B4mWrfj554DhPR9TBfod/8FDr6vOroPKEGr60pN3vZifWAWzZvzJ5FlOBOfjyWZ FY4A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t14si13065356ejb.435.2020.08.18.08.58.27; Tue, 18 Aug 2020 08:58:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728246AbgHRPzf (ORCPT + 99 others); Tue, 18 Aug 2020 11:55:35 -0400 Received: from mga09.intel.com ([134.134.136.24]:39885 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728210AbgHRPri (ORCPT ); Tue, 18 Aug 2020 11:47:38 -0400 IronPort-SDR: rDMOk/EgOz/1XM2qkGmleF0OyI3qUiXBP88RDOIKtEw/QtejbNjAMjboSFQ3ZquN66cwvZFU4g VkagzmHKY3Lw== X-IronPort-AV: E=McAfee;i="6000,8403,9716"; a="156017134" X-IronPort-AV: E=Sophos;i="5.76,327,1592895600"; d="scan'208";a="156017134" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Aug 2020 08:47:35 -0700 IronPort-SDR: TcIsAB+pVGQaCeqERlAM3HnJHmp7wiLle5NwrakfWRkudd+ExkSb79C5BJY4R49Q0DJcISIAyn BL4+VzrRe0vA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,327,1592895600"; d="scan'208";a="400530346" Received: from pg-nxl3.altera.com ([10.142.129.93]) by fmsmga001.fm.intel.com with ESMTP; 18 Aug 2020 08:47:32 -0700 From: "Ooi, Joyce" To: "David S . Miller" , Jakub Kicinski Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Dalon Westergreen , Joyce Ooi , Tan Ley Foon , See Chin Liang , Dinh Nguyen Subject: [PATCH v6 06/10] net: eth: altera: Add missing identifier names to function declarations Date: Tue, 18 Aug 2020 23:46:09 +0800 Message-Id: <20200818154613.148921-7-joyce.ooi@intel.com> X-Mailer: git-send-email 2.13.0 In-Reply-To: <20200818154613.148921-1-joyce.ooi@intel.com> References: <20200818154613.148921-1-joyce.ooi@intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dalon Westergreen The sgdma and msgdma header files included function declarations without identifier names for pointers. Add appropriate identifier names. Signed-off-by: Dalon Westergreen Signed-off-by: Joyce Ooi Reviewed-by: Thor Thayer --- v2: this patch is added in patch version 2 v3: no change v4: no change v5: no change v6: no change --- drivers/net/ethernet/altera/altera_msgdma.h | 30 ++++++++++++++------------- drivers/net/ethernet/altera/altera_sgdma.h | 32 +++++++++++++++-------------- 2 files changed, 33 insertions(+), 29 deletions(-) diff --git a/drivers/net/ethernet/altera/altera_msgdma.h b/drivers/net/ethernet/altera/altera_msgdma.h index 9813fbfff4d3..23f5b2a13898 100644 --- a/drivers/net/ethernet/altera/altera_msgdma.h +++ b/drivers/net/ethernet/altera/altera_msgdma.h @@ -6,19 +6,21 @@ #ifndef __ALTERA_MSGDMA_H__ #define __ALTERA_MSGDMA_H__ -void msgdma_reset(struct altera_tse_private *); -void msgdma_enable_txirq(struct altera_tse_private *); -void msgdma_enable_rxirq(struct altera_tse_private *); -void msgdma_disable_rxirq(struct altera_tse_private *); -void msgdma_disable_txirq(struct altera_tse_private *); -void msgdma_clear_rxirq(struct altera_tse_private *); -void msgdma_clear_txirq(struct altera_tse_private *); -u32 msgdma_tx_completions(struct altera_tse_private *); -void msgdma_add_rx_desc(struct altera_tse_private *, struct tse_buffer *); -int msgdma_tx_buffer(struct altera_tse_private *, struct tse_buffer *); -u32 msgdma_rx_status(struct altera_tse_private *); -int msgdma_initialize(struct altera_tse_private *); -void msgdma_uninitialize(struct altera_tse_private *); -void msgdma_start_rxdma(struct altera_tse_private *); +void msgdma_reset(struct altera_tse_private *priv); +void msgdma_enable_txirq(struct altera_tse_private *priv); +void msgdma_enable_rxirq(struct altera_tse_private *priv); +void msgdma_disable_rxirq(struct altera_tse_private *priv); +void msgdma_disable_txirq(struct altera_tse_private *priv); +void msgdma_clear_rxirq(struct altera_tse_private *priv); +void msgdma_clear_txirq(struct altera_tse_private *priv); +u32 msgdma_tx_completions(struct altera_tse_private *priv); +void msgdma_add_rx_desc(struct altera_tse_private *priv, + struct tse_buffer *buffer); +int msgdma_tx_buffer(struct altera_tse_private *priv, + struct tse_buffer *buffer); +u32 msgdma_rx_status(struct altera_tse_private *priv); +int msgdma_initialize(struct altera_tse_private *priv); +void msgdma_uninitialize(struct altera_tse_private *priv); +void msgdma_start_rxdma(struct altera_tse_private *priv); #endif /* __ALTERA_MSGDMA_H__ */ diff --git a/drivers/net/ethernet/altera/altera_sgdma.h b/drivers/net/ethernet/altera/altera_sgdma.h index 08afe1c9994f..3fb201417820 100644 --- a/drivers/net/ethernet/altera/altera_sgdma.h +++ b/drivers/net/ethernet/altera/altera_sgdma.h @@ -6,20 +6,22 @@ #ifndef __ALTERA_SGDMA_H__ #define __ALTERA_SGDMA_H__ -void sgdma_reset(struct altera_tse_private *); -void sgdma_enable_txirq(struct altera_tse_private *); -void sgdma_enable_rxirq(struct altera_tse_private *); -void sgdma_disable_rxirq(struct altera_tse_private *); -void sgdma_disable_txirq(struct altera_tse_private *); -void sgdma_clear_rxirq(struct altera_tse_private *); -void sgdma_clear_txirq(struct altera_tse_private *); -int sgdma_tx_buffer(struct altera_tse_private *priv, struct tse_buffer *); -u32 sgdma_tx_completions(struct altera_tse_private *); -void sgdma_add_rx_desc(struct altera_tse_private *priv, struct tse_buffer *); -void sgdma_status(struct altera_tse_private *); -u32 sgdma_rx_status(struct altera_tse_private *); -int sgdma_initialize(struct altera_tse_private *); -void sgdma_uninitialize(struct altera_tse_private *); -void sgdma_start_rxdma(struct altera_tse_private *); +void sgdma_reset(struct altera_tse_private *priv); +void sgdma_enable_txirq(struct altera_tse_private *priv); +void sgdma_enable_rxirq(struct altera_tse_private *priv); +void sgdma_disable_rxirq(struct altera_tse_private *priv); +void sgdma_disable_txirq(struct altera_tse_private *priv); +void sgdma_clear_rxirq(struct altera_tse_private *priv); +void sgdma_clear_txirq(struct altera_tse_private *priv); +int sgdma_tx_buffer(struct altera_tse_private *priv, + struct tse_buffer *buffer); +u32 sgdma_tx_completions(struct altera_tse_private *priv); +void sgdma_add_rx_desc(struct altera_tse_private *priv, + struct tse_buffer *buffer); +void sgdma_status(struct altera_tse_private *priv); +u32 sgdma_rx_status(struct altera_tse_private *priv); +int sgdma_initialize(struct altera_tse_private *priv); +void sgdma_uninitialize(struct altera_tse_private *priv); +void sgdma_start_rxdma(struct altera_tse_private *priv); #endif /* __ALTERA_SGDMA_H__ */ -- 2.13.0