Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 18 Aug 2020 11:58:57 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     "Ooi, Joyce" <joyce.ooi@intel.com>
Cc:     "David S . Miller" <davem@davemloft.net>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Dalon Westergreen <dalon.westergreen@linux.intel.com>,
        Tan Ley Foon <ley.foon.tan@intel.com>,
        See Chin Liang <chin.liang.see@intel.com>,
        Dinh Nguyen <dinh.nguyen@intel.com>,
        Dalon Westergreen <dalon.westergreen@intel.com>
Subject: Re: [PATCH v6 09/10] net: eth: altera: add msgdma prefetcher
Message-ID: <20200818115857.78d6b2ac@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20200818154613.148921-10-joyce.ooi@intel.com>
References: <20200818154613.148921-1-joyce.ooi@intel.com>
        <20200818154613.148921-10-joyce.ooi@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 18 Aug 2020 23:46:12 +0800 Ooi, Joyce wrote:
> From: Dalon Westergreen <dalon.westergreen@intel.com>
>=20
> Add support for the mSGDMA prefetcher.  The prefetcher adds support
> for a linked list of descriptors in system memory.  The prefetcher
> feeds these to the mSGDMA dispatcher.

This generates warnings on 32bit builds:

../drivers/net/ethernet/altera/altera_msgdma_prefetcher.c: In function =E2=
=80=98msgdma_pref_initialize=E2=80=99:
../drivers/net/ethernet/altera/altera_msgdma_prefetcher.c:97:51: warning: f=
ormat =E2=80=98%llx=E2=80=99 expects argument of type =E2=80=98long long un=
signed int=E2=80=99, but argument 4 has type =E2=80=98dma_addr_t=E2=80=99 {=
aka =E2=80=98unsigned int=E2=80=99} [-Wformat=3D]
   97 |   netdev_info(priv->dev, "%s: RX Desc mem at 0x%llx\n", __func__,
      |                                                ~~~^
      |                                                   |
      |                                                   long long unsigne=
d int
      |                                                %x
   98 |        priv->pref_rxdescphys);
      |        ~~~~~~~~~~~~~~~~~~~~~                      =20
      |            |
      |            dma_addr_t {aka unsigned int}
../drivers/net/ethernet/altera/altera_msgdma_prefetcher.c:101:51: warning: =
format =E2=80=98%llx=E2=80=99 expects argument of type =E2=80=98long long u=
nsigned int=E2=80=99, but argument 4 has type =E2=80=98dma_addr_t=E2=80=99 =
{aka =E2=80=98unsigned int=E2=80=99} [-Wformat=3D]
  101 |   netdev_info(priv->dev, "%s: TX Desc mem at 0x%llx\n", __func__,
      |                                                ~~~^
      |                                                   |
      |                                                   long long unsigne=
d int
      |                                                %x
  102 |        priv->pref_txdescphys);
      |        ~~~~~~~~~~~~~~~~~~~~~                      =20
      |            |
      |            dma_addr_t {aka unsigned int}