Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp34454pxa; Tue, 18 Aug 2020 15:00:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyNqEDfBQKOzUCff5xNOWToUxuboQzfaQSUIx5ld+lzvYUCDo6UnTsXC8NiGjTBGxXGxGOL X-Received: by 2002:a17:907:7090:: with SMTP id yj16mr21674396ejb.73.1597788031282; Tue, 18 Aug 2020 15:00:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597788031; cv=none; d=google.com; s=arc-20160816; b=umxiFvV1cYwLCqOiqnwN1sIVeo18F/fSXcEWWYdl6fpyosoN8AHOsf+KBXrpWMwU61 SFmVZb++a4BkoVJfxcJt22XWCmXFTdJayexk2W+sJyL5stXsFypwoQpIiI6NH9ePk2CL RFJ6M/62AW36LebCQCNAJYjx6q3XGlAXjOpom0r0v3SEifdMrLP8o+749wQv48TrgHTA 7S36rSdPgUdYMpBKrnHFHmDeu4tJazppU0Us3u8YvZBvS3SlFobYaC1xpJKMdLconnIQ MoPiGFUwWes1HAJWvG4P4qgENrNHJWaIrl6Np8lxjnCX9NiK3XIsNM/wm8DKVplYEXi1 Tf9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=wLY7DKEY5wW7mQXQ8oT/iCnE/ovDXCbzyVbqbcCsqrg=; b=mLL7ql4mNP8jw35tyEOIRZM34hrE/IppdeKZflS6Ygpl92PFQWBY+toSplsnKlM36v G/uszc5XrPLfjNj7RG97FAq0LN/BSKzQk7GrhwUAMHWWi6h00X7DfTSgw48WVJKvr6jN xEe0ByC0xIMCW8wAhidrMoG8rHgbXnAcW7QsUsbAkMZm3R33+lj+BhduWve04XHiPxYM Oww1XLRsWxU4bY6pTtPp5YkYZho7RcM9CqrYlhfqXLhH3bxXDNyUXIBTzMPnYCjyYbi7 3NK6zORv0NREFdLqH1QlP2HYZNUqsPDxYe94/8TzhIqNXnNudl9f9DYfu2PCHjNiG+bM oM4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@beagleboard-org.20150623.gappssmtp.com header.s=20150623 header.b=o245Zjj9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id fy16si15027596ejb.15.2020.08.18.15.00.04; Tue, 18 Aug 2020 15:00:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@beagleboard-org.20150623.gappssmtp.com header.s=20150623 header.b=o245Zjj9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726738AbgHRV4k (ORCPT + 99 others); Tue, 18 Aug 2020 17:56:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726366AbgHRV4j (ORCPT ); Tue, 18 Aug 2020 17:56:39 -0400 Received: from mail-il1-x144.google.com (mail-il1-x144.google.com [IPv6:2607:f8b0:4864:20::144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE2F6C061389 for ; Tue, 18 Aug 2020 14:56:38 -0700 (PDT) Received: by mail-il1-x144.google.com with SMTP id f12so11398401ils.6 for ; Tue, 18 Aug 2020 14:56:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=beagleboard-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wLY7DKEY5wW7mQXQ8oT/iCnE/ovDXCbzyVbqbcCsqrg=; b=o245Zjj9rVaHE17kBt0+ISQkbkR8B9Y4RqLLw8KMd3Oj/rpXV3dsGPkIzfl/PGnOyh JjeH8o28tlxyUfV0f9Dp3xOpzTMm6+G7+m+rmRHDyX51yVHKZsOjBYO0LYzblIEdkcsd u64SX9CWMMf93vL46Mye0L+gNb3jPcqkIBFsaGySdt7n0OHHi6kpLrekftbY/+WOip1I Z/cwafgW3xhQTmRRi5XeqYIbR73D5y26qV3ufJXoKi7aETBf9sHW+cpagXqBA+manizS c/xEVmZgo6zABLwoLWWKS68gyC84vHl3aVTXA1w7SGZjBtYQH+fB5JC882c3ZU9IToYT PRHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wLY7DKEY5wW7mQXQ8oT/iCnE/ovDXCbzyVbqbcCsqrg=; b=oj0iK/R68RIAfd8Xmsxw3ycGMNGJWJkt2hBp1o+7wq3TJaq2EhLRHeMroxrs6YbhF9 /oATBPDzVs86sShGLdaVjNN4za1iB0cvQr5sivK2USiu0yflJB4VrUw4SMppET+KzBHP Ac9GHA4EHcgGbZEs4IN3eWuJQw+RyPeI5tWM+OjRHnBo94lkm/Ze2SpPoGmjGm0INOva l7NS+kB66RbEnyoYo6PEIncBkrG3wDZa6VOvTfw/kjRNUxvxa6a1d5ItZYkhZZ8nZVZD 8PNBNXZfSgFEWoe94sNKiwIKA4MBukTrB4qhZoo91t8sY8tWw5oPRb+XF9TArcRpTW4C Frbg== X-Gm-Message-State: AOAM533KdZ61Zv5utPGgAm/I5vuqinWlpHBWJ/FbYAFLcRjs6HDhbLRl o5JgkBa/6BYRTnzhxAYVO9qop8D1rOJAi1Zl6xZw X-Received: by 2002:a92:c50e:: with SMTP id r14mr7730786ilg.161.1597787798059; Tue, 18 Aug 2020 14:56:38 -0700 (PDT) MIME-Version: 1.0 References: <20200818124815.11029-1-vaishnav@beagleboard.org> In-Reply-To: From: Vaishnav M A Date: Wed, 19 Aug 2020 03:26:27 +0530 Message-ID: Subject: Re: [RFC PATCH v2 0/3] mikroBUS driver for add-on boards To: Frank Rowand Cc: greybus-dev@lists.linaro.org, linux-kernel@vger.kernel.org, Greg KH , arnd@arndb.de, johan@kernel.org, elder@kernel.org, "devicetree@vger.kernel.org" , robh@kernel.org, mchehab+huawei@kernel.org, davem@davemloft.net, Jason Kridner , Drew Fustini , Robert Nelson , =?UTF-8?Q?Ivan_Rajkovi=C4=87?= , chrisfriedt@gmail.com, zoran.stojsavljevic@gmail.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 19, 2020 at 2:08 AM Frank Rowand wrote: > > Hi Vaishnav, > > +me +devicetree > > Please add these two recipients to future versions. > > I will comment more after reading the first version and v2. > > -Frank > Hi Frank, Sorry, I missed to run get_maintainer.pl after making the changes will add both recipients in future versions. Thanks and Regards, Vaishnav M A > > On 2020-08-18 07:48, Vaishnav M A wrote: > > Hi, > > > > This Patch series is an update to the mikroBUS driver > > RFC v1 Patch : https://lkml.org/lkml/2020/7/24/518 . > > The mikrobus driver is updated to add mikrobus ports from device-tree > > overlays, the debug interfaces for adding mikrobus ports through sysFS > > is removed, and the driver considers the extended usage of mikrobus > > port pins from their standard purposes. > > > > change log: > > v2: support for adding mikroBUS ports from DT overlays, > > remove debug sysFS interface for adding mikrobus ports, > > consider extended pin usage/deviations from mikrobus standard > > specifications, > > use greybus CPort protocol enum instead of new protcol enums > > Fix cases of wrong indendation, ignoring return values, freeing > > allocated resources in case of errors and other style suggestions > > in v1 review. > > > > Vaishnav M A (3): > > add mikrobus descriptors to greybus_manifest > > mikroBUS driver for add-on boards on mikrobus ports > > Add Device Tree Bindings for mikroBUS port > > > > .../bindings/misc/linux,mikrobus.txt | 81 ++ > > MAINTAINERS | 6 + > > drivers/misc/Kconfig | 1 + > > drivers/misc/Makefile | 1 + > > drivers/misc/mikrobus/Kconfig | 16 + > > drivers/misc/mikrobus/Makefile | 7 + > > drivers/misc/mikrobus/mikrobus_core.c | 692 ++++++++++++++++++ > > drivers/misc/mikrobus/mikrobus_core.h | 191 +++++ > > drivers/misc/mikrobus/mikrobus_manifest.c | 444 +++++++++++ > > drivers/misc/mikrobus/mikrobus_manifest.h | 21 + > > drivers/misc/mikrobus/mikrobus_port.c | 171 +++++ > > include/linux/greybus/greybus_manifest.h | 47 ++ > > 12 files changed, 1678 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/misc/linux,mikrobus.txt > > create mode 100644 drivers/misc/mikrobus/Kconfig > > create mode 100644 drivers/misc/mikrobus/Makefile > > create mode 100644 drivers/misc/mikrobus/mikrobus_core.c > > create mode 100644 drivers/misc/mikrobus/mikrobus_core.h > > create mode 100644 drivers/misc/mikrobus/mikrobus_manifest.c > > create mode 100644 drivers/misc/mikrobus/mikrobus_manifest.h > > create mode 100644 drivers/misc/mikrobus/mikrobus_port.c > > >