Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp99304pxa; Tue, 18 Aug 2020 17:19:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxKLr8q9LkrbQ8GfEr71OojJFySga0K4fCH+OEOaxRL+rsm6KM2gSrEtOKrx0zFQMZYAier X-Received: by 2002:a05:6402:37b:: with SMTP id s27mr22576797edw.239.1597796349406; Tue, 18 Aug 2020 17:19:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597796349; cv=none; d=google.com; s=arc-20160816; b=P09j9ngZf7Lok3uXTzninPH/9a77qN+C9o0ooZzZCJSMq9qmJ81jcUA+BXpRormHvR HB71sn2m3zrzTG0/QoO2XwiDbWyaWPwpyLGSmK+BHcpLYdSfbnz8R/SlHaERC3HGZpe8 FFmmAPQhFacpllS1uTQ4G5aRUJWOCe/5KaoXJdrFsaEX9IzsazthJz4jZIu1FqSsV5Y9 1CKUTF7mSlwstl6sN11utSIcm02loc1LEuHQOhzfOyrZn4XGG4mO8xYCrSeLyup/jWWt 4hJCYnSeH2qY3dZWZgnhsxBlY7JsfI++O5JVQ89C/fm4pkxV9zi9hox9QZ6znIjPExdz YxCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=8NF1Vjr7ZZw1NbbT4vls4Jv5o59az/jx1xp2RwD9Jxg=; b=AwIRZIsGKyYoOh+wxhFdqrtO8e3ZNmt9IPPFnnZN/y4yu0jzArpd2queYJlLGenZBZ 8fcwvN8G3rUSXHxWQTNtJK36hpNL8WFZubqF2j9dVWl99VqAruOpgYxHH6pgwIJAclXF OttH9InRihxm7H50Sz6HYvPeVix+aGrzB+I+27Jl03atVHQEyDEzs0owfq3ua5knkt6B XGmBHpRKCfP+TKYuix/+A0UE+KGjwxXz0URwkOPe5icwsMDowxhRTDv3iGkPXIp1220Y GtNz/3hsv1TW/YhBV2ydZMvtkvtVjSgecO2euw3B+JEEYAcCMjRjoEzfrKCBOOIi02vO xDaA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=n+GfgUIP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x6si17172764ede.204.2020.08.18.17.18.44; Tue, 18 Aug 2020 17:19:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=n+GfgUIP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726803AbgHSAPI (ORCPT + 99 others); Tue, 18 Aug 2020 20:15:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726372AbgHSAPG (ORCPT ); Tue, 18 Aug 2020 20:15:06 -0400 Received: from mail-lf1-x141.google.com (mail-lf1-x141.google.com [IPv6:2a00:1450:4864:20::141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7FD75C061389; Tue, 18 Aug 2020 17:15:06 -0700 (PDT) Received: by mail-lf1-x141.google.com with SMTP id i19so11144060lfj.8; Tue, 18 Aug 2020 17:15:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=8NF1Vjr7ZZw1NbbT4vls4Jv5o59az/jx1xp2RwD9Jxg=; b=n+GfgUIPK7Teyvo1wHMLsjQ16fvfQuuryJjU1ziRRNQKdCv/thQdEnHrYoijegncZI eYhWGjuHgox6ODLZ2nT4QpktrrtG/PkRtxQqh3EeMgbp6zIUyUp3agvtJlSjRjfWO9N2 sCqD2i52HSQ/3kE+GvYm7Y2r43SeZPDqw3yRrPQySjHwX7kfgLB/v4q7WXH5FurQSdBY vDXd3zww7vR/AHymXRXVf+wM8sfW9D+qCI+UvvDsYvD37nj2qZHddAvTJdfMfunCJoAm J+VCrMuV5aL7ewGovxMrY91rrzmgEiICi0FUB3HL+f88L+lUPvpSAlXdhEk2q6RQPBPc 4kbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=8NF1Vjr7ZZw1NbbT4vls4Jv5o59az/jx1xp2RwD9Jxg=; b=j2wrQvTWyG97HIIP4kGHG631Scn2WQFC1/PsW+O/mf3RP77Ag2BChqxJRuCxg1Hc0F 3PWI5EqIN/7jvpsQhDCi4h3/vwSVj/rUSPUn91ba5kWY0UWGSldEF8BEFhyPd3hAndrZ umzWCAPX02fuG0puBJE6teuftemEu6PlHqXtfIeoiAEXlIFM/uZxCOzIenXWYTMMpGiW hIuDT7eJCNanfT8Of2rkaWiH07/1xAOfw+OJs58ob5d1tQ/aJW/kZPwR2xkLCWnazt4J YNemEbmouGIaJLSQhjuEvbeX381irxOsxPg588GvNmrYkuZcGsB7Qs0zf6cwgad9jITf CBEQ== X-Gm-Message-State: AOAM532TSCHseR2cO3YzbsJpAQn5+9R3uDuvX5ZPT5hyOKJeD00Aiy2W 0EoUDc3u4tFxWrzyGQtP7akqDedTo8VYFitV1rE= X-Received: by 2002:a19:cc3:: with SMTP id 186mr11096860lfm.134.1597796104962; Tue, 18 Aug 2020 17:15:04 -0700 (PDT) MIME-Version: 1.0 References: <20200818083939.3592763-1-zenczykowski@gmail.com> In-Reply-To: <20200818083939.3592763-1-zenczykowski@gmail.com> From: Alexei Starovoitov Date: Tue, 18 Aug 2020 17:14:53 -0700 Message-ID: Subject: Re: [PATCH bpf] net-tun: add type safety to tun_xdp_to_ptr() and tun_ptr_to_xdp() To: =?UTF-8?Q?Maciej_=C5=BBenczykowski?= Cc: =?UTF-8?Q?Maciej_=C5=BBenczykowski?= , Alexei Starovoitov , Daniel Borkmann , Linux Network Development Mailing List , Linux Kernel Mailing List , BPF Mailing List , "David S . Miller" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 18, 2020 at 1:39 AM Maciej =C5=BBenczykowski wrote: > > From: Maciej =C5=BBenczykowski > > Test: builds > Signed-off-by: Maciej =C5=BBenczykowski I know it's a trivial patch, but please provide a proper commit log and exp= lain _why_ this type safety is necessary. Also pls use email subject with [PATCH bpf-next]