Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 19 Aug 2020 10:24:02 +0800
From:   Leo Yan <leo.yan@linaro.org>
To:     John Garry <john.garry@huawei.com>
Cc:     Mathieu Poirier <mathieu.poirier@linaro.org>, acme@kernel.org,
        will@kernel.org, linux-kernel@vger.kernel.org,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        Jiri Olsa <jolsa@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH] MAINTAINERS: Add entries for CoreSight and Arm SPE
Message-ID: <20200819022402.GB9556@leoy-ThinkPad-X240s>
References: <20200817193140.3659956-1-mathieu.poirier@linaro.org>
 <ede047ea-ad6a-1f7e-d597-b47bc87271c3@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ede047ea-ad6a-1f7e-d597-b47bc87271c3@huawei.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Aug 18, 2020 at 06:54:28PM +0100, John Garry wrote:
> On 17/08/2020 20:31, Mathieu Poirier wrote:
> > Add entries for perf tools elements related to the support of
> > Arm CoreSight and Arm SPE.
> 
> Thanks for doing this...
> 
> > 
> > Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> > ---
> >   MAINTAINERS | 10 ++++++++++
> >   1 file changed, 10 insertions(+)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 4e2698cc7e23..f9bb76baeec9 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -13427,8 +13427,18 @@ F:	tools/perf/
> >   PERFORMANCE EVENTS SUBSYSTEM ARM64 PMU EVENTS
> >   R:	John Garry <john.garry@huawei.com>
> >   R:	Will Deacon <will@kernel.org>
> > +R:	Mathieu Poirier <mathieu.poirier@linaro.org>
> > +R:	Leo Yan <leo.yan@linaro.org>
> >   L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
> >   S:	Supported
> > +F:	tools/build/feature/test-libopencsd.c
> > +F:	tools/perf/arch/arm/util/auxtrace.c
> > +F:	tools/perf/arch/arm/util/cs-etm.*
> > +F:	tools/perf/arch/arm/util/pmu.c
> > +F:	tools/perf/arch/arm64/util/arm-spe.c
> > +F:	tools/perf/util/arm-spe.h
> > +F:	tools/perf/util/cs-etm-decoder/*
> > +F:	tools/perf/util/cs-etm.*
> 
> But from the previous discussion, I thought that we wanted an entry to cover
> all tools/perf/arch/arm64/ and other related folders. Or was it just put all
> special interest parts (like SPE support) under one entry and leave the
> other arm/arm64 parts to be caught by "PERFORMANCE EVENTS SUBSYSTEM" entry?

Yes, I think we need to add below two items for Arm SPE:

F:	tools/perf/util/arm-spe-decoder/*
F:	tools/perf/util/arm-spe.*

Thanks,
Leo

> >   F:	tools/perf/pmu-events/arch/arm64/
> >   PERSONALITY HANDLING
> > 
>