Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: f5CvnXkEXvNh3RIqMMQAyb2TORvQnyhh3GBv8vREkxUG5FMXFYYvnZkdUp5Lu6XZkQiWKfo1Sa
 c6wi2I9jjfcg==
IronPort-SDR: s+saYji99ULqmAoVtci/uAy6Q6OAVxXDlPQIPfE9XSjw3yHMoiO7WpUm1bsKP3kIja8ArQq9jQ
 puitc8RCXNDw==
Subject: Re: [PATCH v3] perf parse-events: Set exclude_guest=1 for user-space
 counting
To:     "Jin, Yao" <yao.jin@linux.intel.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com,
        alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org,
        ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com
References: <20200814012120.16647-1-yao.jin@linux.intel.com>
 <20200814124722.GG13995@kernel.org>
 <b061052d-592d-67d7-045f-481974b0687a@linux.intel.com>
From:   Like Xu <like.xu@linux.intel.com>
Organization: Intel OTC
Message-ID: <3521b375-6f00-e815-94e5-49eae2a7c989@linux.intel.com>
Date:   Wed, 19 Aug 2020 11:05:05 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.11.0
MIME-Version: 1.0
In-Reply-To: <b061052d-592d-67d7-045f-481974b0687a@linux.intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Arnaldo,

On 2020/8/17 10:32, Jin, Yao wrote:
> Hi Arnaldo,
> 
> On 8/14/2020 8:47 PM, Arnaldo Carvalho de Melo wrote:
>> Em Fri, Aug 14, 2020 at 09:21:20AM +0800, Jin Yao escreveu:
>>> Currently if we run 'perf record -e cycles:u', exclude_guest=0.
>>>
>>> But it doesn't make sense in most cases that we request for
>>> user-space counting but we also get the guest report.
>>>
>>> Of course, we also need to consider perf kvm usage case that
>>> authorized perf users on the host may only want to count guest
>>> user space events. For example,
>>>
>>> perf kvm --guest record -e cycles:u
>> Ok, probably this works, but what if I want to record guest user samples
>> without using 'perf kvm'?
>>
>> Can we have a 'U' modifier, perhaps, for that?
>>
>> I.e.
>>
>> perf record -e cycles:uU would not set exclude_host not exclude_guest,
>> cycles:u excludes guest user, cycles:U excludes host user, would that be
>> possible?
>>
>> Anyway, I think that with what we have, your patch makes sense, having a
>> way to, without using 'perf kvm' still be able to sample the guest can
>> be done on top. of this.
>>
>> Xu, can we get your Reviewed-by if this addresses your concerns?

My concern is about do not break the perf kvm usages and Yao did it in v3.

Tested-by: Like Xu <like.xu@linux.intel.com>

>>
>> - Arnaldo
> 
> Do you suggest we will create a new modifier 'U' as a follow-up patch?
> 
> cycles:u - Count host user space but it doesn't count the guest user space 
> (exclude_host = 0, exclude_guest = 1, exclude_kernel = 1, exclude_user = 0, 
> exclude_hv = 1)
> 
> cycles:U - Count the guest user space but it doesn't count the host user 
> space (exclude_host = 1, exclude_guest = 0, exclude_kernel = 1, 
> exclude_user = 0, exclude_hv = 1)
> 
> Is above understanding correct?

Do we really need to support sample guests without using perf kvm?

If it's true, I would prefer "cycles:uG" to cover guest user space
events only, "cycles:kG" to cover guest kernel space events only,
and only host events are sampled without the ":G" modifier by default.

I am not sure if ":G" has been used in perf.

At the very least, this v3 patch may not
block the follow-up patch from Yao (if any).

Thanks,
Like Xu

> 
> Thanks
> Jin Yao