Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp232252pxa; Tue, 18 Aug 2020 22:48:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz5YEy8kvW8IB3BHL1csxeHNCh/MHLnRAH/zfPPgUXo6411O6Af2YX1k69ptiWnNseWXtpc X-Received: by 2002:a17:906:4acd:: with SMTP id u13mr23518629ejt.4.1597816120198; Tue, 18 Aug 2020 22:48:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597816120; cv=none; d=google.com; s=arc-20160816; b=psMIFq3CEx15W6X/nGq1QowgflB9JhdcRPbBmYB7UFlMTsrSZ4f9y9pxG13zI8tUCz NXFBviBHcSgBlXuv/SdPzXFD5IYU/TTZtipnRtiZ1kIpMCB3t5wUA7Q6gvrnk8Ydrihg jPaIQEMMEP/eBhHtci32am3BLvI3V8bhSMQhCg7bkhM5XDCg3ei1zuycV1sPb4XW9c5T aXrebkLKEJO8698XT2iocUDRB0pZRN/zQp2XcDwJ8JdiCqLC2EJAvzh+kMQxCn0N2Rqd P9I6QsA6poeOUgWFC7t2XCrA9TwEIGOVpAyhIR8HDbXgxmskS2aeIRjJuRnTErBn6Hgx nL6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=dcQIwXkKopXkQiPwSFJxZ6yimtcZo3Z0QImZrOlREA0=; b=r7I0F76KY4g/nC2VrnPd6nWkcZT5+9PKG+ouyb8623TRIU3fN6iDK8nlslcaek0PER gLymYk0YCwE39fFgTYbmtyAPNPQHf9xT6uNvNVbP9JzVimQOjD0mdEr5U6YpZPSLbR2a Q4OKlq/VrAzEBxqIMDAvkGD4er7wnWyDsM9yQu2JPK7/kM7wNszkucD+Bu1osqws0eKQ 4Ew8QInWEnW38v3/BQtiWW+DaymDEGs9znJqzitlZxaZ6CYSkBKTDjMANkfcMNLYHAC6 NF0EjMNb2GPIqcoK8L2rgp73xFLxZNbw4N8JNO+BrBjDX++DfAfuQhQPg9VLXIiyk7wk hNrA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=bLWXsam6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: <linux-kernel-owner@vger.kernel.org> Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v15si14865286edy.90.2020.08.18.22.48.14; Tue, 18 Aug 2020 22:48:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=bLWXsam6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726318AbgHSFpM (ORCPT <rfc822;luigi.mantellini.ml@gmail.com> + 99 others); Wed, 19 Aug 2020 01:45:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:56592 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725497AbgHSFpL (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 19 Aug 2020 01:45:11 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C726620772; Wed, 19 Aug 2020 05:45:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597815911; bh=eVtrxuXADlL5Xym0lAYGOL7VWEWqBRHeMGfJMlcARAw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bLWXsam6cHBNNFOqFLQQPC4nPoRdhdlMtJNDorAxuzdnSE8VaBGjUtOZ+ZBdCkhuO 4bowmFnb5r3YkJvc/Xyxaf3TgkeysZbL7C3UFRt9HOi+R3jQPi0GkmVRTMPseYBGU0 NJLVKUVUTWiPVYysPuBjj7E4hjySJ19rGvDo/0xI= Date: Wed, 19 Aug 2020 07:45:34 +0200 From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: Pavel Machek <pavel@denx.de> Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Dan Carpenter <dan.carpenter@oracle.com>, Hans Verkuil <hverkuil-cisco@xs4all.nl>, Mauro Carvalho Chehab <mchehab+huawei@kernel.org>, Sasha Levin <sashal@kernel.org> Subject: Re: [PATCH 4.19 073/168] media: firewire: Using uninitialized values in node_probe() Message-ID: <20200819054534.GA846396@kroah.com> References: <20200817143733.692105228@linuxfoundation.org> <20200817143737.355562192@linuxfoundation.org> <20200818213453.GB25182@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200818213453.GB25182@amd> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 18, 2020 at 11:34:53PM +0200, Pavel Machek wrote: > Hi! > > > From: Dan Carpenter <dan.carpenter@oracle.com> > > > > [ Upstream commit 2505a210fc126599013aec2be741df20aaacc490 ] > > > > If fw_csr_string() returns -ENOENT, then "name" is uninitialized. So > > then the "strlen(model_names[i]) <= name_len" is true because strlen() > > is unsigned and -ENOENT is type promoted to a very high positive value. > > Then the "strncmp(name, model_names[i], name_len)" uses uninitialized > > data because "name" is uninitialized. > > This causes memory leak, AFAICT. > > Signed-off-by: Pavel Machek (CIP) <pavel@denx.de> Again, this is not how to submit patches, and you know this. You are one more email-like-this away from my circular-file filter... greg k-h