Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp263208pxa; Wed, 19 Aug 2020 00:02:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy8VARknb2KDJcmK3x5golS4m8WKHwghd093cKLafq+arF40lcVpSubAyRCRcmK4s68V1E+ X-Received: by 2002:a17:906:1f8e:: with SMTP id t14mr24392011ejr.336.1597820528142; Wed, 19 Aug 2020 00:02:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597820528; cv=none; d=google.com; s=arc-20160816; b=DL6I+YgcwFldsHZgt0aOly+q2EPQXdUjWZrPLOjsTYOQ13BA/RW1PIMJo8XC6fWOQw GfiE3AqRr3eV95/jYPjbnpkWHkSaa6VNM2RUdidxB1mkOcpFQ4dBrBlJijkAwg0bnawE wUiJkqIrpvn/nqJdb0hp0sD4roZw0yLn8u/rn/3JpAwoFJEkFoHYNQ1fJvCfUmLQ/s0R QpBPoWdNgRLi0ytXDdBf6O5DV5sual8DzVXc0zm/7/U5Yw4atUGuGwmw1z52XqAwIWmD /cMoMaAcS0Dybxgcprp58mrv36oVJ7ZIYvqT8C8aml8N30Vn04+yj3EAj2NS29itqOnM q6Jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=n4jQXphtlWRBonOsn2A/IyhKyng5urQ9vpv5ufSXxPk=; b=SrSGD3hyjxnZ9Cv++/7mnwUbI3X/RE9vHv/06P66zxr8F8UyYgWCcZynCMup3218Y4 CPAeP9mvXXDjs7VSpBG1gAeDABAdEMieopw1dDR6ve1MTCHGRkklFQr+WtHxaGp6sAm3 kISs9+as506fRfjTk9YGYYXQtX3kKo1IckDU2F94OMTTM6+67sjQOAXGKkb9MJLFpfbV muE2VYk6ZFeuGw1hUvKtM4qHGWPreRm1eRZqmphzlR3QA5xdQbvXU3DODOyG1EeAUPFK CG3mCxzijAaomumeMtIZNSJgb+XWurljq3TB3hsnCLE0AWhqevBpMHIHe8QL3Wn/ozqz yiQA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=KZRDty0L; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i21si14914409eje.143.2020.08.19.00.01.42; Wed, 19 Aug 2020 00:02:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=KZRDty0L; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727113AbgHSG7L (ORCPT + 99 others); Wed, 19 Aug 2020 02:59:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728050AbgHSG5t (ORCPT ); Wed, 19 Aug 2020 02:57:49 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30CEEC061389; Tue, 18 Aug 2020 23:57:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=n4jQXphtlWRBonOsn2A/IyhKyng5urQ9vpv5ufSXxPk=; b=KZRDty0LVAb6IYb2EgXMMhn/94 SNEs4mh9p9rnpC99fbEF92zB0m3D7WvJjRrv50NXQbUGZKAsDefMFkOeLXMlu5DGet/i0Q9+pl76I aaliGVgEvwT5cxt1TbyaDjkrLykaxId7hOxXC+ZOaJy8uANKWgBSuv8uzKG0dIz02N2Wnv5H5ODMi ttApx1YRztY1G2Z8kh2b2znxpwj3fI2l7IbnOPpFlIj5pd/gOp3ou9Ec/tRlwpM24x+nOxNVfmTEW S+hiYJx3yCvEXbP8d1qXwPlzIa+qdIhtu9aJV1TdaM8Wtl9rPhU5pdy8P2ws0LiXUnHKn5IwFwvO7 bsGbSO+A==; Received: from [2001:4bb8:198:f3b2:86b6:2277:f429:37a1] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8I1u-00007J-2i; Wed, 19 Aug 2020 06:57:02 +0000 From: Christoph Hellwig To: Mauro Carvalho Chehab , Thomas Bogendoerfer , "James E.J. Bottomley" , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Ben Skeggs , Pawel Osciak , Marek Szyprowski , Matt Porter , iommu@lists.linux-foundation.org Cc: Tom Lendacky , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, nouveau@lists.freedesktop.org, netdev@vger.kernel.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, linux-mm@kvack.org, alsa-devel@alsa-project.org Subject: [PATCH 27/28] nvme-pci: fix PRP pool size Date: Wed, 19 Aug 2020 08:55:54 +0200 Message-Id: <20200819065555.1802761-28-hch@lst.de> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200819065555.1802761-1-hch@lst.de> References: <20200819065555.1802761-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org All operations are based on the controller, not the host page size. Switch the dma pool to use the controller page size as well to avoid massive overallocations on large page size systems. Signed-off-by: Christoph Hellwig --- drivers/nvme/host/pci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index ba725ae47305ef..a33adab62acbaf 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -2460,7 +2460,8 @@ static int nvme_disable_prepare_reset(struct nvme_dev *dev, bool shutdown) static int nvme_setup_prp_pools(struct nvme_dev *dev) { dev->prp_page_pool = dma_pool_create("prp list page", dev->dev, - PAGE_SIZE, PAGE_SIZE, 0); + NVME_CTRL_PAGE_SIZE, + NVME_CTRL_PAGE_SIZE, 0); if (!dev->prp_page_pool) return -ENOMEM; -- 2.28.0