Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <cover.1597729246.git.rahul.tanwar@linux.intel.com>
 <20200818083852.GC1891694@smile.fi.intel.com> <37f7526e-5a04-1d27-347c-772fe085771e@linux.intel.com>
In-Reply-To: <37f7526e-5a04-1d27-347c-772fe085771e@linux.intel.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Wed, 19 Aug 2020 10:54:11 +0300
Message-ID: <CAHp75VfDq7bRe6YQdUQyv=8jK737-QwpxZjGZ2HxCJ7iaQPwMg@mail.gmail.com>
Subject: Re: [PATCH v7 0/2] pwm: intel: Add PWM driver for a new SoC
To:     "Tanwar, Rahul" <rahul.tanwar@linux.intel.com>
Cc:     Andy Shevchenko <andriy.shevchenko@intel.com>,
        =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= 
        <u.kleine-koenig@pengutronix.de>, linux-pwm@vger.kernel.org,
        Lee Jones <lee.jones@linaro.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Rob Herring <robh+dt@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        devicetree <devicetree@vger.kernel.org>, songjun.Wu@intel.com,
        cheol.yong.kim@intel.com, qi-ming.wu@intel.com,
        rahul.tanwar.linux@gmail.com, rtanwar@maxlinear.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Aug 19, 2020 at 7:18 AM Tanwar, Rahul
<rahul.tanwar@linux.intel.com> wrote:
>
>
> Hi Andy,
>
> On 18/8/2020 4:38 pm, Andy Shevchenko wrote:
> > On Tue, Aug 18, 2020 at 01:48:59PM +0800, Rahul Tanwar wrote:
> >> Patch 1 adds dt binding document in YAML format.
> >> Patch 2 add PWM fan controller driver for LGM SoC.
> >>
> >> v7:
> >> - Address code quality related review concerns.
> >> - Rename fan related property to pwm-*.
> >> - Fix one make dt_binding_check reported error.
> > I guess it misses the answer why pwm-fan can't be integrated into the soup?
> >
>
> Can you please elaborate more? I could not understand your point clearly.

It's not mine, it's Uwe's. There is an hwmon module called pwm-fan. As
far as *I* understand this, it can be utilized to control fans via PWM
APIs. And Uwe asked you if you considered that and why you don't
integrated  (coupled) it here.

-- 
With Best Regards,
Andy Shevchenko