Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 19 Aug 2020 09:26:50 +0100
From:   Lee Jones <lee.jones@linaro.org>
To:     Icenowy Zheng <icenowy@aosc.io>
Cc:     linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: core: Fix handle of OF disabled MFD cells
Message-ID: <20200819082650.GC4354@dell>
References: <20200801070130.3323112-1-icenowy@aosc.io>
 <20200819081122.GB4354@dell>
 <3b0ba1c95efa2ac465d9b6312b8e0e2c8fb461b5.camel@aosc.io>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <3b0ba1c95efa2ac465d9b6312b8e0e2c8fb461b5.camel@aosc.io>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 19 Aug 2020, Icenowy Zheng wrote:

> 在 2020-08-19星期三的 09:11 +0100，Lee Jones写道：
> > On Sat, 01 Aug 2020, Icenowy Zheng wrote:
> > 
> > > When rewriting the OF match code of MFD core, addition of cells
> > > disabled
> > > in OF will result in a failure with error -ENODEV. This is an
> > > unexpected
> > > behavior, as the previous behavior is silently ignore the cell. On
> > > SBCs with AXP20x PMICs, this leads to boot failure if AXP20x PMIC
> > > support is built-in and some cells (especially power supply ones)
> > > are
> > > disabled.
> > 
> > Thanks for reporting this.
> > 
> > Do you mind if I fix this another way?  I plan to reinstate the old
> > code that was removed as part of the offending patch.  I will of
> > course add your Reported-by tag.
> 
> I think it's okay.
> 
> I will test it once it's out.

That would be great.  Then I can add your Tested-by also.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog