Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp302232pxa; Wed, 19 Aug 2020 01:29:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzqH27uSrV4FhBSaUmQ7htjmRLwzRzMu6vqzUi3v7cb19jiL4E08Z8vXWUhIVZqJ/8IVXyr X-Received: by 2002:a50:ba84:: with SMTP id x4mr24643330ede.282.1597825764851; Wed, 19 Aug 2020 01:29:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597825764; cv=none; d=google.com; s=arc-20160816; b=L005lH+2mIehMido3U4X8JoIlITyT37ZV59u8OTSoZVp1EBCcoS6sMjMIHZ+pxZmW2 E+C2StnmhbUxbMYTEvRN4DLz6fcMyEI1Sjn1LFoJCaTLgrgKNMhHhPW5asjBK1cKC4/9 14gZGRVzLemTN2RzITzS6/1xPN3ugQ9soLmYxt6f61uecKPr2hs8l0fm+OUp5XICBX6W 2gwWvlpFoNBCCXhxA0O/M4b6jYybligfC5+epmYJfutfq2XKt6epqRmXHLnMwKjt+3Tz 5x2nTfKE3QgERtO7CvfwO5/0QRj/cRDK5dwxBXTYuOZmvT73pVZnaexQUcETnmiehEqV hwsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=LipnQomgusWkQDiMoDQzOm9zSs4RZrcniztXkABqM2A=; b=C/kLuFWzUbcWuxA7OtyWxuTr8tPJa8Z6mwPa1lG11CM3MM6RZo5hrwsUbpb3PNt9Ke 9/pu+YANOlTH0Glz5zGnMiY/BUyS1VLJwsvfhcbxYd97vcpShuGpFuNAgSUAMeHgcyBS 09R8A5kY8zkhVnMERG7kektJgL1HDYrYSTDTjCsfdabIbLYVY93Tu0VBaF93DSVB1/xy 9WivzVb6TGgD/TuLllvhS0zFyUMKmQwCqUX5AQAjSxD9YYs2f+XUETJsm868Ert28Jcl 37HkRVMsufCkOBbdVc1GXx9t9dpqVvI31/BXCS8WAl8NtkO70zCvfPI3VG0eNIFlOVJM 0cHA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fbutXiAa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n6si13944359ejg.175.2020.08.19.01.29.00; Wed, 19 Aug 2020 01:29:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fbutXiAa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726735AbgHSI1y (ORCPT + 99 others); Wed, 19 Aug 2020 04:27:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:43338 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725903AbgHSI1x (ORCPT ); Wed, 19 Aug 2020 04:27:53 -0400 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8306C20738; Wed, 19 Aug 2020 08:27:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597825673; bh=xkrOW1eiodxf6e55kbWanf+5qeDDwj1oob7ZKgc2bX4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fbutXiAaMlm/H9YbBaBayrJHz65E2rmbWgxqxuAdUYACLzGZK6lRujSRmkHg6MBoT jkPxKn2GE0mKyF++r7fCvlhIJSNDTQcpbUNxAFV9oO15FPtc09hhUgH/hTAm9Ueu5o xhq/e/O3Z4iYD7DK533RIYA+NrqZcpkxHyKy533M= Date: Wed, 19 Aug 2020 09:27:47 +0100 From: Will Deacon To: Linus Torvalds Cc: Yang Shi , Yu Xu , Johannes Weiner , Catalin Marinas , Will Deacon , Andrew Morton , Linux-MM , Linux Kernel Mailing List , stable Subject: Re: [v3 PATCH] mm/memory.c: skip spurious TLB flush for retried page fault Message-ID: <20200819082747.GA17345@willie-the-truck> References: <20200815043041.132195-1-shy828301@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 18, 2020 at 12:01:43PM -0700, Linus Torvalds wrote: > On Mon, Aug 17, 2020 at 2:04 PM Yang Shi wrote: > > > > We could just skip the spurious TLB flush to mitigate the regression. > > Ok, this patch I will apply. Cheers. > I still hope that arm64 fixes (maybe already fixed) their spurious TLB > function, and I think we should rename it to make sure everybody > understands it's local, but in the meantime this patch hides the > regression and isn't wrong. I'll look at it for 5.10. Will