Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp330340pxa; Wed, 19 Aug 2020 02:30:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxwpTMmU+wMiaP01TsXy28lj0FZU/AhSEzDiPLYli3U+Sd1Mz1xV2DWDW+duTX/I+pkWl5w X-Received: by 2002:a17:906:3655:: with SMTP id r21mr25031749ejb.248.1597829411485; Wed, 19 Aug 2020 02:30:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597829411; cv=none; d=google.com; s=arc-20160816; b=beyoH3YgsJYLgtiF9MM5QO9eDSyS0WGYDFpdW/JQL8cPzk+B56gAmQKjTYPEWYMQex XqDYepvgkfmD13PbMYbGL8/mI3t20GwF2AXyHN9LWGqQdXUr1lS8t0kAq/q0obrFD3bc JVYGYwaUKr1B2gkVUYDqActhSf00iq0dxTfckm605jSzWJZabZwn9ctl+Cq4m5n4i0VP AfAqRDujXSqsg4NYjnUZ2BAs0/zeissyacNg26LiQBEwd7HhfW8nWhKy1G+VH7VzM/Ft jvySCkQx1bJSuPcgEVah5sud/BAbW9VD0ru5OEkwXMlUMrzQscyqR7M4P4hxEViucJ91 v3Rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=ntE1vvTIudOXVnPDj98QnsT1cGzJ/H2zXh4ruJy2zjU=; b=WNo8g3+41MrovvyxDYWJ+Co1exd5ssVdF4oXitBNrB6KFnzi7YpYV9HIAhv192RQdD IaPuVf0rXP60V7sT1LNMGj1mdxitsRlgoGo76MUkIM8Hgh83mop4tYup51Mu0rUYQlxr v2bX38VfroeLgwSkIvE9/tjmXLteLWeYauOAoTi8M9hhVORS/W9HEp3uxdbRhww1928T DbHONgeH6ylNYCgGaYeUsfKbAp98Vj/NFq84uXWBQ74VayLmj3kovvi1HabPa3QrKDgV EDPky685uq7NVE6OKruu0d7Menmwy0Jj9pR1h7gzQXQWBTlBDtek2OZrUrG3zQJeNti2 Uu7A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c12si15559938ejz.120.2020.08.19.02.29.47; Wed, 19 Aug 2020 02:30:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727079AbgHSJZy (ORCPT + 99 others); Wed, 19 Aug 2020 05:25:54 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:9774 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727036AbgHSJZt (ORCPT ); Wed, 19 Aug 2020 05:25:49 -0400 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id E94A07D411AA8952CCCE; Wed, 19 Aug 2020 17:25:47 +0800 (CST) Received: from localhost.localdomain (10.69.192.56) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.487.0; Wed, 19 Aug 2020 17:25:40 +0800 From: Tian Tao To: , , , , , , , , CC: Subject: [PATCH drm/hisilicon v2 3/4] drm/hisilicon: Use drm_err instead of DRM_ERROR in hibmc_drm_de Date: Wed, 19 Aug 2020 17:23:33 +0800 Message-ID: <1597829014-39942-4-git-send-email-tiantao6@hisilicon.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1597829014-39942-1-git-send-email-tiantao6@hisilicon.com> References: <1597829014-39942-1-git-send-email-tiantao6@hisilicon.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.69.192.56] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use drm_err instead of DRM_ERROR in hibmc_drm_de Signed-off-by: Tian Tao --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c index d9062a3..4d57ec6 100644 --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c @@ -71,12 +71,12 @@ static int hibmc_plane_atomic_check(struct drm_plane *plane, return PTR_ERR(crtc_state); if (src_w != state->crtc_w || src_h != state->crtc_h) { - DRM_DEBUG_ATOMIC("scale not support\n"); + drm_dbg_atomic(plane->dev, "scale not support\n"); return -EINVAL; } if (state->crtc_x < 0 || state->crtc_y < 0) { - DRM_DEBUG_ATOMIC("crtc_x/y of drm_plane state is invalid\n"); + drm_dbg_atomic(plane->dev, "crtc_x/y of drm_plane state is invalid\n"); return -EINVAL; } @@ -87,12 +87,12 @@ static int hibmc_plane_atomic_check(struct drm_plane *plane, crtc_state->adjusted_mode.hdisplay || state->crtc_y + state->crtc_h > crtc_state->adjusted_mode.vdisplay) { - DRM_DEBUG_ATOMIC("visible portion of plane is invalid\n"); + drm_dbg_atomic(plane->dev, "visible portion of plane is invalid\n"); return -EINVAL; } if (state->fb->pitches[0] % 128 != 0) { - DRM_DEBUG_ATOMIC("wrong stride with 128-byte aligned\n"); + drm_dbg_atomic(plane->dev, "wrong stride with 128-byte aligned\n"); return -EINVAL; } return 0; @@ -515,7 +515,7 @@ int hibmc_de_init(struct hibmc_drm_private *priv) NULL); if (ret) { - DRM_ERROR("failed to init plane: %d\n", ret); + drm_err(dev, "failed to init plane: %d\n", ret); return ret; } @@ -524,13 +524,13 @@ int hibmc_de_init(struct hibmc_drm_private *priv) ret = drm_crtc_init_with_planes(dev, crtc, plane, NULL, &hibmc_crtc_funcs, NULL); if (ret) { - DRM_ERROR("failed to init crtc: %d\n", ret); + drm_err(dev, "failed to init crtc: %d\n", ret); return ret; } ret = drm_mode_crtc_set_gamma_size(crtc, 256); if (ret) { - DRM_ERROR("failed to set gamma size: %d\n", ret); + drm_err(dev, "failed to set gamma size: %d\n", ret); return ret; } drm_crtc_helper_add(crtc, &hibmc_crtc_helper_funcs); -- 2.7.4