Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 19 Aug 2020 12:51:16 +0200
From:   Alexandre Belloni <alexandre.belloni@bootlin.com>
To:     Reto Schneider <code@reto-schneider.ch>
Cc:     linux-arm-kernel@lists.infradead.org,
        Reto Schneider <reto.schneider@husqvarnagroup.com>,
        Stefan Roese <sr@denx.de>,
        Michael Zimmermann <michael.zimmermann@grandcentrix.net>,
        Rob Herring <robh+dt@kernel.org>,
        Nicolas Ferre <nicolas.ferre@microchip.com>,
        Ludovic Desroches <ludovic.desroches@microchip.com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: at91: Add GARDENA smart Gateway AT91SAM board
Message-ID: <20200819105116.GI4500@piout.net>
References: <20200810171921.8679-1-code@reto-schneider.ch>
 <20200817102136.GC4500@piout.net>
 <02431938-63ac-7f90-d985-534bcd60aac2@reto-schneider.ch>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <02431938-63ac-7f90-d985-534bcd60aac2@reto-schneider.ch>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 19/08/2020 11:04:48+0200, Reto Schneider wrote:
> Hi Alexandre,
> 
> On 8/17/20 12:21 PM, Alexandre Belloni wrote:
> > Thank you for this submission.
> 
> Thanks a lot for the feedback.
> 
> I will send a v2.
> 
> > Overall, I'm not convinced it is a good idea to start from
> > at91sam9x5ek.dtsi as it makes you dtb bigger than necessary but if you
> > want it that way, I'm fine with that.
> 
> Because using at91sam9x5ek.dtsi saves some code (maintenance effort?!) I
> am willing to accept the extra binary size.
> However, if you think that this causes the maintenance efforts to be
> greater than when doing it your way, I'd be up for changing it.
> 

I'd say at91sam9x5ek.dtsi has very little chances to change and even if
this is the case, it will probably not break your device tree but it is
still a possibility.

As said, I'll let you choose.


-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com