Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200729093450.28585-1-zhang.lyra@gmail.com> <CADBw62p=aB3EZYkMm44Zx4Krww21SS9vCsMnPOq0pn2DgA8VkQ@mail.gmail.com>
In-Reply-To: <CADBw62p=aB3EZYkMm44Zx4Krww21SS9vCsMnPOq0pn2DgA8VkQ@mail.gmail.com>
From:   Chunyan Zhang <zhang.lyra@gmail.com>
Date:   Wed, 19 Aug 2020 19:35:06 +0800
Message-ID: <CAAfSe-vEW5CDJnae3AHwciAsinvMvuUAdv8TiCkxEjNga8U=SQ@mail.gmail.com>
Subject: Re: [PATCH] gpio: sprd: Clear interrupt when setting the type as edge
To:     Baolin Wang <baolin.wang7@gmail.com>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>,
        linux-gpio@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
        Orson Zhai <orsonzhai@gmail.com>,
        Chunyan Zhang <chunyan.zhang@unisoc.com>,
        Taiping Lai <taiping.lai@unisoc.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

[reply behalf on Taipin]

Hi Baolin,

On Sat, 1 Aug 2020 at 07:59, Baolin Wang <baolin.wang7@gmail.com> wrote:
>
> On Wed, Jul 29, 2020 at 5:35 PM Chunyan Zhang <zhang.lyra@gmail.com> wrote:
> >
> > From: Taiping Lai <taiping.lai@unisoc.com>
> >
> > The raw interrupt status of GPIO maybe set before the interrupt is enabled,
> > which would trigger the interrupt event once enabled it from user side.
> > This is the case for edge interrupts only. Adding a clear operation when
> > setting interrupt type can avoid that.
> >
> > Fixes: 9a3821c2bb47 ("gpio: Add GPIO driver for Spreadtrum SC9860 platform")
> > Signed-off-by: Taiping Lai <taiping.lai@unisoc.com>
> > Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com>
> > ---
> >  drivers/gpio/gpio-sprd.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/gpio/gpio-sprd.c b/drivers/gpio/gpio-sprd.c
> > index d7314d39ab65..36ea8a3bd451 100644
> > --- a/drivers/gpio/gpio-sprd.c
> > +++ b/drivers/gpio/gpio-sprd.c
> > @@ -149,17 +149,20 @@ static int sprd_gpio_irq_set_type(struct irq_data *data,
> >                 sprd_gpio_update(chip, offset, SPRD_GPIO_IS, 0);
> >                 sprd_gpio_update(chip, offset, SPRD_GPIO_IBE, 0);
> >                 sprd_gpio_update(chip, offset, SPRD_GPIO_IEV, 1);
> > +               sprd_gpio_update(chip, offset, SPRD_GPIO_IC, 1);
>
> I think you should move this abonormal interrupt clearing operation to
> sprd_gpio_request(), when users request a GPIO.

We have a few considerations:
1) Like described in the commit message, the problem this patch solves
is for edge interrupt only; The interrupt requested by user is
IRQ_TYPE_LEVEL_HIGH as default, so clearing interrupt when request is
useless.
2) We can set interrupt type to edge when request, and following up
with clearing it, but the problem is still there once users set the
interrupt type to level trggier.
3) We can add a clear operation after each time of setting interrupt
enable bit, but it is redundant for level trigger interrupt.

Therefore, adding a clear operation when setting interrupt type seems
the best solutions which I can think out so far.

>
> >                 irq_set_handler_locked(data, handle_edge_irq);
> >                 break;
> >         case IRQ_TYPE_EDGE_FALLING:
> >                 sprd_gpio_update(chip, offset, SPRD_GPIO_IS, 0);
> >                 sprd_gpio_update(chip, offset, SPRD_GPIO_IBE, 0);
> >                 sprd_gpio_update(chip, offset, SPRD_GPIO_IEV, 0);
> > +               sprd_gpio_update(chip, offset, SPRD_GPIO_IC, 1);
> >                 irq_set_handler_locked(data, handle_edge_irq);
> >                 break;
> >         case IRQ_TYPE_EDGE_BOTH:
> >                 sprd_gpio_update(chip, offset, SPRD_GPIO_IS, 0);
> >                 sprd_gpio_update(chip, offset, SPRD_GPIO_IBE, 1);
> > +               sprd_gpio_update(chip, offset, SPRD_GPIO_IC, 1);
> >                 irq_set_handler_locked(data, handle_edge_irq);
> >                 break;
> >         case IRQ_TYPE_LEVEL_HIGH:
> > --
> > 2.20.1
> >
>
>
> --
> Baolin Wang