Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp402630pxa; Wed, 19 Aug 2020 04:51:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwleia8ipUYVHY0OUIGgyi2Iid7R8npV5/DjnDJ3V0nsmHxtxSEr+oZEe32WqhCr9AGmNGe X-Received: by 2002:a05:6402:2031:: with SMTP id ay17mr23613872edb.46.1597837868960; Wed, 19 Aug 2020 04:51:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597837868; cv=none; d=google.com; s=arc-20160816; b=bcLKDtF6gc085YLak8wO/CiD4knzEZFN2y6yD7FIwfFG43HAzJIatf/vxC3BlyJC++ lTc82UZszTF5vHPpnZNTfnH5fXB6f+kaA+VEKZQ1K02W1QGpmrEAlAHXqBc5CK0J0ZGR uEIdMy0XtX1ymPGxN153ha2XgtTeIel+DmrAb5MWKfTjFZxt3+uRFKl2pwKYQvQJ0uU+ eONQZbx/jneyK5EIId28WqfaTJZROfi64gPAbiUksOxIW2PZnOE3+cMTBhIvZwMvmE6h 2b4PhmWIY+WVIejFEAqEN9qWav2cwRPcaec+22I8W4fYyFhozQ/RRFhraWv7AaZ5H+4k W0mA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=DU5HdE6a5nhvHtZ74SWLSmAIgydDRkOxRUGrjdHg6xk=; b=m/9sdeT4RnACLe6FkxXlRRx9C5m/ODVd+EtEDwPXtzgUul9VT5mI67gMEhakGxk8Ce UJx45xBwCdh5qwlVJ0vYmS0hHlgNiiZAKFB/9xC2EljCpiHX+Pquk0BhWtiYx3DhBTIn 4tnVN8B1Bn7s+ivk6O9ZSPh1RMjiQDq6CgCEDlB/WUUmlj3KrDD5gw289ZFF75qLHgAc bu7WXAMyKbUIMBZCjoZWIsG2Kr2/Zps7D31KVC9Bnh9CkEZy4zPB2md5qpm1s+7xCcDL 0my4YDxSRUgEYTq/g9KY2nxoeUtv85As4aVnlQ4FsZQrHJUuoFIiGVSXT/+R2yEYjIck OfFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=L8gwwe9M; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s11si15283171edi.214.2020.08.19.04.50.44; Wed, 19 Aug 2020 04:51:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=L8gwwe9M; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728081AbgHSLtj (ORCPT + 99 others); Wed, 19 Aug 2020 07:49:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:46516 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728134AbgHSLqw (ORCPT ); Wed, 19 Aug 2020 07:46:52 -0400 Received: from mail.kernel.org (ip5f5ad5a3.dynamic.kabel-deutschland.de [95.90.213.163]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2DFCF22B49; Wed, 19 Aug 2020 11:46:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597837582; bh=2yQjdvyRlegxhP3g7Ww09HkpPA50NKlkwbqSSbfz3Bk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=L8gwwe9Mb1Pjem3EbtG1gQA62R5MrWxIbVz0rdlyzmoWdbw9/6rNg93zczReSjsZC aVD6mSZUdws0YLOPBUmQFdw/LGGQwBl2fSmz49BhUc5yDzrG0Bbk2xo9oWyYzeHH68 8YVN2k5bqWCSaOhRCqjtx9NnDQ+ABfnfXGbeIZHM= Received: from mchehab by mail.kernel.org with local (Exim 4.94) (envelope-from ) id 1k8MXs-00Euak-5K; Wed, 19 Aug 2020 13:46:20 +0200 From: Mauro Carvalho Chehab To: Greg Kroah-Hartman Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Mauro Carvalho Chehab , John Stultz , Manivannan Sadhasivam , Daniel Vetter , dri-devel , Xiubin Zhang , Liwei Cai , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH 19/49] staging: hikey9xx/gpu: add a copy of set_reg() function there Date: Wed, 19 Aug 2020 13:45:47 +0200 Message-Id: X-Mailer: git-send-email 2.26.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This function has a too generic name to export it as a symbol. Also, we should likely use some other macro instead. So, for now, just copy it into the Kirin9xx dsi module, in order for the driver to build. Signed-off-by: Mauro Carvalho Chehab --- .../staging/hikey9xx/gpu/kirin9xx_dw_drm_dsi.c | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/drivers/staging/hikey9xx/gpu/kirin9xx_dw_drm_dsi.c b/drivers/staging/hikey9xx/gpu/kirin9xx_dw_drm_dsi.c index cfb6bfd1c338..cba81ee2639d 100644 --- a/drivers/staging/hikey9xx/gpu/kirin9xx_dw_drm_dsi.c +++ b/drivers/staging/hikey9xx/gpu/kirin9xx_dw_drm_dsi.c @@ -37,7 +37,6 @@ #else #include "kirin960_dpe_reg.h" #endif -#include "kirin9xx_drm_dpe_utils.h" #include "kirin9xx_drm_drv.h" #if defined (CONFIG_DRM_HISI_KIRIN970) @@ -270,6 +269,22 @@ static const struct dsi_phy_range dphy_range_info[] = { { 1000000, 1500000, 0, 0 } }; +/* + * Except for debug, this is identical to the one defined at + * kirin9xx_drm_dpe_utils.h. + */ +static void set_reg(char __iomem *addr, uint32_t val, uint8_t bw, + uint8_t bs) +{ + u32 mask = (1UL << bw) - 1UL; + u32 tmp = 0; + + tmp = inp32(addr); + tmp &= ~(mask << bs); + + outp32(addr, tmp | ((val & mask) << bs)); +} + void dsi_set_output_client(struct drm_device *dev) { struct drm_connector_list_iter conn_iter; -- 2.26.2