Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp519423pxa; Wed, 19 Aug 2020 07:48:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzV925b1l1wcx/l14yCW+nhOXe6HjwjPod6RUec90BEcMjkLno1hZ2J5KzNR3Spr+zJbbz3 X-Received: by 2002:a17:906:ce43:: with SMTP id se3mr24987541ejb.403.1597848501524; Wed, 19 Aug 2020 07:48:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597848501; cv=none; d=google.com; s=arc-20160816; b=TIwFYv1XXT0t+JaggvziERVTj4n7kDNcQWDBsGFb1tpOl8OXalvS+v1M4xyzzwbCkO cndVgqVQUkVZCwNEYoUFiXa5WR+I+ghyEE07r1XwEq0miSVr3tkF1zq7AduB+DxfhkmR B5che2+Tugl3ujBfxYKKCHUevQ1NvjMNwy3axNLzeqFe/ZUtppVYcDRJ4sG0DEcDWVSn MpaJRx8LjYli/ghkohTg6OWgIWBxtXefX9bVsQ54fywxvRpObUQcTPzOAZuavNZSKTR/ oJnLjuGdQmD3Eopqp1CgtPySu//GOgN5Wq4JQsN2V9YGg3/4HSGHqQ5Kj4LMcTzOTQI8 Mb6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:mime-version:message-id :date:subject:cc:to:from; bh=r259BE/Wv/192bTP/TCyvzCie6DbWCgPuvthR/nJltQ=; b=mVa58zKS9vmxI3pEOaP6Q6ZPF65QQXEIxjiJsQslKIGO+0QYOdnIHH3YM+0hMBXtPB Eozu1IPlnU0LZh6190ayR+Cl/SH1FiOPiXXRfLOGYKVG5KIbP+jy3RFxggvDmiKItnL2 K944+NgL6vkmNUgs7m1yMS2g/YogmnFQASeGlSENRAoRVyzbJuELFVxzU+s1ueNDOoSe Suz8Iep/19ZyuHwCvvSKHSrFwmE5L91Exs4JwO5ZT4g8UE5w+ijNlvhoBlMSaITT5Q4R 0CPX0NgssdIBzlVW7XbTZi9ZwDb1ry2tDbafGPKL8jkuUFfpTu19eqQf0p20sSWCHDhX QiTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b="Ecu/ODBI"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k3si15173026eds.225.2020.08.19.07.47.54; Wed, 19 Aug 2020 07:48:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b="Ecu/ODBI"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727932AbgHSOo7 (ORCPT + 99 others); Wed, 19 Aug 2020 10:44:59 -0400 Received: from hqnvemgate24.nvidia.com ([216.228.121.143]:4386 "EHLO hqnvemgate24.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726578AbgHSOo6 (ORCPT ); Wed, 19 Aug 2020 10:44:58 -0400 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Wed, 19 Aug 2020 07:43:04 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Wed, 19 Aug 2020 07:44:58 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Wed, 19 Aug 2020 07:44:58 -0700 Received: from HQMAIL101.nvidia.com (172.20.187.10) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 19 Aug 2020 14:44:54 +0000 Received: from rnnvemgw01.nvidia.com (10.128.109.123) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Wed, 19 Aug 2020 14:44:53 +0000 Received: from audio.nvidia.com (Not Verified[10.24.34.185]) by rnnvemgw01.nvidia.com with Trustwave SEG (v7,5,8,10121) id ; Wed, 19 Aug 2020 07:44:52 -0700 From: Sameer Pujar To: , CC: , , , , , Sameer Pujar , Subject: [PATCH] ALSA: hda: avoid reset of sdo_limit Date: Wed, 19 Aug 2020 20:14:33 +0530 Message-ID: <1597848273-25813-1-git-send-email-spujar@nvidia.com> X-Mailer: git-send-email 2.7.4 X-NVConfidentiality: public MIME-Version: 1.0 Content-Type: text/plain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1597848184; bh=r259BE/Wv/192bTP/TCyvzCie6DbWCgPuvthR/nJltQ=; h=X-PGP-Universal:From:To:CC:Subject:Date:Message-ID:X-Mailer: X-NVConfidentiality:MIME-Version:Content-Type; b=Ecu/ODBICncWcP0dg0JsCV7FRbRSnUqbk/Ft+GUPzyLqLLVoquI+v0jkGHvV/pJXk CBYqHC4HjwVrM1m9RYJi785xNN0M7UZS1A2gpYlMiF7TGlwd2NJzGeo71R8aDAGD2i wlH23T6yNpM4V/wmoCxc+J1s5KRTDVinuw6jcrLp42113HHq9f03zBlTkbkPXk5OKm xNrvv2oGHIq5qRgiWizdodtisOT9F8YpP8cEGnpaUqbszfT9NosHWoXXdy0kHPHE7+ BpunBnyMDEjqos0NvUnRwoWzuozHoYw8P+mozSJq1jliIK0m4t/8j/+aUsz6tPOlXq D1SVhSTbwzA0g== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org By default 'sdo_limit' is initialized with a default value of '8' as per spec. This is overridden in cases where a different value is required. However this is getting reset when snd_hdac_bus_init_chip() is called again, which happens during runtime PM cycle. Avoid reset by not initializing to default value everytime. Fixes: 67ae482a59e9 ("ALSA: hda: add member to store ratio for stripe control") Cc: Signed-off-by: Sameer Pujar --- sound/hda/hdac_controller.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/hda/hdac_controller.c b/sound/hda/hdac_controller.c index 011b17c..0e26e96 100644 --- a/sound/hda/hdac_controller.c +++ b/sound/hda/hdac_controller.c @@ -538,7 +538,8 @@ bool snd_hdac_bus_init_chip(struct hdac_bus *bus, bool full_reset) * { ((num_channels * bits_per_sample * rate/48000) / * number of SDOs) >= 8 } */ - bus->sdo_limit = 8; + if (!bus->sdo_limit) + bus->sdo_limit = 8; return true; } -- 2.7.4