Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 19 Aug 2020 16:53:17 +0200
Message-ID: <s5hmu2qhele.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Sameer Pujar <spujar@nvidia.com>
Cc:     <tiwai@suse.com>, <perex@perex.cz>, <kai.vehmanen@linux.intel.com>,
        <yang.jie@linux.intel.com>, <pierre-louis.bossart@linux.intel.com>,
        <alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>,
        <stable@vger.kernel.org>
Subject: Re: [PATCH] ALSA: hda: avoid reset of sdo_limit
In-Reply-To: <1597848273-25813-1-git-send-email-spujar@nvidia.com>
References: <1597848273-25813-1-git-send-email-spujar@nvidia.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 19 Aug 2020 16:44:33 +0200,
Sameer Pujar wrote:
> 
> By default 'sdo_limit' is initialized with a default value of '8'
> as per spec. This is overridden in cases where a different value is
> required. However this is getting reset when snd_hdac_bus_init_chip()
> is called again, which happens during runtime PM cycle. Avoid reset
> by not initializing to default value everytime.
> 
> Fixes: 67ae482a59e9 ("ALSA: hda: add member to store ratio for stripe control")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Sameer Pujar <spujar@nvidia.com>

How about to move the default sdo_limit setup into snd_hdac_bus_init()
instead?  That's the place to be called only once.


thanks,

Takashi


> ---
>  sound/hda/hdac_controller.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/hda/hdac_controller.c b/sound/hda/hdac_controller.c
> index 011b17c..0e26e96 100644
> --- a/sound/hda/hdac_controller.c
> +++ b/sound/hda/hdac_controller.c
> @@ -538,7 +538,8 @@ bool snd_hdac_bus_init_chip(struct hdac_bus *bus, bool full_reset)
>  	 *   { ((num_channels * bits_per_sample * rate/48000) /
>  	 *	number of SDOs) >= 8 }
>  	 */
> -	bus->sdo_limit = 8;
> +	if (!bus->sdo_limit)
> +		bus->sdo_limit = 8;
>  
>  	return true;
>  }
> -- 
> 2.7.4
>