Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp536143pxa; Wed, 19 Aug 2020 08:10:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzd7I4kc0SsMc3c1+rMPKZDgiUva29fi707IifvCx5mwMND/DGAps1KBacenZGh/hm2Zzqj X-Received: by 2002:a17:906:5812:: with SMTP id m18mr25928942ejq.66.1597849804986; Wed, 19 Aug 2020 08:10:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597849804; cv=none; d=google.com; s=arc-20160816; b=Q8tDlTDQ2gpsmOp9Ow4cOr9JXME4okLYRlH66wROsxeZihFOsDSYf2xOJZNOqBScJE A7SnTKEYYhMfLrvSnn5SqpTxxcytyS4OLFgcqApdbreH6u0NWmFcIt0U9+GEta1gEV3P phGTf4xVuJXLlgpP7k70izECk42wXLStRChQXYBYIf6I/fUZIv1Kt/er0GaUEhgDo2JA vPvpVvqfrzeUAuCsZcd0eye1TFw1PKWvyJJyzCHKuKXGCg6roNin/1yfsZqxwnU/Uyso cucBrAr9DVxvfsnhpNqvZMZS+F2Xw4zxWkduu1ecZpUWMt2YZCTQVIIL9Jj90LlPlCOZ V2yQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=VMU155OtGZK5NBkT7Jr2yah70BMKrGVtMioV19uHfRk=; b=u9LE1t9Ku2QaU3QIUmOrqni/FdoYSKdHHPFJWofo5HZ3BTRZBLxiGJlRM27VwZLx8B gykAzMkE5cw4aD5qOiKbEWhaAhyXAe+YA8ix+v7WHo4Y/mL5vfIiGn+c55z6ZW+I8uGL YeuLxr+OYYCzvNkNLGZ00E/2Qz/7ZBrA5KEoYWX6IjoRVZCwZ//t5jF9f23prykori0c vcR7lXS+//wiS+aHY16UWqQi8sr3gChGClyHMOkto9wO6n5KuRqmGkeAOBMBDBlsCKp8 FsBmGKNc3H0kVfLJB9tdKPzQuyXBfHEY9udpzKn1l+1ES33NO93b6QDoToGKdrU6SX1h +SkQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b="UTcsu//B"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c3si16004011ejm.314.2020.08.19.08.09.40; Wed, 19 Aug 2020 08:10:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b="UTcsu//B"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728741AbgHSPGZ (ORCPT + 99 others); Wed, 19 Aug 2020 11:06:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726187AbgHSPGG (ORCPT ); Wed, 19 Aug 2020 11:06:06 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60685C061383 for ; Wed, 19 Aug 2020 08:06:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:In-Reply-To:References; bh=VMU155OtGZK5NBkT7Jr2yah70BMKrGVtMioV19uHfRk=; b=UTcsu//BYBRvVYf5ipwrND1UdG lieFl00JmTxT9xg68X9yM/U8CzQQC38hrr+gzL1ijrtliV00+PDPrmp9whTNG5HjDhErpb2LS1TI+ kU2Ow1TOcAH2flHoUFLW1zJxbRKqrv2AkMuJVD1lKGsj2GnpMq4NIbMYgVHsfHqtTy4zBBTc00RMu 1XhhWWiIbB4LW3eOw/dYYU7MSqKb9S5AE60OSM3Jla200AMo52frbqx4lWQNhiivKybELP0ISWkNl v16CLtzzd4TWTwVGPFLQgTMcD36K2vhW7b4HOzMGrXXHjxjdoPTG58vCJozzSL4+0Dd3VWhoY4OIX uyLc049w==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8Pf3-0008FX-PW; Wed, 19 Aug 2020 15:05:58 +0000 From: "Matthew Wilcox (Oracle)" To: linux-mm@kvack.org Cc: "Matthew Wilcox (Oracle)" , Andrew Morton , Hugh Dickins , William Kucharski , Johannes Weiner , Jan Kara , linux-kernel@vger.kernel.org Subject: [PATCH 0/7] Overhaul find_get_entries and pagevec_lookup_entries Date: Wed, 19 Aug 2020 16:05:48 +0100 Message-Id: <20200819150555.31669-1-willy@infradead.org> X-Mailer: git-send-email 2.21.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This started out as part of the THP patchset, but it's turned into a nice simplification in its own right. Essentially we end up unifying find_get_entries() and pagevec_lookup_entries() into one function that's better than either, and we get rid of a lot of code in the callers as a result. I'm running this through xfstests right now, but something similar to this has already passed xfstests as part of the THP patchset. I've done my best to avoid off-by-one errors for 'end', but I wouldn't be surprised if I made a mistake. We're not consistent with whether 'end' is inclusive or exclusive and I didn't want to make extensive changes to ensure they were consistent. Matthew Wilcox (Oracle) (7): mm: Use pagevec_lookup in shmem_unlock_mapping mm: Rewrite shmem_seek_hole_data mm: Add an 'end' parameter to find_get_entries mm: Add an 'end' parameter to pagevec_lookup_entries mm: Remove nr_entries parameter from pagevec_lookup_entries mm: Pass pvec directly to find_get_entries mm: Remove pagevec_lookup_entries include/linux/pagemap.h | 3 +- include/linux/pagevec.h | 4 -- mm/filemap.c | 19 +++++---- mm/shmem.c | 85 ++++++++++++++--------------------------- mm/swap.c | 38 +----------------- mm/truncate.c | 33 +++------------- 6 files changed, 45 insertions(+), 137 deletions(-) -- 2.28.0