Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 38/49] staging: hikey9xx/gpu: add kirin9xx driver to the
 building system
To:     Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     devel@driverdev.osuosl.org, Liwei Cai <cailiwei@hisilicon.com>,
        Manivannan Sadhasivam <mani@kernel.org>,
        Chen Feng <puck.chen@hisilicon.com>, linuxarm@huawei.com,
        dri-devel <dri-devel@lists.freedesktop.org>,
        Xiubin Zhang <zhangxiubin1@huawei.com>,
        John Stultz <john.stultz@linaro.org>,
        Daniel Vetter <daniel@ffwll.ch>, mauro.chehab@huawei.com,
        linux-kernel@vger.kernel.org
References: <cover.1597833138.git.mchehab+huawei@kernel.org>
 <6bb2c71410a8065e2a2c5f13294b27154dbd786b.1597833138.git.mchehab+huawei@kernel.org>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <52e4ab95-304c-54b2-e92e-099be108939e@infradead.org>
Date:   Wed, 19 Aug 2020 08:30:53 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <6bb2c71410a8065e2a2c5f13294b27154dbd786b.1597833138.git.mchehab+huawei@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 8/19/20 4:46 AM, Mauro Carvalho Chehab wrote:
> Now that everything is in place, add the driver to the
> building system.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

Hi Mauro,

In this patch and in patch 01/49, please be consistent in capitalization
on HiSilicon.

more below:

> ---
>  drivers/staging/hikey9xx/Kconfig      |  3 ++
>  drivers/staging/hikey9xx/Makefile     |  1 +
>  drivers/staging/hikey9xx/gpu/Kconfig  | 52 ++++++---------------------
>  drivers/staging/hikey9xx/gpu/Makefile | 21 ++++-------
>  4 files changed, 22 insertions(+), 55 deletions(-)
> 
> diff --git a/drivers/staging/hikey9xx/Kconfig b/drivers/staging/hikey9xx/Kconfig
> index 0e97b5b9a56a..b2ce886e1c4e 100644
> --- a/drivers/staging/hikey9xx/Kconfig
> +++ b/drivers/staging/hikey9xx/Kconfig
> @@ -36,3 +36,6 @@ config REGULATOR_HI6421V600
>  	  This driver provides support for the voltage regulators on
>  	  HiSilicon Hi6421v600 PMU / Codec IC.
>  	  This is used on Kirin 3670 boards, like HiKey 970.
> +
> +# DRM/KMS driver
> +source "drivers/staging/hikey9xx/gpu/Kconfig"

> diff --git a/drivers/staging/hikey9xx/gpu/Kconfig b/drivers/staging/hikey9xx/gpu/Kconfig
> index 5533ee624f29..957da13bcf81 100644
> --- a/drivers/staging/hikey9xx/gpu/Kconfig
> +++ b/drivers/staging/hikey9xx/gpu/Kconfig
> @@ -1,52 +1,22 @@
> -config DRM_HISI_KIRIN
> -	tristate "DRM Support for Hisilicon Kirin series SoCs Platform"> +config DRM_HISI_KIRIN9XX
> +	tristate "DRM Support for Hisilicon Kirin9xx series SoCs Platform"

	                          HiSilicon

>  	depends on DRM && OF && ARM64
>  	select DRM_KMS_HELPER
>  	select DRM_GEM_CMA_HELPER
>  	select DRM_KMS_CMA_HELPER
> -	select HISI_KIRIN_DW_DSI
> -	help
> -	  Choose this option if you have a hisilicon Kirin chipsets(hi6220).
> -	  If M is selected the module will be called kirin-drm.
> -
> -config DRM_KIRIN_960
> -	tristate "DRM Support for Hisilicon Kirin960 series SoCs Platform"
> -	depends on DRM && OF && ARM64
> -	select DRM_KMS_HELPER
> -	select DRM_GEM_CMA_HELPER
> -	select DRM_KMS_CMA_HELPER
> -	select HISI_KIRIN_DW_DSI
> -	help
> -	  Choose this option if you have a hisilicon Kirin chipsets(kirin960).
> -	  If M is selected the module will be called kirin-drm.
> -
> -config HISI_KIRIN_DW_DSI
> -	tristate "HiSilicon Kirin specific extensions for Synopsys DW MIPI DSI"
> -	depends on DRM_HISI_KIRIN || DRM_KIRIN_960
>  	select DRM_MIPI_DSI
> -	select DRM_PANEL
>  	help
> -	 This selects support for HiSilicon Kirin SoC specific extensions for
> -	 the Synopsys DesignWare DSI driver. If you want to enable MIPI DSI on
> -	 hi6220 based SoC, you should selet this option.
> +	  Choose this option if you have a HiSilicon Kirin960 or Kirin970.
> +	  If M is selected the module will be called kirin9xx-drm.

Indent with 1 tab + 2 spaces.

>  
> -config DRM_PANEL_HIKEY960_NTE300NTS
> -	tristate "Hikey960 NTE300NTS video mode panel"
> -	depends on OF
> -	depends on DRM_MIPI_DSI
> -	help
> -		Say Y here if you want to enable LCD panel driver for Hikey960 boadr.
> -		Current support panel: NTE300NTS(1920X1200)
> -
> -config HISI_FB_970
> -	tristate "DRM Support for Hisilicon Kirin970 series SoCs Platform"
> -	depends on DRM && OF && ARM64
> +config DRM_HISI_KIRIN970
> +	bool "Enable support for Hisilicon Kirin970"

	                         HiSilicon

>  	depends on DRM_MIPI_DSI
> +	depends on DRM_HISI_KIRIN9XX
>  	help
>  	  Choose this option if you have a hisilicon Kirin chipsets(kirin970).

	                                   HiSilicon

> -	  If M is selected the module will be called kirin-drm.
>  
> -config HDMI_ADV7511_AUDIO
> -	tristate "HDMI Support ADV7511 audio"
> -	help
> -	  Choose this option to support HDMI ADV7511 audio.
> +config DRM_HISI_KIRIN9XX_DSI
> +	tristate
> +	depends on DRM_HISI_KIRIN9XX
> +	default y

thanks.
-- 
~Randy