Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp556382pxa; Wed, 19 Aug 2020 08:39:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyDtqWGTR2zcKuNCsokrxudcq0UcLX2E0lc96iL/5F1G8VZmR/wvPFlKm3kaTVIB8i47ZWP X-Received: by 2002:aa7:d983:: with SMTP id u3mr26166401eds.366.1597851559114; Wed, 19 Aug 2020 08:39:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597851559; cv=none; d=google.com; s=arc-20160816; b=Ewa4wt9rZKQcf64VmyWCSTuDh42MJEu1WgnQCAI8QdUL/WtASEvXGbw5J3z4GRN1Jd lWRHPQ/UVN4kpQfUPxe8tA6PcQ+nLAGVUXL11kEf81Jq+U3JL6Si5ed0BMSc246XntVv Yom6f7SOJRRaqrQMOEgs8GHNRxQPWPV28thHcLklQOU0DP7H7QSCI6vzNKubck1R/Ny/ u2d7EikeUiK4Vr1p/b5IUyCxmm240e5m5NgpoShpZP7ETRej1YEfkroLE8rby0c8sU0d 28dlfIADSD8Sum5LKtydd0QRe9R4IdFM7bfko3NCO21qF9RYGS13FjAaZu9lSwVxDUUX jr1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:subject:cc:to:from:message-id:date; bh=Vicdfna/11CoFCoHdMtwM4hfwu5e0Fr8Clskg0ZquDw=; b=CHoRbd6KMyPIXNI5XFdws+3BaM8/XS/CJgUIg7Lyt8KKi5TNSZH0NGKQmAp1orNHdT OC97eD0mqvCbt/i2bKdrkAtcQW20oUDcxaedWH4G9FPP+tOW10D4PUAKOiUeHuTr3XKD wiwhlbLehoEr3RX5mY/2OQ3+imgZB0FcfkpmzAf1tsvY0KHXZMXKsOgRY1jJEPQfaZ+9 zSjDcXb5u0SnL1D/9xlWxXLx71TZU1IMCwskpvCOzJwUUzfua+rvhSf+I81dIsWzYelk 4Z6TcZSOpajDvOk7JPETG1SxLbLJk2pN48Vg9kT45NFpnr7QmZfo8je+EQDo5V0/jpLU HHzg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n1si15595669ejc.134.2020.08.19.08.38.53; Wed, 19 Aug 2020 08:39:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728415AbgHSPiK (ORCPT + 99 others); Wed, 19 Aug 2020 11:38:10 -0400 Received: from mx2.suse.de ([195.135.220.15]:56362 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726980AbgHSPiK (ORCPT ); Wed, 19 Aug 2020 11:38:10 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DF0F6B5FD; Wed, 19 Aug 2020 15:38:34 +0000 (UTC) Date: Wed, 19 Aug 2020 17:38:08 +0200 Message-ID: From: Takashi Iwai To: Sameer Pujar Cc: , , , , , , , Subject: Re: [PATCH v2] ALSA: hda: avoid reset of sdo_limit In-Reply-To: <1597851130-6765-1-git-send-email-spujar@nvidia.com> References: <1597851130-6765-1-git-send-email-spujar@nvidia.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 19 Aug 2020 17:32:10 +0200, Sameer Pujar wrote: > > By default 'sdo_limit' is initialized with a default value of '8' > as per spec. This is overridden in cases where a different value is > required. However this is getting reset when snd_hdac_bus_init_chip() > is called again, which happens during runtime PM cycle. > > Avoid this reset by moving 'sdo_limit' setup to 'snd_hdac_bus_init()' > function which would be called only once. > > Fixes: 67ae482a59e9 ("ALSA: hda: add member to store ratio for stripe control") > Cc: > Signed-off-by: Sameer Pujar Applied now. Thanks. Takashi