Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 19 Aug 2020 19:18:49 +0200
From:   Jiri Olsa <jolsa@redhat.com>
To:     Nick Clifton <nickc@redhat.com>
Cc:     Mark Wielaard <mark@klomp.org>,
        Jesper Dangaard Brouer <brouer@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>, sdf@google.com,
        andriin@fb.com
Subject: Re: Kernel build error on BTFIDS vmlinux
Message-ID: <20200819171820.GG177896@krava>
References: <20200818105555.51fc6d62@carbon>
 <20200818091404.GB177896@krava>
 <20200818105602.GC177896@krava>
 <20200818134543.GD177896@krava>
 <20200818183318.2c3fe4a2@carbon>
 <c9c4a42ba6b4d36e557a5441e90f7f4961ec3f72.camel@klomp.org>
 <0ddf7bc5-be05-cc06-05d7-2778c53d023b@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <0ddf7bc5-be05-cc06-05d7-2778c53d023b@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Aug 19, 2020 at 04:34:30PM +0100, Nick Clifton wrote:
> Hi Mark,
> 
> > Adding Nick, the binutils maintainer, so we can make sure
> > binutils/elfutils agree on some ELF section compression corner case.
> 
> Thanks for doing this.
> 
> > But it would obviously be better if that wasn't necessary. So I'll try
> > to fix libelf so that if it fixes up the alignment when reading the
> > compressed data, it also does that when writing out the data again. But
> > that would only help for a new version of elfutils.
> > 
> > So it would be nice if binutils ld could also be fixed to write out
> > compressed sections with the correct alignment.
> 
> OK, I will look into doing this.
> 
> By any chance is there a small test case that you are using to check
> this behaviour ?   If so, please may I have a copy for myself ?

so when I take empty object and compile like:

  $ echo 'int main(int argc, char **argv) { return 0; }' | gcc -c -o ex.o -g -gz=zlib -x c -
  $ ld -o ex --compress-debug-sections=zlib ex.o

then there's .debug_info section that shows sh_addralign = 1
after I open the 'ex' obejct with elf_begin and iterate sections

according to Mark that should be 8 (on 64 bits)

when I change it to 8, the elf_update call won't fail for me
on that elf file

thanks,
jirka