Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp625756pxa; Wed, 19 Aug 2020 10:20:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJySYBuBPTLRFENnrILjJj5wRZv6/a1+ni76FUG4zXZHfx3mRFJUGKDj+N8kLsgb/choo65i X-Received: by 2002:aa7:c688:: with SMTP id n8mr26058306edq.345.1597857634361; Wed, 19 Aug 2020 10:20:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597857634; cv=none; d=google.com; s=arc-20160816; b=yDPomceYQzGueKjDHfHuC8I9yS7quKR3ssfbj0LZGlBI1GkB89a4BTdhwOpAzGRmkG HdWxUJq8CDO+SgohqEwDCUT++ksVdSWXs0PEYKf3pQdPBbPzZG1xQE5DlFn0HWGrroAL 4KGs2prZDeroZT0Oa3MeWSPQjVH+r63NRlinIrOWBdKEiIX16wI7XN13/jVmB0JKX5p9 Dogi3ESS+EWXLAp5KmeWX9Xs+ppd75j6XY8Oc4kSbmtouagKW8xG9eL2qmd4Prh/hmHn nX0MpYJohjoYonPC/K/gxWDdphtKvFKMG3XyEHdkH+SdZSHovzA57DsemFGJl15+oT56 tCsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:from:subject:mime-version :message-id:date:dkim-signature; bh=Dql59iVUZIXkMIIjRDDc9cryY7AhHQUktCiD/CtP8/0=; b=UxmTWekXF7WR5D7EjUIXSEhB52Zyaly7m1e9SJkU4xNuEws6gZoizwtUomKfaKR8mP G9vJ86xN6HLx+dVGpkyFZuy01kDhv3O7HJsZTn7/2CJrXdt7Rrd4QqtUINlYq3rT6zEF aUU3ydC4CBI0dgqjjZYi0+k6+xEc5JnNQv/1UPEh0N37crJkEO6ERmUBRIIhQBkn3K6y Tu3pZrfaS4RN6KSFk9LW0PLaXPpBWKx5X6+KU7EZU8bTo1mH60d1tohsHUvII01Tnwso W46Wh5hH7PZuLRdn1kUxUp/+L3xO3bsp5ffxWzu2yQLPJ9Q/iGx9OSydrqoAGzpJT0kw y+9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=SaDIMZS2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z1si16175865eja.41.2020.08.19.10.20.08; Wed, 19 Aug 2020 10:20:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=SaDIMZS2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726741AbgHSRRQ (ORCPT + 99 others); Wed, 19 Aug 2020 13:17:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726681AbgHSRRD (ORCPT ); Wed, 19 Aug 2020 13:17:03 -0400 Received: from mail-qt1-x849.google.com (mail-qt1-x849.google.com [IPv6:2607:f8b0:4864:20::849]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25169C061757 for ; Wed, 19 Aug 2020 10:17:03 -0700 (PDT) Received: by mail-qt1-x849.google.com with SMTP id m13so17111762qth.16 for ; Wed, 19 Aug 2020 10:17:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=Dql59iVUZIXkMIIjRDDc9cryY7AhHQUktCiD/CtP8/0=; b=SaDIMZS2ii5M5hBvS/wwp02CsyM2WPoW3RqEkAntGwgxTc4fVo7Hx68pRr+AOLnMrR UPMgRPyCsKDOPkRe5OKLNS4CI8pXI48uTBAWd5kMgZh9TUGqG+xq+ZKk+ufGc2nxez2v qM5hV+1DJlqIs2S7mkDklsgr1aszYcG+di4pl68Ichj98sn24wIe5MX/OedzuTsLDsk9 SQ9AdgEncaUMdDgNBdwuHSqBZ0tbYSqoCC1GYXp4rK63q/3ls3eFhJ7glbLrIKsZonE1 aE68EPmxKxdI2FE2q2ElWOgDcKvDcg4YidizaXSbXSz+qJabPAnGnjihSoLDAXf3SR+M pWhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=Dql59iVUZIXkMIIjRDDc9cryY7AhHQUktCiD/CtP8/0=; b=ihRTkXqrQQR/1isk+3v+6NPEmq61WpL4PSn1yBU9BHFqoM+cAgbVCRMIZ+Uvv7gBDg LIDibOLIvxixrLWD3Zhaa+1V7FX9s0YsOGRebXl4B01au8ALlsQPsPyzqnOMryZzkKIC pGKEE6+yN/36U0G6Bz0F4yCoOJJQBpXFLKpzDh8SXPS5yPWvnW9c7KkfDDT/bm9T4R/H NQ2EVhGWaBUQuugBtUK1F2vdSXdk/iDMkOPK1oSROsAJb6xBmPZi/e77rqYDTYPi3as6 Mpu2KUrZ4NnywKSfRz3TbxbiAIXuYkketPPiSDeTerJ7UVq/miMBFql5x4PErL+614D/ NRFw== X-Gm-Message-State: AOAM532l93FZcocH05cxI48r++pW27awoPQpQln03QxABaPHV8YKrxIp tHSNhRdTht1vEkXs6+ZkUbrGoz+Z2q9L X-Received: by 2002:a05:6214:11a8:: with SMTP id u8mr25123931qvv.88.1597857420860; Wed, 19 Aug 2020 10:17:00 -0700 (PDT) Date: Wed, 19 Aug 2020 10:16:56 -0700 Message-Id: <20200819171656.2650926-1-furquan@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.28.0.297.g1956fa8f8d-goog Subject: [PATCH] drivers: acpi: apd: Check return value of acpi_dev_get_property From: Furquan Shaikh To: "Rafael J . Wysocki" , Len Brown Cc: adurbin@google.com, akshu.agrawal@amd.com, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Furquan Shaikh Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org `fch_misc_setup()` uses `acpi_dev_get_property()` to read the value of "is-rv" passed in by BIOS in ACPI tables. However, not all BIOSes might pass in this property and hence it is important to first check the return value of `acpi_dev_get_property()` before referencing the object filled by it. Signed-off-by: Furquan Shaikh --- drivers/acpi/acpi_apd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c index 4c348377a39d..806b8ce05624 100644 --- a/drivers/acpi/acpi_apd.c +++ b/drivers/acpi/acpi_apd.c @@ -99,8 +99,8 @@ static int fch_misc_setup(struct apd_private_data *pdata) if (ret < 0) return -ENOENT; - acpi_dev_get_property(adev, "is-rv", ACPI_TYPE_INTEGER, &obj); - clk_data->is_rv = obj->integer.value; + if (!acpi_dev_get_property(adev, "is-rv", ACPI_TYPE_INTEGER, &obj)) + clk_data->is_rv = obj->integer.value; list_for_each_entry(rentry, &resource_list, node) { clk_data->base = devm_ioremap(&adev->dev, rentry->res->start, -- 2.28.0.220.ged08abb693-goog