Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp680472pxa; Wed, 19 Aug 2020 11:51:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzwHdwsWjOjSVw9GSunzblEsrcez/nBNMr1P5SkicZp+SVgsHzZBw+rZ1Hl64fq3awtAjNe X-Received: by 2002:a05:6402:1545:: with SMTP id p5mr25253285edx.388.1597863073633; Wed, 19 Aug 2020 11:51:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597863073; cv=none; d=google.com; s=arc-20160816; b=lrgC3hRa/PdjbV1gZv2nZQAZaVxX/CfejL9wL4tKi/kS7Mm483nIPT6CQcy/3dfR7J RgSsp/6c+I2yAO2dKpmNhJDIMBgHwmi7zDtbRcfcGV/ofPOo2p9zoIV0p20unHjmlxSF olwEv6CcarO0N6pRnrO9ZDpv81CtJzWFhF+ILvMKq5t0TtBbTG+1/Ljkqx7RPWD33tsO YZ7yiavIauIDXYim4Grpm6HKnEpgfT5AclEHyApTaRIQUJRaLbbcej6XfcBq7b3ix1er 4ZmunwFIFDI44bxSrIsEAE/9jwAqTwUEnjPOf6eVusESHFFVDOP5PS04Ok+mczqTYT8N pANA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=lHH3FI1tdZZ9OqCoI613Ez6EcSFNmDwjhfuwAt20rC0=; b=n4mse6pVqYZq6RUvhlBuDRie7QPJdFKdiSXV4QdoOIf49tO5/orwrbm8VeBTTLYu7C /9yKo49U5aMqg9pctxtXzBFY4yJzAOaoi/YEumUAQbv2M1xOS4MRR4t8M6tJ/6Du21O3 6wVkd90lX1aksUSaEcmGm9c1xZ6ddXwIEfuWJtZNHErQUWebMbtlU/jXbkShbrbzhUyj yjzM1y1HkcU8jZjHkidP0iLKDvv+GG2G8UQULQTXda1999DDVO8QpFgTOMhPFraKP+jw FvwopRzxBxMCeRHUkcUsR4IZj+yY9ni2wE6HmM4Nptu8gap9c4cDJyuVUqCGfMK359GA 2MJA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=bV5mILzX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n16si15923101ejj.284.2020.08.19.11.50.50; Wed, 19 Aug 2020 11:51:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=bV5mILzX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726466AbgHSSta (ORCPT + 99 others); Wed, 19 Aug 2020 14:49:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726851AbgHSStH (ORCPT ); Wed, 19 Aug 2020 14:49:07 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1CC36C061345; Wed, 19 Aug 2020 11:49:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=lHH3FI1tdZZ9OqCoI613Ez6EcSFNmDwjhfuwAt20rC0=; b=bV5mILzXSPzh12r4bbJtUTmcyK mmNzxSnEJpTqrEIi28olHtDus3qRFErxyqk3CfVa6Nd4m1tQJRl4IgaCasF0ja9tQDItvvrax3GnS 8UkqbyOfosJ5Q1ytEse0bM/qsh4yxOC1BjxdwFk5+1XwRJS5Mzl9pD0gRQiZFy1b0n+04o76H48LY t3U9M07QP7XUBrtP90Ne92iZXCDHymovYeKar5RSM0+3U/Kkv4PkKew1BHT59pZ55s+bYN1mtFgId s+FXFgC5nX3xOrYqcNbRh6at1KntZUZAJORErYWO3YvaY8XYRm8CaujUuJjZ+cHzX44rlsGU7au8p ZnGIytaQ==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8T8p-0006Te-2y; Wed, 19 Aug 2020 18:48:55 +0000 From: "Matthew Wilcox (Oracle)" To: linux-mm@kvack.org Cc: "Matthew Wilcox (Oracle)" , Andrew Morton , Hugh Dickins , William Kucharski , Jani Nikula , Alexey Dobriyan , Johannes Weiner , Chris Wilson , Matthew Auld , Huang Ying , intel-gfx@lists.freedesktop.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 5/8] i915: Use find_lock_page instead of find_lock_entry Date: Wed, 19 Aug 2020 19:48:47 +0100 Message-Id: <20200819184850.24779-6-willy@infradead.org> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200819184850.24779-1-willy@infradead.org> References: <20200819184850.24779-1-willy@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org i915 does not want to see value entries. Switch it to use find_lock_page() instead, and remove the export of find_lock_entry(). Signed-off-by: Matthew Wilcox (Oracle) --- drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 4 ++-- mm/filemap.c | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c index 38113d3c0138..75e8b71c18b9 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c @@ -258,8 +258,8 @@ shmem_writeback(struct drm_i915_gem_object *obj) for (i = 0; i < obj->base.size >> PAGE_SHIFT; i++) { struct page *page; - page = find_lock_entry(mapping, i); - if (!page || xa_is_value(page)) + page = find_lock_page(mapping, i); + if (!page) continue; if (!page_mapped(page) && clear_page_dirty_for_io(page)) { diff --git a/mm/filemap.c b/mm/filemap.c index 1aaea26556cc..36067cf7f8c5 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -1628,7 +1628,6 @@ struct page *find_lock_entry(struct address_space *mapping, pgoff_t offset) } return page; } -EXPORT_SYMBOL(find_lock_entry); /** * pagecache_get_page - Find and get a reference to a page. -- 2.28.0