Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp729488pxa;
        Wed, 19 Aug 2020 13:14:43 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJyDqB/hTYHWagvJ9u8LGpJ63KySIY5ghqx17chAcsLkw3/YtnOJFdVi3xmIOWIlD/uDWDLY
X-Received: by 2002:a05:6402:1427:: with SMTP id c7mr27274557edx.245.1597868083451;
        Wed, 19 Aug 2020 13:14:43 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1597868083; cv=none;
        d=google.com; s=arc-20160816;
        b=nzLUUGuoxA85ZSUz3JzpektCWxfX44++tR8NljoC7O6C/y6OEzR0SORpciozCRiAXw
         PRpJ6sRF53a1keHlcTFG6agaCM7kj1VcEBfEIo13AKgVf3Z4Yo4Ewqy3HbyArG2ERvcb
         KtflvatLntosLPKC55ABweVDWdO2hKjdx4+eIu2qwRFf/dwDaha4GdsglLqWnp2Njdz/
         bq1QtYBlIbX3ldWYxZIlOzQqmEEd7kFK17nBTT+tHgOmN3RDiagM+0uOijvd77m32Nuc
         oCBKfsgGt2rXk1uosFN3KOld4G8kBTlhCwiSFIVYfGR8YfNmjmOUILVFJhZo49h7YeO8
         xOtg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=gisIwwdNQqwwFojZ3O84aFWOL4HiKzNr6Omq6OzAIhw=;
        b=uaf1uL4gs2P1cTEWgga21OjqmNt7MoSMy7WEy5eXYNtfpGJmf1+9pfFPoOMaB6iEt/
         69pfJL2WNO5/DAfS3rD79VNDozMVAB7vtXqZr2hUJY52jZuNxaCeZFlgur+Ym1++oPkv
         N8UIm6BWN7E0i9phUr5htUvbMes3R/UxL6SuFHOgU5uDyeswWlLc25xe1brkOAtCiJsq
         t8KvvyH4MoNakOizXfUZhU3RXq7pGo8OUafSM6JsjFjpczTS4Uh6nUWyRNk0S2wx8eqw
         GT+hUm2AauZWPioUvaIfM7XPwtjgzm0q61lGqvqoKXU1fb86Tzx0S3uBYR4rMxR/r3X7
         LTiw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=fJn0qJu+;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id r3si16071718eja.548.2020.08.19.13.14.18;
        Wed, 19 Aug 2020 13:14:43 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=fJn0qJu+;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727108AbgHSUMO (ORCPT <rfc822;rao.subba.venkata@gmail.com>
        + 99 others); Wed, 19 Aug 2020 16:12:14 -0400
Received: from mail.kernel.org ([198.145.29.99]:33938 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1727103AbgHSUML (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 19 Aug 2020 16:12:11 -0400
Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id 60F7C2078D;
        Wed, 19 Aug 2020 20:12:11 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1597867931;
        bh=wCiqSWw7+dELXrP0i9ukDIaG6ZmIp6AkyvOOF38BHhE=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=fJn0qJu+brZMju6egaLEThAXIfIpqw+HI2cdO85N+QLjA8pTMhMzxD+EcD0kyLtCF
         CzUbgTsJGGXpdpSWLFyvrGIsHJvPrAx/Skq5fVj259IuWkDmkyBYkE9qdfHUvHuutN
         2YoHbMEPsjDuhAONpVpfC2oytz3MIYXF3Ie/oXyY=
Date:   Wed, 19 Aug 2020 13:12:10 -0700
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Wei Yang <richard.weiyang@linux.alibaba.com>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mm/mmap: rename __vma_unlink_common() to
 __vma_unlink()
Message-Id: <20200819131210.dc5c045a626d1bf4475214d1@linux-foundation.org>
In-Reply-To: <20200809232057.23477-1-richard.weiyang@linux.alibaba.com>
References: <20200809232057.23477-1-richard.weiyang@linux.alibaba.com>
X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 10 Aug 2020 07:20:56 +0800 Wei Yang <richard.weiyang@linux.alibaba.com> wrote:

> __vma_unlink_common() and __vma_unlink() are counterparts. Since there is

I assume you meant "__vma_link()" here?

> not function named __vma_unlink(), let's rename it to __vma_unlink() to
> make the code more self-explain and easy for audience to understand.
> 
> Otherwise we may expect there are several variants of vma_unlink and
> __vma_unlink_common() is used by them.