Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp737482pxa; Wed, 19 Aug 2020 13:30:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxLZkN1hHwxBxtn8MAluHzi5kDwg5BMoHtit40ahaJhgZngfEqi0PN7H/623PxIjSf9KUkT X-Received: by 2002:a05:6402:297:: with SMTP id l23mr26646377edv.145.1597869017916; Wed, 19 Aug 2020 13:30:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597869017; cv=none; d=google.com; s=arc-20160816; b=a8tIECrX9k/Z6eQEBWGpkTnPgV1YqwlQtpAff86TmvEfeuGNwyTQyKPfQvCljzZB/T YgE38bFaaUwPUpy2UWn4x8LXtuHr9m7ZobhXBq1zBHdv3wpfiDhPq9Zgx/QfDUOp2IQb GfTq2oWQ3bEFgmAs+SgKmdIi/nWXyN+Q6+pLiKSjeKSKf0GY58w7CE74BJ4uYxFQ7jWR z+eFJN9OV1ZcdDcnVHX6OO+tFXUI4ZcsdMGaOC592Q+MRC2M26Yam0u8tN9NC5tV7v1Z 8CHOpbOCmqqODpYm26hM6bpaiiNNguraBpCLibxksKhoGWy50sYtBrtlApqCyGXNsHKU s/ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :subject:references:in-reply-to:message-id:cc:to:from:date :dkim-signature; bh=7ddsMD+oAMSxDYFcv0EBBJa/q2PE7PVd6TOOolF+FKE=; b=Ehpo0McdTVm2mUMkBVVnx5Hu33VAYFYEY6OfVpAWJvYgwBIDTpCSvqXQbU6QABP6Q4 9KigHee5DsGp3la2mp7jFJvUK+iNNtXUSFXbCiTCh1k0hL5idX+VY9S1Y2pELl2aEj3v V7pWX2RsNFCh7ddlapwIQ3xnQqcSQsIzEhimUI3hH1qsE3E3HGnbsMdNbwfHn2CZ9yWh 6j2FwCCAZzGmbve1oYHG6bU5U7DZt21VcYApYlQeQTi5seo1oRtEtDs9jmIq7tixlb2Z sy5VnGP4aCfVhvUzevXEYblPYG9GOYT2LoneKeIltxvz1o4aqieP0onA9xrqeUbuNdae 5oqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Znkt7jfx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d20si16455251ejz.445.2020.08.19.13.29.54; Wed, 19 Aug 2020 13:30:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Znkt7jfx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726973AbgHSU3U (ORCPT + 99 others); Wed, 19 Aug 2020 16:29:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725275AbgHSU3S (ORCPT ); Wed, 19 Aug 2020 16:29:18 -0400 Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9648EC061757; Wed, 19 Aug 2020 13:29:18 -0700 (PDT) Received: by mail-pl1-x634.google.com with SMTP id g15so7485807plj.6; Wed, 19 Aug 2020 13:29:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:message-id:in-reply-to:references:subject :mime-version:content-transfer-encoding; bh=7ddsMD+oAMSxDYFcv0EBBJa/q2PE7PVd6TOOolF+FKE=; b=Znkt7jfxdz3lB3BgaB3TtINMjI5C95O4H8XyNOEg6TmIVs2wUD7Uptc5ZIYwzne0oG Brh1AoSmTN0DzkRJjcdCbctKzS2eh2ztgfAuOy8oqmOPySJRzc7oh0CRftcG9wfG/KJ/ y2ZvkBoIMYOAonlT3SJkTCzf3tOswPANpBjWWlFkRylTB2Cja82Gy+DZVcK7yiueche6 ynuHWyR156rq5YHNYLNnisia2COfW5Vx1ZRwMW66lJeJJuEPWi4kpZJDTtmNMycvnpPc EW37PibyYowFRntjNKe4WLuy/u2qAKAmSU7QfZgUEFKOUDPc8JgIEpl0Mfe01BMo1AbR pEpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:message-id:in-reply-to :references:subject:mime-version:content-transfer-encoding; bh=7ddsMD+oAMSxDYFcv0EBBJa/q2PE7PVd6TOOolF+FKE=; b=m+wJtUtbLJvsHy5b01XH/vFRoLfWelasHTcIG5goknbbQv2ejCmpTc6ewXLZp+dJiO 2INE/Y5jIj64r5NAh5TpEC9zDF8xkqm3raQO2JK+Ts3dCfMNyaY9sQ6ETuZCToSNHS/J fDEBbW3HWKdPMbDHpYQoSH/YpPpyduJF+F9e1tlgj8/DhfbIDsVe+oX8iF/1/GjrE8U3 M5xa/ZH6xUMBktL4kUIJRHhUtG+DJ2bjCF59Dl96CyvMdbbZ2//2KfokP97P01SbrQW7 0xQojYuWIXPNriYkD3SkYrkaCfbKw+8ZsPJROSnAF3b3QaFWtQI9He8+esG369AgS5dB VQ7w== X-Gm-Message-State: AOAM532d0p4Rr3KEHbdzhiHMDFl3gSdNPUZBeZS33JgQOGvDSzotoFA2 k5Vj/djfAim9SA7CpjfPtj4= X-Received: by 2002:a17:90a:f290:: with SMTP id fs16mr5372763pjb.35.1597868956644; Wed, 19 Aug 2020 13:29:16 -0700 (PDT) Received: from localhost ([184.63.162.180]) by smtp.gmail.com with ESMTPSA id a15sm54495pfo.185.2020.08.19.13.29.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2020 13:29:15 -0700 (PDT) Date: Wed, 19 Aug 2020 13:29:07 -0700 From: John Fastabend To: Lorenz Bauer , jakub@cloudflare.com, john.fastabend@gmail.com, Alexei Starovoitov , Daniel Borkmann , Lorenz Bauer , "David S. Miller" , Jakub Kicinski Cc: kernel-team@cloudflare.com, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <5f3d8b93e7aa9_2c9b2adeefb585bcd1@john-XPS-13-9370.notmuch> In-Reply-To: <20200819092436.58232-4-lmb@cloudflare.com> References: <20200819092436.58232-1-lmb@cloudflare.com> <20200819092436.58232-4-lmb@cloudflare.com> Subject: RE: [PATCH bpf-next 3/6] bpf: sockmap: call sock_map_update_elem directly Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Lorenz Bauer wrote: > Don't go via map->ops to call sock_map_update_elem, since we know > what function to call in bpf_map_update_value. Since > check_map_func_compatibility doesn't allow calling > BPF_FUNC_map_update_elem from BPF context, we can remove > ops->map_update_elem and rename the function to > sock_map_update_elem_sys. > > Signed-off-by: Lorenz Bauer > --- Acked-by: John Fastabend