Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp762578pxa; Wed, 19 Aug 2020 14:19:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxXPlXbl71Nh2InAkBUe38ado4QiDqg3QYfAlS+k6sjmrhKexvKn2nIngnK+vAh8VAolwdj X-Received: by 2002:a50:cc92:: with SMTP id q18mr17924298edi.159.1597871970221; Wed, 19 Aug 2020 14:19:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597871970; cv=none; d=google.com; s=arc-20160816; b=unjuJV1iPtyHEh+4eOva2gJ4Ud58toNC2UG4vbwBicmnW9g+SpK6V2FFnZs3BTWGYM r1oehv9V4pxQU1CqNGgdb98E80LqZgXggZWhS4ty0WKkBZ4mMvu8zJfhNuf25Lb/IUau 0raH+4xfz0xA4xfTs0b4AiEPkSXCx4WEdiY9YLkTGBp/MRTHQeoPACgdMQmVcZmJwtjI q2Su5ZXfMXS4Mb01MELlGs8LLnDTAoSSLrL/b5B4KMBU0hKhLTTMOwDsG4B90P7qLgdd qAbT6sW28vGsYBV5eXmFUOFpbQTM3nGj8a5gpJFr8Zah7YOq0RTJB9s98MVGg7C8zDRh yb/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=xg5qNlyjDK4H9Bsa0SxjBV5q9nAUK79Dx84r0nHodF4=; b=scaRpv13bfTatQ+vKox3WR+aOX9Pr3abzPRzdGAqG9gmGfbNLcVSm0q3lKXyggSTal g1pz8TNJ2oD+lK0ivq6P5qOJttQh1QmAvNdKSY9FTU6tv9dlluhq6Sk6IKwnRP3KSymL +zEmgdDvrDXWBlQ424J9ZDJXraFW01tZsKqHXMG/xPyYYEz5ttmBb+YK6EObkEgeExgU tdrBfwUinY9zeNo27HlI9rES0ZAPxSoYQkMSaf58737UNtN39fIrOiVUVDHe32kkt5WF o4IE43vCK2H54hXOkcrXKwiHjtlPhsf+dSiBgf4H2F3jb3wJvkDdoG1buqtQxZY3lyRz RmKQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=DkyFs4wx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lz26si16148122ejb.40.2020.08.19.14.19.05; Wed, 19 Aug 2020 14:19:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=DkyFs4wx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726974AbgHSVQt (ORCPT + 99 others); Wed, 19 Aug 2020 17:16:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726646AbgHSVQq (ORCPT ); Wed, 19 Aug 2020 17:16:46 -0400 Received: from mail-lf1-x143.google.com (mail-lf1-x143.google.com [IPv6:2a00:1450:4864:20::143]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1014CC061757; Wed, 19 Aug 2020 14:16:45 -0700 (PDT) Received: by mail-lf1-x143.google.com with SMTP id b30so12806701lfj.12; Wed, 19 Aug 2020 14:16:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=xg5qNlyjDK4H9Bsa0SxjBV5q9nAUK79Dx84r0nHodF4=; b=DkyFs4wxFzSvzO4KjO65oA/ou2mXckXka5g3fyo0dbU9Vr/+/dDyHO26PGm+ml2ntA GBNoxFHh+7q4p0nEysDmUqICgy1Q7zm/3QuTWU9ehTGesdI0KXYSWGtzprLuJnmtYmpB DjZ9EoGtZtYpThn8JxUG/fLDCNWQcayQp+oHSIwKjFuEaDAIPp8+loSp6wOLwrEVS4zc kKVNHg0dd/TngzHF19ba3/r4vH982TrZSppzaRLw1xPpo9f7XHsxZ0TmrQRijsptKBAu Za9nHvu+NGKsW2ueisNClpaQVTlQIaGb+XdoiygCwYItOje/uT65x7TMmkLGve0982a7 yMMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=xg5qNlyjDK4H9Bsa0SxjBV5q9nAUK79Dx84r0nHodF4=; b=QBhsvokYhtUdHMwAwjdR+Gi1Apc1rVE3qIcfMiGxF+OHQdsShwd9qttWuvRqRb+LUm NHnNTd20isYaw6+5YTXwKVDFoAnplQbyJz9xy3dJux2A95iR8w5Dy6JoNA0s+wTQp12L 1oVkO3ll4QzSDbHjU6EkqedECZXytKqZ8sc2onhfVPP8JQzfdQhzAJQ2xAY7NDN6rIXB 9qG8dgNpvjgDsX6ua1hRE+HzBa0SfN3rmrGHRFJtBuoptrErylQ4TWdMcpHW/w4ZDwI7 t4a1/ZWJLWFLehIkoxe/5bbNA7iRtD2Ra/ZZnXiY3BdFegER1mp2NCanhRe1uo6EeOnH 899g== X-Gm-Message-State: AOAM533E8jE83PKmzTBorVRWPfMdQb8eijBKLw2Pc23GzV4ODobcSz8W NSAzSCBb7vxQAaWwN+Q2pLoerbmNmZvakkoEXFQ= X-Received: by 2002:a19:cc3:: with SMTP id 186mr27554lfm.134.1597871802486; Wed, 19 Aug 2020 14:16:42 -0700 (PDT) MIME-Version: 1.0 References: <20200819020027.4072288-1-zenczykowski@gmail.com> In-Reply-To: <20200819020027.4072288-1-zenczykowski@gmail.com> From: Alexei Starovoitov Date: Wed, 19 Aug 2020 14:16:30 -0700 Message-ID: Subject: Re: [PATCH bpf-next] net-veth: add type safety to veth_xdp_to_ptr() and veth_ptr_to_xdp() To: =?UTF-8?Q?Maciej_=C5=BBenczykowski?= Cc: =?UTF-8?Q?Maciej_=C5=BBenczykowski?= , Alexei Starovoitov , Daniel Borkmann , Linux Network Development Mailing List , Linux Kernel Mailing List , BPF Mailing List , "David S . Miller" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 18, 2020 at 7:00 PM Maciej =C5=BBenczykowski wrote: > > From: Maciej =C5=BBenczykowski > > This reduces likelihood of incorrect use. > > Test: builds I kept this in the commit log though it's a pointless comment. Please reconsider for the future. If you want to mention how you've tested it, please say so after "---" line= . > Signed-off-by: Maciej =C5=BBenczykowski Applied. Thanks.