Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp774409pxa; Wed, 19 Aug 2020 14:44:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzKH5B2eRB9XuwIZ1MqKRX+zqd3covso/hAZsnEPopa9gCiXKawoUJj0uXHC4p20b4ryRS+ X-Received: by 2002:a05:6402:b23:: with SMTP id bo3mr21243edb.333.1597873444049; Wed, 19 Aug 2020 14:44:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597873444; cv=none; d=google.com; s=arc-20160816; b=I7pintsZP7WxoUqM0vP5tcWcUh8Cj/Ile9DkU1Hv+3BeMS72nIvAfg8VhDyT5do1rp Z/OkLuSxp8S4WL+Rn9iOzgZVIA2FWirhqYtLtmxtSGuKAr90Wy/zpgCFBZGvohyaZwZx iQCrT18noYGU4q8wkfO5opeKf8oq8OkC93nDSvBvG20qeLHDUcYyxYKBNIu10VvqHC2D 8Jv9GF4kKyxcG4W97NgKQpfd3B8TWll6QkmKgmpfGETp+yKIy2xitc1xWbkjyXa18f8Y nVI5Fmta8PLnc9hBdIxGfrc7kTyRnS88UjtciUknAaZOvPwfLPh2tuh2QPyuBIDsRRM/ eNrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=U5KVprMAGs5Rms1L1yrBX4Xta0RS355JO96Z5Mns1Lc=; b=FG2RP7vjqSOxqPxF8Rrhvd2BzFU/zDsPATnPYSQ3nxA97DWNC8zgbB+u0ydykIgogH GbVw51rZBbYO6kDeDFZprVUgJ4xA5Q/BzVbyxDZjz0lXq+bJXHTAtbaoIZruUKH4gh4g slOeXtVtOjKzBj6IxDorDCsY5eh4r1oRO8uX32e/yXvaJ6ZevuFllePVfqZhaL2o3d8p nEmfd0t0q7ZNBheRrGllkFay+OMppxsw9YEcCyvY+fjnZzY06g1xaMqQsz23TwhCqgH3 gTBTjQoZ8tTi5mdVpFvhSR8GGazSd4VCfkI0OkUGXDk6yrNl51XoeNI8i5AUpmhhcVvw N32Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=AEuC7bxp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f14si115934edt.316.2020.08.19.14.43.39; Wed, 19 Aug 2020 14:44:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=AEuC7bxp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726967AbgHSVm4 (ORCPT + 99 others); Wed, 19 Aug 2020 17:42:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:35488 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726466AbgHSVmv (ORCPT ); Wed, 19 Aug 2020 17:42:51 -0400 Received: from dhcp-10-100-145-180.wdl.wdc.com (unknown [199.255.45.60]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 97A952067C; Wed, 19 Aug 2020 21:42:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597873371; bh=pinhTPqoqxH2L+AXIWvBK5hfDh/tddhsdx7m0Akw4vk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AEuC7bxpfxQb5NULJo7ameLMi/uRkCDBFssg2Hh9Ph/nCuIth358SMN0YUN207pZC CRLee7W5b83xTup6n9ZwhSREsQek5bjjgoIWNMn/nhs9P5SPlaV9RW+TpuGWaKXKW0 khJL2F8teLty+rZYfHxwczK5xb/U1f7+B0pkSIQs= Date: Wed, 19 Aug 2020 14:42:48 -0700 From: Keith Busch To: David Fugate Cc: Christoph Hellwig , Kanchan Joshi , "Damien.LeMoal@wdc.com" , "axboe@kernel.dk" , "sagi@grimberg.me" , "linux-nvme@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "johannes.thumshirn@wdc.com" , Nitesh Shetty , SelvaKumar S , Javier Gonzalez Subject: Re: [PATCH 2/2] nvme: add emulation for zone-append Message-ID: <20200819214248.GA26769@dhcp-10-100-145-180.wdl.wdc.com> References: <20200818052936.10995-1-joshi.k@samsung.com> <20200818052936.10995-3-joshi.k@samsung.com> <20200818071249.GB2544@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 19, 2020 at 01:11:58PM -0600, David Fugate wrote: > Intel does not support making *optional* NVMe spec features *required* > by the NVMe driver. This is inaccurate. As another example, the spec optionally allows a zone size to be a power of 2, but linux requires a power of 2 if you want to use it with this driver. > Provided there's no glaring technical issues There are many. Some may be improved through a serious review process, but the mess it makes out of the fast path is measurably harmful to devices that don't subscribe to this. That issue is not so easily remedied. Since this patch is a copy of the scsi implementation, the reasonable thing is take this fight to the generic block layer for a common solution. We're not taking this in the nvme driver.