Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] ALSA: usb-audio: Add prevent wakeup from s3 state trig by
 Lenovo ThinkCentre TI024Gen3 USB-audio
To:     Kai-Heng Feng <kai.heng.feng@canonical.com>,
        Takashi Iwai <tiwai@suse.de>
Cc:     penghao <penghao@uniontech.com>,
        Mark Pearson <mpearson@lenovo.com>,
        Jaroslav Kysela <perex@perex.cz>, alexander@tsoy.me,
        dan.carpenter@oracle.com, crwulff@gmail.com, gustavoars@kernel.org,
        "moderated list:SOUND" <alsa-devel@alsa-project.org>,
        linux-kernel@vger.kernel.org
References: <20200819115757.23168-1-penghao@uniontech.com>
 <s5h364ih7vd.wl-tiwai@suse.de>
 <74B3A9AD-8B49-4E5F-BE9F-BF88865304B7@canonical.com>
From:   Hui Wang <hui.wang@canonical.com>
Message-ID: <fdd0d029-d7b5-ff43-5f84-9d73de867bca@canonical.com>
Date:   Thu, 20 Aug 2020 09:42:41 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <74B3A9AD-8B49-4E5F-BE9F-BF88865304B7@canonical.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 2020/8/20 上午2:10, Kai-Heng Feng wrote:
>
>> On Aug 20, 2020, at 01:18, Takashi Iwai <tiwai@suse.de> wrote:
>>
>> [ Adding a few more relevant people to Cc. ]
>>
>> On Wed, 19 Aug 2020 13:57:57 +0200,
>> penghao wrote:
>>> TI024Gen3 USB-audio is controlled by TI024Gen3,when TI024Gens
>>> enter sleep mode, USB-audio will disconnect from USB bus port,
>>> wakup form s3 state
>>>
>>> Signed-off-by: penghao <penghao@uniontech.com>
>>> ---
>>> sound/usb/card.c | 6 ++++++
>>> 1 file changed, 6 insertions(+)
>>>
>>> diff --git a/sound/usb/card.c b/sound/usb/card.c
>>> index 696e788c5d31..6bdbb34009b3 100644
>>> --- a/sound/usb/card.c
>>> +++ b/sound/usb/card.c
>>> @@ -658,6 +658,12 @@ static int usb_audio_probe(struct usb_interface *intf,
>>> 	}
>>>
>>> 	dev_set_drvdata(&dev->dev, chip);
>>> +	/*
>>> +	 *ALSA: usb-audio: Add prevent wakeup from s3 state trig by Lenovo
>>> +	 *ThinkCentre TI024Gen3 usb-audio
>>> +	 */
>>> +	if ((usb_id->idVendor == 0x17ef) && (usb_id->idProduct == 0xa012))
>>> +		device_set_wakeup_enable(＆dev->dev, 0);
>> Here it's no proper ASCII letter, and this must be broken.
>> Please check the actual patch before submitting.
>>
>> In anyway, before going further, I'd like to hear from other people
>> whether this is really mandatory and appropriate.  And whether it's
>> specific to that device, too (not other Lenovo devices?)
> If USB remote wakeup on this device is broken then we need to fix it in USB core instead of USB audio.
> We need USB and xHCI logs to understand the real problem here, the commit message doesn't contain enough information.
>
> Kai-Heng

I checked with our QA, we didn't enable this machine before.  And I 
tried 2 different usb audio cards, neither of them has wakeup 
capability. it is weird that your usb sound card (maybe a built-in usb 
sound card) has wakeup capability.

You could file a bug to 
https://bugs.launchpad.net/ubuntu/+source/linux/+filebug, then upload 
the needed logs,  Kai-Heng and I will help investigate this issue.

Thanks,

Hui.

>>
>> thanks,
>>
>> Takashi