Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp894497pxa; Wed, 19 Aug 2020 18:56:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwQtOx4u7ev5O+LDL29aaj7k9sNVdX1O5wgraTp/V0Rz1CD5u/i9MHV7pdo2WXfIi1yHkvD X-Received: by 2002:a05:6402:b67:: with SMTP id cb7mr810917edb.216.1597888568133; Wed, 19 Aug 2020 18:56:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597888568; cv=none; d=google.com; s=arc-20160816; b=oBPL5Xs+LT3Ml+3ZrRl1l4BqFcdcObjVibu7U5jz/KLOC8Nle6C9dmBswvJ36CzR3m MwRraMEFZzQkU9h9VOCNHwd8Bjx5qdJIpcYlpXCXMX8sLcC/6UZrz7SJgFg0SL5W6O24 XjIKwqH8trVOJfdJV4gUAofVavz7LG3s2JlAp2tw15qs3nlmNt9dVECDmDLeTsI2ReLt P8VaYOilJAQ/N1FiNuLbV5+5wG4tB+LfEwEptsyUnvgJxm0FhXAawCZg+XNasxG5j8Wo pj7YT66lF2EikE6ApVOD2tjC+WECwo+fAGnHMHIMo54exfRdUuztk8Oge/RT6qntZliT QvZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=95vglf64Vq/O/1I3tuau6vIlhCDn5C32IVrNU3ul3Rs=; b=n32flmusNII91uZ2oAoJbsmWHusyHkb2Orhtf2VzdXsMKrsrsqWxjTvMYcXKKFHYQV +U+3/WLOSeb42gZx2u/LeQk1SMPJeaTkoKwVXWTnQaZSQwTx7PKXa2eKkxGbLdFgotIo pFYYwDr0FzbzBkWbH1vmSX/b4cvS8yGcjBNEhsiw2PbBSMM5sjIQJmytMY1GOZZCbNQE IWmYW4HyuI3SbUH2m+ZvWr0l58q85NJx+vFLjZYFBh4erZ2vrgo9N8irEnviYemlldH9 MPBSlpzVm7XPjvziMFMFnwE3l7gVsU3EwsBP1pFnDKYJzylpeDcAlHJ9d8iC5sakEE6w 1NXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=qN6Z+7A+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id rl26si298501ejb.568.2020.08.19.18.55.44; Wed, 19 Aug 2020 18:56:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=qN6Z+7A+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726707AbgHTBxU (ORCPT + 99 others); Wed, 19 Aug 2020 21:53:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726435AbgHTBxU (ORCPT ); Wed, 19 Aug 2020 21:53:20 -0400 Received: from mail-oi1-x243.google.com (mail-oi1-x243.google.com [IPv6:2607:f8b0:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 167B5C061757 for ; Wed, 19 Aug 2020 18:53:20 -0700 (PDT) Received: by mail-oi1-x243.google.com with SMTP id b22so702827oic.8 for ; Wed, 19 Aug 2020 18:53:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=95vglf64Vq/O/1I3tuau6vIlhCDn5C32IVrNU3ul3Rs=; b=qN6Z+7A+Lbqvnw/Y3D/+sTqCsXSHZNFofii9Sv7TAGxZTT4nzYugE0dv9WTjhy2Ach +bhLMdQLy50q5omf+RBQ7ttymA4E2wnLpegiXS6qkD0jOwznXKg6Uhanq75UdpRrSZ66 OM5P1bIQaiyp+S+D5AsSGvF1RLWV0iyMOLjSPXcJJ5W4N8NQvko9tn0H8YwE5EYRDUYh 5bltJlJRMt+4kkGWuQZZd1tFeESB9OagrslJBjw8flAHuV7E+cA49b+f4QZ+Ys+qKJzf yt9Du/YLUFEDZvS0GWAkjnup+G5NgTLBJdMf5qwxqk3iQE1wPRWq6d8GTvx0sLSy1P6D aTtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=95vglf64Vq/O/1I3tuau6vIlhCDn5C32IVrNU3ul3Rs=; b=GoqCUJunZQMUOWgp6fVizbAUg3HTDF2XwhwFi5rd1f5UG3+RZXOyccudBAnFiQvzdk QUOrOkyh/qeBsvWHW71aWcvNn7F1t4m0n7wkFiDh8YKeos0gwFqwPfLKxEag5Stw4FXU OUqckCbxzyptWB5Y5CcDJPlPSA/VR/YJeSoHNgUI5JESvmTT1gzJR9ouLE4Q31mqIhmh FoRBuTpnQMzz96c05+mOFbt24CexIEjHYIZ01xYOcG0oxylxgKUFpUWBbloXCTdZgU2W E1lmxpYjZmUVCGggeDgN+czU9Z43B0hvC2vM0TlfI92WYJfgpAe8twdBHS7uYBfQw3bk Jthg== X-Gm-Message-State: AOAM530b3kXGtU7RaIPTZ6P0Wa+kpQS7TYsMCgBAcvo0dfPrKYQNFTjw DrscGGRJA0rem3RFgc2Eb0ee7uzRjlkjat4pp0+25g== X-Received: by 2002:aca:1014:: with SMTP id 20mr557719oiq.169.1597888399467; Wed, 19 Aug 2020 18:53:19 -0700 (PDT) MIME-Version: 1.0 References: <9fa944021373ec5b82c2c1e118c15d9effe7f964.1597833138.git.mchehab+huawei@kernel.org> In-Reply-To: <9fa944021373ec5b82c2c1e118c15d9effe7f964.1597833138.git.mchehab+huawei@kernel.org> From: John Stultz Date: Wed, 19 Aug 2020 18:53:06 -0700 Message-ID: Subject: Re: [PATCH 25/49] staging: hikey9xx/gpu: do some code cleanups To: Mauro Carvalho Chehab Cc: Greg Kroah-Hartman , linuxarm@huawei.com, mauro.chehab@huawei.com, Manivannan Sadhasivam , Daniel Vetter , dri-devel , Xiubin Zhang , Liwei Cai , Chen Feng , driverdevel , lkml Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 19, 2020 at 4:46 AM Mauro Carvalho Chehab wrote: > @@ -376,7 +355,7 @@ static int kirin_drm_platform_resume(struct platform_device *pdev) > } > > static const struct of_device_id kirin_drm_dt_ids[] = { > - { .compatible = "hisilicon,hi3660-dpe", > + { .compatible = "hisilicon,kirin960-dpe", One issue, elsewhere in your patch stack you still refer to the hisilicon,hi3660-dpe compatible string. This should probably be consistent one way or the other. thanks -john