Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] uacce: Use kobj_to_dev() instead of container_of()
To:     Tian Tao <tiantao6@hisilicon.com>, wangzhou1@hisilicon.com,
        arnd@arndb.de, gregkh@linuxfoundation.org,
        linux-accelerators@lists.ozlabs.org, linux-kernel@vger.kernel.org
Cc:     linuxarm@huawei.com
References: <1597889792-53139-1-git-send-email-tiantao6@hisilicon.com>
From:   Zhangfei Gao <zhangfei.gao@linaro.org>
Message-ID: <9f2bbd04-79fa-95e6-50ec-e0dd270f6c61@linaro.org>
Date:   Thu, 20 Aug 2020 10:52:50 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <1597889792-53139-1-git-send-email-tiantao6@hisilicon.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 2020/8/20 上午10:16, Tian Tao wrote:
> Use kobj_to_dev() instead of container_of()
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> Reviewed-by: Zhou Wang <wangzhou1@hisilicon.com>
Acked-by: Zhangfei Gao <zhangfei.gao@linaro.org>

Thanks
> ---
>   drivers/misc/uacce/uacce.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/uacce/uacce.c b/drivers/misc/uacce/uacce.c
> index a5b8dab..a9da7b1 100644
> --- a/drivers/misc/uacce/uacce.c
> +++ b/drivers/misc/uacce/uacce.c
> @@ -370,7 +370,7 @@ static struct attribute *uacce_dev_attrs[] = {
>   static umode_t uacce_dev_is_visible(struct kobject *kobj,
>   				    struct attribute *attr, int n)
>   {
> -	struct device *dev = container_of(kobj, struct device, kobj);
> +	struct device *dev = kobj_to_dev(kobj);
>   	struct uacce_device *uacce = to_uacce_device(dev);
>   
>   	if (((attr == &dev_attr_region_mmio_size.attr) &&