Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp980886pxa; Wed, 19 Aug 2020 22:21:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzFhd06+BDNPtQ6bVRpG7HEOaQy7dlvppZH4c2I32FufCag4iFq8ZbWdmixjr6+aAaIdjMg X-Received: by 2002:a05:6402:7d5:: with SMTP id u21mr1334286edy.341.1597900867246; Wed, 19 Aug 2020 22:21:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597900867; cv=none; d=google.com; s=arc-20160816; b=E/kdZQggSQhCJrnAg0TcVzXUyv4aZA8mvNqH8puw/DjHJsHrB2fYBctBGBNpi2QI4j JK5ok41vo9QsvRPO10YHrWLRtfLZi8wWppb5BHN2USmoAtDvPKKk2v0XQnTRyKSxni6z tXC+PnB0dIqXhZkY4q/p1f+gPZ3dojPVPsVdBCOcmxbwzuobT6+cXnPGFrZcdmGmx6AI NLSRCU/cHmQmR/BnbMwAgp9ieSQjJKbwWVr3oQ/9IyLFvGtYgOhuHiniZXlH48cUZ9su VWJLTh0fZmWCcFaqyFTZ7AJINHUg71hLbmlHYBXhPjdKb6vB/24qnpNPayHJjZWZAVSa FFfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=2c9En6b1OOr/sfqxYC+PutZCGTlIrSsliZYua1sfQVA=; b=SG/1lsEB96Zs39hys6Lemi8fZDsTjNCdNZ/LmUAmjcT9J3OMWt4xuLCSPwhgpkIPjl yejUeX1WqgOa6RBq4+qOPIZ3vusmMdal7x8GdKZODCsdil3N7K1rqywC+icn3aVaGa4q oUt+CT0tW/zLJryYqkNSbIrE6i0B47gJnHNbqqcFQpW3xmaw1KyPQ3MCcTrVB2gVYGyr l4xpv+9975rc3fXmHADXcIkVlN6CDamzWw8L8NdH7mgSb1l0gLyfDg4fvPi73gVEllxO yxFT+tEnrF9kYyKagS/zESAVPfcC5/mO9dO5QYiXK8mwKAHSXS1BEAOG8pzoa/Ak/aKa ehVA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id mj19si565974ejb.291.2020.08.19.22.20.42; Wed, 19 Aug 2020 22:21:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726215AbgHTFUK (ORCPT + 99 others); Thu, 20 Aug 2020 01:20:10 -0400 Received: from verein.lst.de ([213.95.11.211]:40569 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725780AbgHTFUJ (ORCPT ); Thu, 20 Aug 2020 01:20:09 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 4B4A168BEB; Thu, 20 Aug 2020 07:20:04 +0200 (CEST) Date: Thu, 20 Aug 2020 07:20:04 +0200 From: Christoph Hellwig To: Tomasz Figa Cc: alsa-devel@alsa-project.org, linux-ia64@vger.kernel.org, Linux Doc Mailing List , nouveau@lists.freedesktop.org, linux-nvme@lists.infradead.org, linux-mips@vger.kernel.org, "James E.J. Bottomley" , linux-mm@kvack.org, Christoph Hellwig , linux-samsung-soc , Joonyoung Shim , linux-scsi@vger.kernel.org, Kyungmin Park , Ben Skeggs , Matt Porter , Linux Media Mailing List , Tom Lendacky , Pawel Osciak , Mauro Carvalho Chehab , "list@263.net:IOMMU DRIVERS , Joerg Roedel , " , Thomas Bogendoerfer , linux-parisc@vger.kernel.org, netdev@vger.kernel.org, Seung-Woo Kim , Linux Kernel Mailing List , "list@263.net:IOMMU DRIVERS , Joerg Roedel , " Subject: Re: [PATCH 05/28] media/v4l2: remove V4L2-FLAG-MEMORY-NON-CONSISTENT Message-ID: <20200820052004.GA5305@lst.de> References: <20200819065555.1802761-1-hch@lst.de> <20200819065555.1802761-6-hch@lst.de> <20200819135454.GA17098@lst.de> <20200820044347.GA4533@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200820044347.GA4533@lst.de> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 20, 2020 at 06:43:47AM +0200, Christoph Hellwig wrote: > On Wed, Aug 19, 2020 at 03:57:53PM +0200, Tomasz Figa wrote: > > > > Could you explain what makes you think it's unused? It's a feature of > > > > the UAPI generally supported by the videobuf2 framework and relied on > > > > by Chromium OS to get any kind of reasonable performance when > > > > accessing V4L2 buffers in the userspace. > > > > > > Because it doesn't do anything except on PARISC and non-coherent MIPS, > > > so by definition it isn't used by any of these media drivers. > > > > It's still an UAPI feature, so we can't simply remove the flag, it > > must stay there as a no-op, until the problem is resolved. > > Ok, I'll switch to just ignoring it for the next version. So I took a deeper look. I don't really think it qualifies as a UAPI in our traditional sense. For one it only appeared in 5.9-rc1, so we can trivially expedite the patch into 5.9-rc and not actually make it show up in any released kernel version. And even as of the current Linus' tree the only user is a test driver. So I really think the best way to go ahead is to just revert it ASAP as the design wasn't thought out at all.