Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: lUjythBlDJ9wJ6dwr4pVOI0sYozguO2us9AOWRu9YJoItKJkqtneKs11xnXPOqVgVIcoeqt8kB
 gnckW1rpzRwWsCGMIsyG6NLCDn5P8YliR4OrgPkNYjf5o/ZlawkgjkoO0yeoZurZHRbW0WgkHe
 beL3Ne1/7eIHLoP/b82jPY40rPCGUhVImi1yx9hYV9Jn6DgUWfB+4lMlMoXHhKS5IBAjLoGq0q
 joZwB0yPC07g9cfyjXXhagXQ4OwHrFjHaq3b0Ib9kV1q3hQQte5cT862GDi1hJGhpy0g6OLPjf
 rtA=
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Can Guo <cang@codeaurora.org>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "nguyenb@codeaurora.org" <nguyenb@codeaurora.org>,
        "hongwus@codeaurora.org" <hongwus@codeaurora.org>,
        "rnayak@codeaurora.org" <rnayak@codeaurora.org>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "kernel-team@android.com" <kernel-team@android.com>,
        "saravanak@google.com" <saravanak@google.com>,
        "salyzyn@google.com" <salyzyn@google.com>
CC:     Alim Akhtar <alim.akhtar@samsung.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Stanley Chu <stanley.chu@mediatek.com>,
        Bean Huo <beanhuo@micron.com>,
        Bart Van Assche <bvanassche@acm.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] scsi: ufs: Remove an unpaired
 ufshcd_scsi_unblock_requests() in err_handler()
Thread-Topic: [PATCH] scsi: ufs: Remove an unpaired
 ufshcd_scsi_unblock_requests() in err_handler()
Thread-Index: AQHWdR9eLwo1QgZADUa7GqtKpJda3qlAinkg
Date:   Thu, 20 Aug 2020 06:24:16 +0000
Message-ID: <BY5PR04MB67057E61AB1866ADD61A3748FC5A0@BY5PR04MB6705.namprd04.prod.outlook.com>
References: <1597728047-39936-1-git-send-email-cang@codeaurora.org>
In-Reply-To: <1597728047-39936-1-git-send-email-cang@codeaurora.org>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 82f19f05-c0ba-4f3b-15f5-08d844d1aa71
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Aug 2020 06:24:16.9962
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: D3tkxkUjzhF0ulcXDk87nTB1qIHwzQRhzqgyBcZYkiiqjQYB0BnNloyO/vKR5VTZoCWqRnQcNdavPbbsizDURg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR04MB6882
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

=20
>=20
> Commit 5586dd8ea250a ("scsi: ufs: Fix a race condition between error
> handler and runtime PM ops") moves the ufshcd_scsi_block_requests() insid=
e
> err_handler(), but forgets to remove the ufshcd_scsi_unblock_requests() i=
n
> the early return path. Correct the coding mistake.

"fixes" tag please, for those who don't read the commit message.
Thanks,
Avri
>=20
> Signed-off-by: Can Guo <cang@codeaurora.org>
>=20
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 2b55c2e..b8441ad 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -5670,7 +5670,6 @@ static void ufshcd_err_handler(struct work_struct
> *work)
>                 if (hba->ufshcd_state !=3D UFSHCD_STATE_ERROR)
>                         hba->ufshcd_state =3D UFSHCD_STATE_OPERATIONAL;
>                 spin_unlock_irqrestore(hba->host->host_lock, flags);
> -               ufshcd_scsi_unblock_requests(hba);
>                 return;
>         }
>         ufshcd_set_eh_in_progress(hba);
> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linu=
x
> Foundation Collaborative Project.