Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp1043641pxa; Thu, 20 Aug 2020 00:31:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy2IXaVa9z8uvlcrCDbkqqXyL6iEkb63EBSEkqmZw/HSJ1+dPP0M78irDTg6XOiHbBwimFO X-Received: by 2002:aa7:c983:: with SMTP id c3mr1592797edt.383.1597908695973; Thu, 20 Aug 2020 00:31:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597908695; cv=none; d=google.com; s=arc-20160816; b=feRc7Gie5CXEFyxMrUmJ/lOCO1ML/Z4vvNzSRMjWsd/kTU5Nk9ZLHobEonHWXKDoEa NXTzrEv7Lma2wAnHtdurf57rzcymXKsB0bT7Fih7DLkrtpxZ4yuDL1tWm3/woKTRH/Eb qTlXnEqvRYlU6ns5pleRJXVdoztEX1FhkTi5Wbe8388glcKbS3IaeURF7Dvlw+e0jGro PMLXh1rQ1PdV6tbXCWGredAb3pXhWGkfUhuNpwKGuDRNhSjI2siEe44XZzblXrN5dj// qFwPweZTb5YvVMtsq/cgES3LSo02QtrGn7IP5iKAY/wcRPIfyJi/cOzS3z1bqmlMAyf8 LKuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:ironport-sdr:ironport-sdr; bh=X42skv8s4u6yw1lKcq/xQxwI4uB5SbqVCqDE/7mhNMw=; b=RTUEWerqtal2eg5CVZUkT2WeA8Cma2IzsGY0zPuJ4aLqScMSXfm/eErkrFQ3KEI/+/ RZ684Ngz2Fc17nJIckkfkKt53biEBynCSmyVaapKMM525xjedO9nUYvxjqnAboEodll2 zmXJcO2EL6wu4NH6j4ogBKOy4LW4gj0hrEX/4DInwlmrqCnZSwdQLGB25k+xM7MIGQ48 WSdrqPPtYzOvaFBuVWgUTKU1Ccx2ddbEN11MrENUAcxVBOq4xf5uJiVdXTdefvGW7l16 Wr5IvF+R3kKZ9Dw2m2qnM9hE/xRguLnC2BwNbdBCnzEeVcxDFWgC4fHAmpNZsd5We07s hCpw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bv7si712254ejb.523.2020.08.20.00.31.11; Thu, 20 Aug 2020 00:31:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726666AbgHTHaP (ORCPT + 99 others); Thu, 20 Aug 2020 03:30:15 -0400 Received: from mga03.intel.com ([134.134.136.65]:26636 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725820AbgHTHaO (ORCPT ); Thu, 20 Aug 2020 03:30:14 -0400 IronPort-SDR: 8bBDYl41AyOx7NDwWl206ipj+SdbHB5Qhpi5KFLKwK5o04ELkZXK2noc/khjdoEsg7IIxDTmVg FbF0k9dXR1pA== X-IronPort-AV: E=McAfee;i="6000,8403,9718"; a="155225865" X-IronPort-AV: E=Sophos;i="5.76,332,1592895600"; d="scan'208";a="155225865" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Aug 2020 00:30:13 -0700 IronPort-SDR: V0bNGK+unpSW220Mv1SyOPGZuGAnuaTlwOCopnjwvfUbDavGw+l76ufZosNkFRFVu19fHTMzAO M3q/6zpbWVFg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,332,1592895600"; d="scan'208";a="497513364" Received: from linux.intel.com ([10.54.29.200]) by fmsmga006.fm.intel.com with ESMTP; 20 Aug 2020 00:30:13 -0700 Received: from [10.249.73.140] (ekotax-MOBL.gar.corp.intel.com [10.249.73.140]) by linux.intel.com (Postfix) with ESMTP id 0595558045A; Thu, 20 Aug 2020 00:30:11 -0700 (PDT) Subject: Re: [PATCH] dt-bindings: PCI: intel,lgm-pcie: Fix matching on all snps,dw-pcie instances To: Rob Herring , devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Bjorn Helgaas , linux-pci@vger.kernel.org References: <20200819222002.2059917-1-robh@kernel.org> From: Dilip Kota Message-ID: Date: Thu, 20 Aug 2020 15:30:10 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200819222002.2059917-1-robh@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/20/2020 6:20 AM, Rob Herring wrote: > The intel,lgm-pcie binding is matching on all snps,dw-pcie instances > which is wrong. Add a custom 'select' entry to fix this. > > Fixes: e54ea45a4955 ("dt-bindings: PCI: intel: Add YAML schemas for the PCIe RC controller") > Cc: Bjorn Helgaas > Cc: Dilip Kota > Cc: linux-pci@vger.kernel.org > Signed-off-by: Rob Herring > --- > I'll take this via the DT tree. > > Rob > > Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml b/Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml > index 64b2c64ca806..a1e2be737eec 100644 > --- a/Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml > @@ -9,6 +9,14 @@ title: PCIe RC controller on Intel Gateway SoCs > maintainers: > - Dilip Kota > > +select: > + properties: > + compatible: > + contains: > + const: intel,lgm-pcie > + required: > + - compatible > + > properties: > compatible: > items: Reviewed-by: Dilip Kota Regards, Dilip