Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp1096955pxa; Thu, 20 Aug 2020 02:19:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJycac5PK+x7JSaeONWVjddf2ok1RQ9vpZ1S5nYInitz98MpurMeJ2kG80NQuItpfMrALdPq X-Received: by 2002:a17:906:48c8:: with SMTP id d8mr1064755ejt.331.1597915154653; Thu, 20 Aug 2020 02:19:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597915154; cv=none; d=google.com; s=arc-20160816; b=aHK5pKqRDV2B7g6iJU56AwDNdeWFh0svpOfToU+oH2TiyR5CrDWmaQ3lytXTrqRvMu BXECmBP0vQMnvX0j80bvwXuCYOszi6S2lN/vz8dhNkUfSSjaayWF34Qp4ujecyi+ZWvE nxOd2wN1E1vJAg/Vfq57cuOiusfkX60/GYKmdHfCPiTiFmFOwIzSOZXZUiiSTjIGqZpW JfMV+JDwz+eECnyaE/+G82Qa0GYG98FZZxI8TcGxXNExwtV4x3iZsQ97uadB1R7F0qvY Xdg2rSL1QxVib9KmJv00svgaAKGMmSqa0jzJlzzzQi6hZA3WUibY1q2kaExlquZkK7bI raCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=fteDDvG0lAwDUKEWhtTwY7pAZbLV3gpQe5mpBnV9oBQ=; b=Qvs+oDUZy0kmkiRiY16Wh+N++BU4nxBGSv1hsE+9XNhLesCD2PHnWgbaNoS9tQC4H1 wfAfpEyPyaMc1ks+qxFjwlaHWQGaAyRfl2aulRglBc1FJvdmaWFZuNJLfo5OTaqszieT 6WL5+tN9F0VzGWIxoR3IQmSY3r63OnBkVMDz/XJFFnNcvvcQJ57322Il4k7DUaTKtxw+ zvJD9CNkTEZTv5tPua4zEcEmuVK/v+QvkIiX7hMZvsLPxomrDxGTC8XlUe2CN0uRptVU HcI6nX8oYiO1T8DL7KIwrpJK6TEMxK9402u68UQ+wK3w84jHnI1Zs+7qhaeOABdqtjXz azZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=etECKGb7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jx1si832685ejb.520.2020.08.20.02.18.50; Thu, 20 Aug 2020 02:19:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=etECKGb7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727098AbgHTJPU (ORCPT + 99 others); Thu, 20 Aug 2020 05:15:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726964AbgHTJOT (ORCPT ); Thu, 20 Aug 2020 05:14:19 -0400 Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A00FC061386 for ; Thu, 20 Aug 2020 02:14:19 -0700 (PDT) Received: by mail-pl1-x643.google.com with SMTP id f5so746679plr.9 for ; Thu, 20 Aug 2020 02:14:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=fteDDvG0lAwDUKEWhtTwY7pAZbLV3gpQe5mpBnV9oBQ=; b=etECKGb7kbalwLBAoTrpPMX3ZW67xpLBEkM9fyGckTzOZQc9DC0gGPbOm/C35mHFUm 0SUiqk7LBNR7opllyTOPxqomZuk4ireVz+J8Ga3shwzH4euw0XT3cv65tWQwR+27OhjE LtA3zSxIdezdqeHB0ICydm6cDZ3QF3utr7BKE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=fteDDvG0lAwDUKEWhtTwY7pAZbLV3gpQe5mpBnV9oBQ=; b=Gpz7dZXmS4j9Kd220NEG3IA28gFPpubVOOaf1k6s91HQW76Q4lYFF2bn68fZc7lUzR waNOwTEZO6fqxK7Zzt3/JznJiFNQdAX3L+HjmPoRGuJ5mnWIgk+G4pYJTdIXifGaWkzF qxQfOYsgbwlwNs6ATxC7acoPKyjRnwHJME6Kmi6JqjFg24+GacIMwyfJgc/yfRHWBNsU iax1jCDfwZpMuEt7sC9ZkTcwEjKoB1tY23DP2zaij1HyRJ8IfnZbtkkbMjAtguCqn2NQ j/215FDZtuF//kHldWVehb3nec7OQ7Lle+Aij1sNQBYagRfTTehZCI96iu3ucJgC08Ny /Kqw== X-Gm-Message-State: AOAM530eq234S/ce+VgfU/sRBasbKJlAEUvcJYnf0MX0bYdnfVd6i8aS 6b3gITO3Lzg+QAZ221Irangfwg== X-Received: by 2002:a17:90a:7488:: with SMTP id p8mr1884427pjk.158.1597914858908; Thu, 20 Aug 2020 02:14:18 -0700 (PDT) Received: from drinkcat2.tpe.corp.google.com ([2401:fa00:1:b:7220:84ff:fe09:41dc]) by smtp.gmail.com with ESMTPSA id o15sm1954448pfu.167.2020.08.20.02.14.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Aug 2020 02:14:17 -0700 (PDT) From: Nicolas Boichat To: Mauro Carvalho Chehab , Steven Rostedt , Greg Kroah-Hartman Cc: Nicolas Boichat , Andy Gross , Bjorn Andersson , Todor Tomov , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v4 1/3, RESEND] media: camss: vfe: Use trace_printk for debugging only Date: Thu, 20 Aug 2020 17:14:10 +0800 Message-Id: <20200820170951.v4.1.Ia54fe801f246a0b0aee36fb1f3bfb0922a8842b0@changeid> X-Mailer: git-send-email 2.28.0.220.ged08abb693-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org trace_printk should not be used in production code. Since tracing interrupts is presumably latency sensitive, pr_dbg is not appropriate, so guard the call with a preprocessor symbol that can be defined for debugging purpose. Signed-off-by: Nicolas Boichat --- (resending this patch as part of the whole series, since we need a new patch 3/3 now). drivers/media/platform/qcom/camss/camss-vfe-4-1.c | 2 ++ drivers/media/platform/qcom/camss/camss-vfe-4-7.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/drivers/media/platform/qcom/camss/camss-vfe-4-1.c b/drivers/media/platform/qcom/camss/camss-vfe-4-1.c index 174a36be6f5d866..0c57171fae4f9e9 100644 --- a/drivers/media/platform/qcom/camss/camss-vfe-4-1.c +++ b/drivers/media/platform/qcom/camss/camss-vfe-4-1.c @@ -936,8 +936,10 @@ static irqreturn_t vfe_isr(int irq, void *dev) vfe->ops->isr_read(vfe, &value0, &value1); +#ifdef CAMSS_VFE_TRACE_IRQ trace_printk("VFE: status0 = 0x%08x, status1 = 0x%08x\n", value0, value1); +#endif if (value0 & VFE_0_IRQ_STATUS_0_RESET_ACK) vfe->isr_ops.reset_ack(vfe); diff --git a/drivers/media/platform/qcom/camss/camss-vfe-4-7.c b/drivers/media/platform/qcom/camss/camss-vfe-4-7.c index 0dca8bf9281e774..307675925e5c779 100644 --- a/drivers/media/platform/qcom/camss/camss-vfe-4-7.c +++ b/drivers/media/platform/qcom/camss/camss-vfe-4-7.c @@ -1058,8 +1058,10 @@ static irqreturn_t vfe_isr(int irq, void *dev) vfe->ops->isr_read(vfe, &value0, &value1); +#ifdef CAMSS_VFE_TRACE_IRQ trace_printk("VFE: status0 = 0x%08x, status1 = 0x%08x\n", value0, value1); +#endif if (value0 & VFE_0_IRQ_STATUS_0_RESET_ACK) vfe->isr_ops.reset_ack(vfe); -- 2.28.0.220.ged08abb693-goog