Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp1101252pxa; Thu, 20 Aug 2020 02:28:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw9nSFaaWZ9yoi9Tbib9bWHxYA8z9iHRbLG4ee3XjrQL1+TQJsmGzLMqYuXx3EGvw3oOcd8 X-Received: by 2002:a17:906:970a:: with SMTP id k10mr2302333ejx.189.1597915725440; Thu, 20 Aug 2020 02:28:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597915725; cv=none; d=google.com; s=arc-20160816; b=l2q5pl+wiFt80rfcj+E2AXJ2FyKFCSYsGS5pkND9XfFJMa685mE1qsvUe3TLqmOQs1 IdiZM3NPT5c7hXCgGAtFDr8phi5b7W5hGFtWLjeNtc5PFs0vzcettHW5f6Owjro3vWV9 uXRferlDFw9gxQYOhXYgKwM2ry3cUi8bWJZtmFo/Ez/SfVV1tZ1ml7WXYYOjIRn85biF aQIKGp8bXxyRObqrNo8rNPc6v5nNj/5siV83XFeMnMK1pwAPcTkAlz2Iel3wxaJVxFY4 IUkpbv/DH2uMuTkuVwBFnszEzg3fy1AuABG9i813xReiqMnOvy6ScgQW+GP24R7yhasp KVrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=qM/HZiAe+OHp3noJvKokzAWCI5Ymkp3SZkXZuMlQjck=; b=lj1kNM/C6kn+EcW6wca7BSlAohs41r1PPJ4Ky8q4zjpYz/KsrWOSQXXe3n+6cqlNh1 Ub/hdVNCTEqb6Xqz9/xajt6qpyUtL+DTbNWBTLk4bhjQvxHBvEi+jbmR5LDGRojfBh8V SKnMKDiY7YrnApdpRQsAFQ/854q6pMSMziymPW7m3EpbL5/qYsgXh9K7/9aIBKIO6m2K 2ijtOFl07XoQZdi+jfJ5+Nsi3uPD+E3Q5l6Al3PPEr3AGNxGGziE5PXi/4Yq91C02tzN /pnjWpeN4jgV+NNdX1LU/Ien+tIhDPmJZh0+w+Mvr0bnpm4ds04Q0I7QJV4SGQ2sXGi0 lgwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vim5y6Io; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z17si820885ejo.565.2020.08.20.02.28.21; Thu, 20 Aug 2020 02:28:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vim5y6Io; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727030AbgHTJYx (ORCPT + 99 others); Thu, 20 Aug 2020 05:24:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:60762 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726990AbgHTJYj (ORCPT ); Thu, 20 Aug 2020 05:24:39 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8DFF422CE3; Thu, 20 Aug 2020 09:24:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597915479; bh=G4UhC8H1peBQskffRrkzMTllBPjEVDEGDpsAV47tnfw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vim5y6IoNsWUtxm/pijrqaEb0jUUX6quTjm01peiRkTzWB3XV9xmm8lNlGsUvIWFh gjm4i28gO0Oz2bN3U7jEL3aD5sXFwNSRSJytMxTQAniCSjMIzFevwAcY4vkAR1dqpu gHbWakovBor9+otWwF9lpElMepYIjF5008KwLQUA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Steve French , "Paulo Alcantara (SUSE)" , Pavel Shilovsky Subject: [PATCH 5.8 003/232] SMB3: Fix mkdir when idsfromsid configured on mount Date: Thu, 20 Aug 2020 11:17:34 +0200 Message-Id: <20200820091612.869750725@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200820091612.692383444@linuxfoundation.org> References: <20200820091612.692383444@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Steve French commit c8c412f976124d85b8ded85c6ac3f760c12b63a3 upstream. mkdir uses a compounded create operation which was not setting the security descriptor on create of a directory. Fix so mkdir now sets the mode and owner info properly when idsfromsid and modefromsid are configured on the mount. Signed-off-by: Steve French CC: Stable # v5.8 Reviewed-by: Paulo Alcantara (SUSE) Reviewed-by: Pavel Shilovsky Signed-off-by: Greg Kroah-Hartman --- fs/cifs/smb2inode.c | 1 + 1 file changed, 1 insertion(+) --- a/fs/cifs/smb2inode.c +++ b/fs/cifs/smb2inode.c @@ -115,6 +115,7 @@ smb2_compound_op(const unsigned int xid, vars->oparms.fid = &fid; vars->oparms.reconnect = false; vars->oparms.mode = mode; + vars->oparms.cifs_sb = cifs_sb; rqst[num_rqst].rq_iov = &vars->open_iov[0]; rqst[num_rqst].rq_nvec = SMB2_CREATE_IOV_SIZE;