Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp1103304pxa; Thu, 20 Aug 2020 02:32:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzpxX19xTjz8e0CrO2miKDtA8bBDGkbIavtWhxoIHWUgLqeqaSfgBzExcipePHlgIaf7K7N X-Received: by 2002:a17:906:a88b:: with SMTP id ha11mr2288009ejb.545.1597915956080; Thu, 20 Aug 2020 02:32:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597915956; cv=none; d=google.com; s=arc-20160816; b=B1u56StjWRbnDQl3hI4+Tc+y5YRm6Nj3fnODx/o0g56Zmj5ENiBwK2JbeoEbkAZOkG svUazuwxnGPq3dideNy1+aDMKsXDKu0o0gxQl5cInC/k9Ef2Lg/2cP067jFZCNsjkXXQ JE00/mmvVj7/Lo7JWah+9Wu81INtonYvRzoQZaCIOI+Wvfp2WRlP8hik+BGdcF0vdinv PyKxUPVi5uib524rElY+0oKxRnb7WvYFUISgWbFzPVrKT+pzU2e5gHiwpbQ95jO/Bzwq 00LMCvGb5VfVYcit5eBdABkjAhOovLp/jfbUW+CWbvTJJ0fBBvCD+gqriK0U8iVLOmMk 4PXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=frdmjwp6y3II1GbcWCuzonLigK/YfOvkLsOrtU28gm0=; b=ybV20AWKfNsnE1sAbqjFWaAwythKtf4Egy6Cbq38NRLGOIBG0DZi2Iu+kXpE50Qqhr tTe5F+OV6F/0WIZK2n494Isw2K5WSAvIYusBDCnTVex/YWPMwciBMk3qBpxJ6zkVeeB+ UPzhp7rwzJ3iHrOWlrUbh7JUnL6Ekn+uelEZXbsG1Pv2EYixPfkU7SbKVOalSxDrKkSr AntJwR0/izceJWPNIECw6mtEhXR/Ss75F0hss0cnwSbK0pWAJvSZXjhnHwhJFKUEbeIj gL/Moo5911XM3RDTpX25t7rbU/VMuMMwvccrGjryxLuU/RhNo8/z4r6ZGlZ+NBTydSgR Ai9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=r1sR0U+S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c67si1042850edf.421.2020.08.20.02.32.12; Thu, 20 Aug 2020 02:32:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=r1sR0U+S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728072AbgHTJ3c (ORCPT + 99 others); Thu, 20 Aug 2020 05:29:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:37100 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727078AbgHTJ2b (ORCPT ); Thu, 20 Aug 2020 05:28:31 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 465272224D; Thu, 20 Aug 2020 09:28:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597915709; bh=nfgCGoTCSYZV/HWOTSgdJtuoqoTvoAl+MUxVncVuKnI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=r1sR0U+SAw6c3cwwJzU0Xg9y1AObaZXw/+1R8wTDceHcupRTcEjDrengM+7nGFsro GOXo5Wuo32sRzc7SDpTxtdM2wM/flHZwZr12qqRLrQVlvG1z8fGDlTp5NPNxiLkS0T qjw33ROsUju4Ub9PE1WQBdtsFxsqfF3I53Ueh3rM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Evan Green , Sibi Sankar , Bjorn Andersson Subject: [PATCH 5.8 108/232] remoteproc: qcom: q6v5: Update running state before requesting stop Date: Thu, 20 Aug 2020 11:19:19 +0200 Message-Id: <20200820091618.051284155@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200820091612.692383444@linuxfoundation.org> References: <20200820091612.692383444@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sibi Sankar commit 5b7be880074c73540948f8fc597e0407b98fabfa upstream. Sometimes the stop triggers a watchdog rather than a stop-ack. Update the running state to false on requesting stop to skip the watchdog instead. Error Logs: $ echo stop > /sys/class/remoteproc/remoteproc0/state ipa 1e40000.ipa: received modem stopping event remoteproc-modem: watchdog received: sys_m_smsm_mpss.c:291:APPS force stop qcom-q6v5-mss 4080000.remoteproc-modem: port failed halt ipa 1e40000.ipa: received modem offline event remoteproc0: stopped remote processor 4080000.remoteproc-modem Reviewed-by: Evan Green Fixes: 3b415c8fb263 ("remoteproc: q6v5: Extract common resource handling") Cc: stable@vger.kernel.org Signed-off-by: Sibi Sankar Link: https://lore.kernel.org/r/20200602163257.26978-1-sibis@codeaurora.org Signed-off-by: Bjorn Andersson Signed-off-by: Greg Kroah-Hartman --- drivers/remoteproc/qcom_q6v5.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/remoteproc/qcom_q6v5.c +++ b/drivers/remoteproc/qcom_q6v5.c @@ -153,6 +153,8 @@ int qcom_q6v5_request_stop(struct qcom_q { int ret; + q6v5->running = false; + qcom_smem_state_update_bits(q6v5->state, BIT(q6v5->stop_bit), BIT(q6v5->stop_bit));