Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 20 Aug 2020 12:20:51 +0200 (CEST)
From:   Julia Lawall <julia.lawall@inria.fr>
To:     Stephen Smalley <stephen.smalley.work@gmail.com>
cc:     kbuild-all@lists.01.org, selinux@vger.kernel.org,
        Paul Moore <paul@paul-moore.com>,
        Eric Paris <eparis@parisplace.org>,
        Ondrej Mosnacek <omosnace@redhat.com>,
        Tom Rix <trix@redhat.com>,
        Ethan Edwards <ethancarteredwards@gmail.com>,
        Wei Yongjun <weiyongjun1@huawei.com>, selinux@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH] selinux: fix memdup.cocci warnings
Message-ID: <alpine.DEB.2.22.394.2008201218350.2524@hadrien>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: kernel test robot <lkp@intel.com>

Use kmemdup rather than duplicating its implementation

Generated by: scripts/coccinelle/api/memdup.cocci

Fixes: c7c556f1e81b ("selinux: refactor changing booleans")
CC: Stephen Smalley <stephen.smalley.work@gmail.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>

---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/selinux.git next
head:   37ea433c66070fcef09c6d118492c36299eb72ba
commit: c7c556f1e81bb9e09656ed6650d0c44c84b7c016 [4/6] selinux: refactor changing booleans
:::::: branch date: 4 hours ago
:::::: commit date: 2 days ago

 conditional.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

--- a/security/selinux/ss/conditional.c
+++ b/security/selinux/ss/conditional.c
@@ -686,12 +686,11 @@ static int cond_bools_copy(struct hashta
 {
 	struct cond_bool_datum *datum;

-	datum = kmalloc(sizeof(struct cond_bool_datum), GFP_KERNEL);
+	datum = kmemdup(orig->datum, sizeof(struct cond_bool_datum),
+			GFP_KERNEL);
 	if (!datum)
 		return -ENOMEM;

-	memcpy(datum, orig->datum, sizeof(struct cond_bool_datum));
-
 	new->key = orig->key; /* No need to copy, never modified */
 	new->datum = datum;
 	return 0;