Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932348AbWETVEx (ORCPT ); Sat, 20 May 2006 17:04:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932346AbWETVEw (ORCPT ); Sat, 20 May 2006 17:04:52 -0400 Received: from smtp.osdl.org ([65.172.181.4]:21733 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S932329AbWETVEw (ORCPT ); Sat, 20 May 2006 17:04:52 -0400 Date: Sat, 20 May 2006 14:04:34 -0700 From: Andrew Morton To: Paul P Komkoff Jr Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: Was change to ip_push_pending_frames intended to break udp (more specifically, WCCP?) Message-Id: <20060520140434.2139c31b.akpm@osdl.org> In-Reply-To: <20060520191153.GV3776@stingr.net> References: <20060520191153.GV3776@stingr.net> X-Mailer: Sylpheed version 1.0.4 (GTK+ 1.2.10; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1181 Lines: 28 Paul P Komkoff Jr wrote: > > Hello! > > I have a userspace application, which talks WCCP2 with cisco routers. > It sends and receives UDP packets on port 2048. After I've updated my > server to 2.6.16, it stopped working. > > Examining logs and packet dumps of previous (2.6.15 kernel) vs. > current, I found, that cisco will not understand packets generated by > 2.6.16. The only difference in that packets was IP id field, which was > increasing (1, 2, ...) with old kernel, and always 0 with 2.6.16. > > Looking thru the changelog, I've found a suspect. It was this commit: > http://kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=1a55d57b107c3e06935763905dc0fb235214569d > > Reverting this patch fixes my problems - the router understands > packets again. > > I took a look through the code and ip_select_ident codepath but still > don't understand why it setting id to 0. (netdev cc added) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/