Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <CALvZod5ZRUHO+=Bvwj4aEKNL0Egwea2dZKuYDKhkvvUyezbgdg@mail.gmail.com>
 <20200820071647.25280-1-sjpark@amazon.com>
In-Reply-To: <20200820071647.25280-1-sjpark@amazon.com>
From:   Shakeel Butt <shakeelb@google.com>
Date:   Thu, 20 Aug 2020 06:26:49 -0700
Message-ID: <CALvZod4i5f5RcsHao3DWddoDgHsO+vvGPZaAJUWkURZ2fqH9LA@mail.gmail.com>
Subject: Re: [RFC v7 06/10] mm/damon: Implement callbacks for physical memory monitoring
To:     SeongJae Park <sjpark@amazon.com>
Cc:     SeongJae Park <sjpark@amazon.de>, Jonathan.Cameron@huawei.com,
        Andrea Arcangeli <aarcange@redhat.com>, acme@kernel.org,
        alexander.shishkin@linux.intel.com, amit@kernel.org,
        benh@kernel.crashing.org, brendan.d.gregg@gmail.com,
        Brendan Higgins <brendanhiggins@google.com>,
        Qian Cai <cai@lca.pw>,
        Colin Ian King <colin.king@canonical.com>,
        Jonathan Corbet <corbet@lwn.net>,
        David Hildenbrand <david@redhat.com>, dwmw@amazon.com,
        "Du, Fan" <fan.du@intel.com>, foersleo@amazon.de,
        Greg Thelen <gthelen@google.com>,
        Ian Rogers <irogers@google.com>, jolsa@redhat.com,
        "Kirill A. Shutemov" <kirill@shutemov.name>, mark.rutland@arm.com,
        Mel Gorman <mgorman@suse.de>, Minchan Kim <minchan@kernel.org>,
        Ingo Molnar <mingo@redhat.com>, namhyung@kernel.org,
        "Peter Zijlstra (Intel)" <peterz@infradead.org>,
        Randy Dunlap <rdunlap@infradead.org>,
        Rik van Riel <riel@surriel.com>,
        David Rientjes <rientjes@google.com>,
        Steven Rostedt <rostedt@goodmis.org>, rppt@kernel.org,
        sblbir@amazon.com, shuah@kernel.org, sj38.park@gmail.com,
        snu@amazon.de, Vlastimil Babka <vbabka@suse.cz>,
        Vladimir Davydov <vdavydov.dev@gmail.com>,
        Yang Shi <yang.shi@linux.alibaba.com>,
        Huang Ying <ying.huang@intel.com>, zgf574564920@gmail.com,
        linux-damon@amazon.com, Linux MM <linux-mm@kvack.org>,
        linux-doc@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Aug 20, 2020 at 12:17 AM SeongJae Park <sjpark@amazon.com> wrote:
>
> On Wed, 19 Aug 2020 17:26:15 -0700 Shakeel Butt <shakeelb@google.com> wrote:
>
> > On Tue, Aug 18, 2020 at 12:27 AM SeongJae Park <sjpark@amazon.com> wrote:
> > >
> > > From: SeongJae Park <sjpark@amazon.de>
> > >
> > > This commit implements the four callbacks (->init_target_regions,
> > > ->update_target_regions, ->prepare_access_check, and ->check_accesses)
> > > for the basic access monitoring of the physical memory address space.
> > > By setting the callback pointers to point those, users can easily
> > > monitor the accesses to the physical memory.
> > >
> > > Internally, it uses the PTE Accessed bit, as similar to that of the
> > > virtual memory support.  Also, it supports only user memory pages, as
> > > idle page tracking also does, for the same reason.  If the monitoring
> > > target physical memory address range contains non-user memory pages,
> > > access check of the pages will do nothing but simply treat the pages as
> > > not accessed.
> > >
> > > Users who want to use other access check primitives and/or monitor the
> > > non-user memory regions could implement and use their own callbacks.
> > >
> > > Signed-off-by: SeongJae Park <sjpark@amazon.de>
> > [snip]
> > > +static void damon_phys_mkold(unsigned long paddr)
> > > +{
> > > +       struct page *page = damon_phys_get_page(PHYS_PFN(paddr));
> > > +       struct rmap_walk_control rwc = {
> > > +               .rmap_one = damon_page_mkold,
> > > +               .anon_lock = page_lock_anon_vma_read,
> > > +       };
> > > +       bool need_lock;
> > > +
> > > +       if (!page)
> > > +               return;
> > > +
> > > +       if (!page_mapped(page) || !page_rmapping(page))
> > > +               return;
> >
> > I don't think you want to skip the unmapped pages. The point of
> > physical address space monitoring was to include the monitoring of
> > unmapped pages, so, skipping them invalidates the underlying
> > motivation.
>
> I think my answer to your other mail[1] could be an answer to this.  Let me
> quote some from it:
>
> ```
> Technically speaking, this patchset introduces an implementation of DAMON's low
> level primitives for physical address space of LRU-listed pages.  In other
> words, it is not designed for cgroups case.  Also, please note that this
> patchset is only RFC, because it aims to only show the future plan of DAMON and
> get opinions about the concept before being serious.  It will be serious only
> after the DAMON patchset is merged.  Maybe I didn' made this point clear in the
> CV, sorry.  I will state this clearly in the next spin.
> ```

The unmapped pages are also LRU pages. Let's forget about the cgroups
support for a moment, the only reason to use DAMON's physical address
space monitoring is also to track the accesses of unmapped pages
otherwise virtual address space monitoring already does the monitoring
for mapped pages.

>
> ```
> So, DAMON is a framework rather than a tool.  Though it comes with basic
> applications using DAMON as a framework (e.g., the virtual address space low
> primitives implementation, DAMON debugfs interface, and the DAMON user space
> tool) that could be useful in simple use cases, you need to code your
> application on it if your use cases are out of the simple cases.  I will also
> develop more of such applications for more use-cases, but it will be only after
> the framework is complete enough to be merged in the mainline.
> ```
>
> Of course, we could prioritize the cgroup support if strongly required, though
> I still prefer focusing on the framework itself for now.
>
> [1] https://lore.kernel.org/linux-mm/20200820071052.24271-1-sjpark@amazon.com/
>
>
> Thanks,
> SeongJae Park