Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp1280320pxa; Thu, 20 Aug 2020 07:24:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyGAUr+g8belJahcXEVeXIWLefcgu3G84SztE9TTuE13Ge8B/RaiWqX13H8M4/f4f75Sy5+ X-Received: by 2002:a17:906:a1cf:: with SMTP id bx15mr3311759ejb.231.1597933489602; Thu, 20 Aug 2020 07:24:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597933489; cv=none; d=google.com; s=arc-20160816; b=NEboX5g9re2zGdaATc0LkV2qTgXNvKWTKoaGBBBw2Es1ORMkuw9QxH2/9GBi7meneS tDitwVdp9/R17WrmfYQh6JSHMAFP2cPt2nPKSS+pVpQPNVl9u1J0P7poMSVj35xmwwyr tF/QNog9Vkf+JeyN53K7KuG5/8rp6nrPrFOR0sm7B78Pw+nHRUYS9IWIS3KqK7tq1kef gaA0L1xlMhoo08uORddA2P1IHz48oOWLbIi+fHbH3zqH02k+NukOfYpOrz9Tv/ZKeXBj vAooVSN6G1EpksCsjJEvjxaAhq20nMEQMMWMrx6B6XcDqQnqERCXWR1k2l30Cdot9wK1 V87Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=h4EnVq7MB5GDF3MfAWCABwVH6frNWGZ1vZ6r+9FhFOw=; b=F907wMcGnT96M9Y+1dZUq8tC3vJnyw7TwuhU8DUrUR81nBMxP7S1sMd+AeoE2JHRrv m96LbMcKxoajN2Rj5unrflmtVKIOqTnqcfoPeXbgrY24fAck6oOaIrEDVRhvB/I0C+e1 3h2HQ+cj9cLUsIxZweR3HIpcRmSPiCf0K+IUidWYc/ixav+ehvWR1mIoV7ig0+JnPOH9 c9iAnca1Ks5JyHuFBsfBcgIWgTOOoxYEXYoAcnDIBlc/5SLG+x91xcMlX3HfTYIGz+m+ uWWAR/STAmN6TEiZcmyKjCNJ0IxJO5sf0a24t2KLw6SpUS1I6YgBlzsUB48vILj+uYmj DBug== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v23si1492900edw.343.2020.08.20.07.24.26; Thu, 20 Aug 2020 07:24:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727955AbgHTOXu (ORCPT + 99 others); Thu, 20 Aug 2020 10:23:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:53852 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725916AbgHTOXu (ORCPT ); Thu, 20 Aug 2020 10:23:50 -0400 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F400820738; Thu, 20 Aug 2020 14:23:48 +0000 (UTC) Date: Thu, 20 Aug 2020 10:23:47 -0400 From: Steven Rostedt To: Nicolas Boichat Cc: Mauro Carvalho Chehab , Greg Kroah-Hartman , Andy Shevchenko , Sakari Ailus , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [PATCH v4 3/3] media: atomisp: Only use trace_printk if allowed Message-ID: <20200820102347.15d2f610@oasis.local.home> In-Reply-To: <20200820170951.v4.3.I066d89f39023956c47fb0a42edf196b3950ffbf7@changeid> References: <20200820170951.v4.1.Ia54fe801f246a0b0aee36fb1f3bfb0922a8842b0@changeid> <20200820170951.v4.3.I066d89f39023956c47fb0a42edf196b3950ffbf7@changeid> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 20 Aug 2020 17:14:12 +0800 Nicolas Boichat wrote: > Technically, we could only initialize the trace_printk buffers > when the print env is switched, to avoid the build error and > unconditional boot-time warning, but I assume this printing > framework will eventually get removed when the driver moves out > of staging? Perhaps this should be converting into a trace event. Look at what bpf did for their bpf_trace_printk(). The more I think about it, the less I like this series. -- Steve