Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp1342733pxa; Thu, 20 Aug 2020 08:51:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJziiS22ukRI1MV1ebFspdHuZ9IYmtwFlsfK0DBBb4nnCU9mCsziI/DVsp7bswtp0BVGmLml X-Received: by 2002:aa7:df95:: with SMTP id b21mr3411244edy.86.1597938698163; Thu, 20 Aug 2020 08:51:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597938698; cv=none; d=google.com; s=arc-20160816; b=CloBJuEP6Q6sSxR6BDAQwCEQNtnNOeSK7+gjM2nxr6WIfQE7AvDShyStwEYoPpavV7 zGyfxSOml0NoHZJ3BBbfFKGt2t2FHLbguodbdAP8wySBYeCdGrASBK+8wz18457s0tQ9 P08qUqtfa4NM/78mxrGGGnQm9of034FNaL4bc/HCKUq3qpE6GM+PrIJYjaciBYXkFU4H 4imdz1056fvm25LbOXiqtmO/FieDZUCCBa+kwj/k0bdneW6jUA+fDD11SmCiXrwkNxb1 u7stq+uKi7CHS4FjpHz4q1tDJt6RG2MXcqKcRKcpMS4g6wPPKP8vI+3/qseyGnr4apoI CHXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=L1dhWVSKQJj6f9Aq0k5nHE5Jj+eRqqTAcOKN3sJwzTA=; b=iQfa3Qg5oatvCMzxzVGX3uLQ8wC6pRAKAZK52T4hXh3ZEBMbGFxuTXj5mIidM0qzMO BLDwt4/njx5R3qYHzhyyrtcoHU5nG8JHIBIWRNfBRRRdOOQHVONzq166SilQaPwIXcvi jK+CA7ayduA7CoDU2Jb4Jbdu/xCtpgGtUnHrTSG2xph3YcfRN35bPZi4665UQ6QsSNTM YcKe7Gjq7CfzQVZnGsI8BAKfVkyHk/mW3JQjdWF/DG7zJwrX4l6f0+DSGwMXbo2B9vVi aGkPbB5cKwiOBJMdmE6+HllWQfpGBlOmfVnLN9UaNxyqZkvQyIsEMBEuEO7WKh9YPtdV p6HA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b16si1500848eja.517.2020.08.20.08.51.13; Thu, 20 Aug 2020 08:51:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729253AbgHTPto (ORCPT + 99 others); Thu, 20 Aug 2020 11:49:44 -0400 Received: from verein.lst.de ([213.95.11.211]:42808 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729026AbgHTPto (ORCPT ); Thu, 20 Aug 2020 11:49:44 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 617AF68AFE; Thu, 20 Aug 2020 17:49:41 +0200 (CEST) Date: Thu, 20 Aug 2020 17:49:41 +0200 From: Christoph Hellwig To: Nicolin Chen Cc: Stephen Rothwell , Christoph Hellwig , Linux Next Mailing List , Linux Kernel Mailing List Subject: Re: linux-next: boot failure after merge of the dma-mapping tree Message-ID: <20200820154941.GA11349@lst.de> References: <20200820155112.29459f41@canb.auug.org.au> <20200820083617.GA6124@Asurada> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200820083617.GA6124@Asurada> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 20, 2020 at 01:36:17AM -0700, Nicolin Chen wrote: > Took a quick look -- the boundary_size is seemingly passed from > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/arch/powerpc/kernel/iommu.c#n240 > > boundary_size = ALIGN(dma_get_seg_boundary(dev) + 1, > 1 << tbl->it_page_shift); > > Looks like an overflow happens due to (ULONG_MAX + 1). Should > we fix here instead (or also)? Yes, please. I'll drop the patch again for now, but once we've got this sorted out I'll readd it.