Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 20 Aug 2020 12:53:37 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     peterz@infradead.org
Cc:     linux-kernel@vger.kernel.org, mingo@kernel.org, will@kernel.org,
        npiggin@gmail.com, elver@google.com, jgross@suse.com,
        paulmck@kernel.org, rjw@rjwysocki.net, joel@joelfernandes.org,
        svens@linux.ibm.com, tglx@linutronix.de
Subject: Re: [PATCH 0/9] TRACE_IRQFLAGS wreckage
Message-ID: <20200820125337.01440a50@oasis.local.home>
In-Reply-To: <20200820145821.GA1362448@hirez.programming.kicks-ass.net>
References: <20200820073031.886217423@infradead.org>
        <20200820103643.1b9abe88@oasis.local.home>
        <20200820145821.GA1362448@hirez.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 20 Aug 2020 16:58:21 +0200
peterz@infradead.org wrote:

> @@ -91,11 +91,11 @@ void __cpuidle default_idle_call(void)
>  	if (current_clr_polling_and_test()) {
>  		local_irq_enable();
>  	} else {
> -		rcu_idle_enter();
>  		stop_critical_timings();
> +		rcu_idle_enter();
>  		arch_cpu_idle();
> -		start_critical_timings();
>  		rcu_idle_exit();
> +		start_critical_timings();
>  	}
>  }
>  

tip/master didn't have the above function and instead I had this:

@@ -93,11 +93,11 @@ void __cpuidle default_idle_call(void)
        } else {
 
                trace_cpu_idle(1, smp_processor_id());
-               rcu_idle_enter();
                stop_critical_timings();
+               rcu_idle_enter();
                arch_cpu_idle();
-               start_critical_timings();
                rcu_idle_exit();
+               start_critical_timings();
                trace_cpu_idle(PWR_EVENT_EXIT, smp_processor_id());
        }
 }

But it booted to completion without warning with this patch applied.

Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

For the entire series, with this update.

-- Steve