Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp1388379pxa; Thu, 20 Aug 2020 10:00:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyPrbsNzIGN1a6UKMmy3/j459hIII26CfAyjURdVNZkiJR8KldZ9GJ9h60wVAZDpixcqEDa X-Received: by 2002:a17:906:4e57:: with SMTP id g23mr4094239ejw.92.1597942821423; Thu, 20 Aug 2020 10:00:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597942821; cv=none; d=google.com; s=arc-20160816; b=c8dxatZA8o9kzZCwckMafVxf81m7tGrVKMjwqje+g+THVU72MpVkV5sM83U7BXGMQm W5krvr5UFESjUT446zIqj7vPnvusp64T9d3/4sIsyt6zvuHYCOhARSyvgc9ZsMRe91p5 oCJuPmq90kj7ksUr16m5oooXYKh0XA8S8aNmcc73XDnKqlhG2UoG59wJVm9+wCADEVBt eerUvIpm+SQX4uHWe3GPahga3h1Z8YxRsZmOXwL+gNVLhS4bVt07ehXkmku299uGkXhK CnmawQ7Y43OiC58acB2TXH/zk3Bmvc8Nvz6znx8itxS2SitCaX2W9ORD7kVaOeAby8mi gztw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=m1PUHDtDFNIiM5lcbOfIAFUWsbf8FSrvXmA/jIx2KoM=; b=GISZeMXIBLob1dGajjhJi46gXJMYF8ta607+wzGQWuVZvOr47EqWueio7dx4XoG+6A yDBuHXFWXUY4oNTMhjMbRBsRBK5xCi3frz2k2csNKqRaY18jQRwCJr62xhtuoy2IS/uT XpVwQF06cdcedq+gF6JXAVL2kHYKFdQcYsQ2XP2/W3huXn8yJ6sdGTNL+HKWPy7KThkN J2iBCDeeMz6BWeZoZ84+rVxQvwEvfESGSUo+VoYjcgIWgfGntkmeFP999Ma3rCKpi2zx 5SrGrKQnnp4uyzAbQ5ThelV1/QG2G6okLoUNiKiRG34zr/IMbmDXOS03nXHEhZSS5wXC MiHg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id be10si1829638edb.574.2020.08.20.09.59.55; Thu, 20 Aug 2020 10:00:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730352AbgHTQyX (ORCPT + 99 others); Thu, 20 Aug 2020 12:54:23 -0400 Received: from verein.lst.de ([213.95.11.211]:43094 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730001AbgHTQyO (ORCPT ); Thu, 20 Aug 2020 12:54:14 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id CF00868AFE; Thu, 20 Aug 2020 18:54:07 +0200 (CEST) Date: Thu, 20 Aug 2020 18:54:07 +0200 From: Christoph Hellwig To: Tomasz Figa Cc: Christoph Hellwig , alsa-devel@alsa-project.org, linux-ia64@vger.kernel.org, Linux Doc Mailing List , nouveau@lists.freedesktop.org, linux-nvme@lists.infradead.org, linux-mips@vger.kernel.org, "James E.J. Bottomley" , linux-mm@kvack.org, linux-samsung-soc , Joonyoung Shim , linux-scsi@vger.kernel.org, Kyungmin Park , Ben Skeggs , Matt Porter , Linux Media Mailing List , Tom Lendacky , Pawel Osciak , Mauro Carvalho Chehab , "list@263.net:IOMMU DRIVERS , Joerg Roedel ," , Thomas Bogendoerfer , linux-parisc@vger.kernel.org, netdev@vger.kernel.org, Seung-Woo Kim , Linux Kernel Mailing List , "list@263.net:IOMMU DRIVERS , Joerg Roedel ," Subject: Re: [PATCH 05/28] media/v4l2: remove V4L2-FLAG-MEMORY-NON-CONSISTENT Message-ID: <20200820165407.GD12693@lst.de> References: <20200819065555.1802761-1-hch@lst.de> <20200819065555.1802761-6-hch@lst.de> <20200819135454.GA17098@lst.de> <20200820044347.GA4533@lst.de> <20200820052004.GA5305@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 20, 2020 at 12:05:29PM +0200, Tomasz Figa wrote: > The UAPI and V4L2/videobuf2 changes are in good shape and the only > wrong part is the use of DMA API, which was based on an earlier email > guidance anyway, and a change to the synchronization part . I find > conclusions like the above insulting for people who put many hours > into designing and implementing the related functionality, given the > complexity of the videobuf2 framework and how ill-defined the DMA API > was, and would feel better if such could be avoided in future > communication. It wasn't meant to be too insulting, but I found this out when trying to figure out how to just disable it. But it also ends up using the actual dma attr flags for it's own consistency checks, so just not setting the flag did not turn out to work that easily. But in general it helps to add a few more people to the Cc list for such things that do stranger things. Especially if you think you did it based on the advice of those people.