Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp1396867pxa; Thu, 20 Aug 2020 10:10:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxNIwheG633ToBH0NRxiqVxXnvd3XtWRZEzHVQ6VIMa0ddUdNjpcO+mskHIB/uYnFqfaXM+ X-Received: by 2002:a05:6402:b1c:: with SMTP id bm28mr2737296edb.116.1597943451376; Thu, 20 Aug 2020 10:10:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597943451; cv=none; d=google.com; s=arc-20160816; b=ren06VuTtRMV92W/ls49+2dcMNZxGkWSqBAYyGoL2jde/ul6BqmZihFjNQ6apriKi2 DNwEaF9Lm8o70O1GfFWmXtqBjQy28Lr0mQhVcs+5bw/CqJTMJetaBjahPAlAsp9C5+K4 gQRBRU1kH53UbirwRWr+B0GP0Z9uHpAt9MW1Z3CYWCEiG/p2h6Aj0GjyxKxuybFCIm/v SVpcTinKpsqGa6RqMYfOI1qxoMrkxNrYHsdYOmf5Tm50CPkqC2W1BPuTMk8/WUp+V5Ww 8qNYkV1J9+SJ4FOIcjL42IaEXm7JhlehrYOo9v8BfxKDBJiqB8INbf0YzJyaEdVrQHIb O4VA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from :dkim-signature:dkim-signature:date; bh=1jlvtjajrYXjF/1spfrNL4IaV3D7DPvsLkUvhddqIoA=; b=vEWlsSGZAFZaNt3U/A2o+XZgi9pNAth4M76Y1boDhosQ8AKYOZ8YG0JKgak9xzr/Jl rnqLWWEN9ASMQoYY3axj2udsP6s2pDIPwyGE2JLMFs40SWZgw97aKUjj+5AjtzyD10ah G6M379L6J8lf1PE1oHOCApDhQRZrANpqbV46njBkfoZv73S30m3zm7rXb6oej23CTLrX IxWvNYbHB8ctmbiSwpxGPldVxn/NH6HpDHCfZoKl1Jzy92LMADldcN7vxB9zvdRv/d1/ MjFzS1oHkC+T73d4MqzWjp1kMnHKkJRC007Fr8W2Knq/iE92sawzjbv7EEP+uVblXiy6 /riA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=ZmZfB2nv; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n23si1620628ejj.194.2020.08.20.10.10.26; Thu, 20 Aug 2020 10:10:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=ZmZfB2nv; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730451AbgHTRJa (ORCPT + 99 others); Thu, 20 Aug 2020 13:09:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730448AbgHTRIP (ORCPT ); Thu, 20 Aug 2020 13:08:15 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB86CC061342 for ; Thu, 20 Aug 2020 10:07:19 -0700 (PDT) Date: Thu, 20 Aug 2020 19:07:29 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1597943235; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1jlvtjajrYXjF/1spfrNL4IaV3D7DPvsLkUvhddqIoA=; b=ZmZfB2nvVJyg4zXwM8VWNcoTwzukQ5Yga7nuhM0yTBPOCLRYACUkA8NtraPFH0RKjZmxkS CvxJlhOyfLO8c/CgGgFqRp1S8dyq6vwOYR3qr/zxiUyD/2DsUyNMS7qHRt3nlj1edEdpyQ o6K95FIkVrtMOZ34upntnyM8YPjO4uQ5a2on5QayTP68rDAH1CSGtiGVDHRLdrNk7sdMRF qHuOlNQNln5fOaza9nRuSqE1UKJIQD3RrLew5MizgC6lEHNK1Nl2OP/gnZ1lOg8eHzRgj/ fmYOFT4z6TyYBRbHJdDbrjbg03sICy2LQ2Ko++GLkzjTRcLjgum9WN7/aSLv4A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1597943235; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1jlvtjajrYXjF/1spfrNL4IaV3D7DPvsLkUvhddqIoA=; b=f5yGnKX71cuEFvCE8bDQJFc79TQ3ypU/os8nwaj9GsAVwGbRGgbGYD4gREAYAwPNqYgdtp bRsn/tN0BK7faIBQ== From: "Ahmed S. Darwish" To: Jens Axboe Cc: Keith Busch , linux-nvme@lists.infradead.org, Sagi Grimberg , Chaitanya Kulkarni , linux-kernel@vger.kernel.org Subject: Re: v5.9-rc1 commit reliably breaks pci nvme detection Message-ID: <20200820170729.GA4116@lx-t490> References: <20200817135011.GA2072@lx-t490> <20200817155658.GB1221871@dhcp-10-100-145-180.wdl.wdc.com> <2356f514-9408-6a6f-871d-046984963533@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2356f514-9408-6a6f-871d-046984963533@kernel.dk> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 20, 2020 at 09:35:38AM -0600, Jens Axboe wrote: > On 8/17/20 9:58 AM, Jens Axboe wrote: > > On 8/17/20 8:56 AM, Keith Busch wrote: > >> On Mon, Aug 17, 2020 at 03:50:11PM +0200, Ahmed S. Darwish wrote: > >>> Hello, > >>> > >>> Below v5.9-rc1 commit reliably breaks my boot on a Thinkpad e480 > >>> laptop. PCI nvme detection fails, and the kernel becomes not able > >>> anymore to find the rootfs / parse "root=". > >>> > >>> Bisecting v5.8=>v5.9-rc1 blames that commit. Reverting it *reliably* > >>> fixes the problem and makes me able to boot v5.9-rc1. > >> > >> The fix is staged in the nvme tree here: > >> > >> http://git.infradead.org/nvme.git/commit/286155561ecd13b6c85a78eaf2880d3baea03b9e > > > > That would have been nice to have in -rc1... > > And now we're getting very close to shipping items for -rc2, and it's still > not in. Can we please get the nvme pull request out for -rc2? > I keep wondering that myself. Completely breaking the boot like this is really not nice -- and for x86-64 laptops no less :-( The fix is really small and isolated. "Urgent pull requests", containing only a fix or two, were created *exactly* for this reson... Thanks, -- Ahmed S. Darwish Linutronix GmbH