Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Alex Dewar <alex.dewar90@gmail.com>
Date:   Thu, 20 Aug 2020 19:56:20 +0100
To:     Joe Perches <joe@perches.com>
Cc:     Alex Dewar <alex.dewar90@gmail.com>,
        Sathya Prakash <sathya.prakash@broadcom.com>,
        Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
        Suganath Prabu Subramani 
        <suganath-prabu.subramani@broadcom.com>,
        MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: mptfusion: Remove unnecessarily casts
Message-ID: <20200820185620.ysfdpzjj4qrquqbz@medion>
References: <20200820180552.853289-1-alex.dewar90@gmail.com>
 <a99fde707b367b0cee126b596b2dc7a74dbb84e7.camel@perches.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a99fde707b367b0cee126b596b2dc7a74dbb84e7.camel@perches.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Aug 20, 2020 at 11:53:58AM -0700, Joe Perches wrote:
> On Thu, 2020-08-20 at 19:05 +0100, Alex Dewar wrote:
> > In a number of places, the value returned from pci_alloc_consistent() is
> > unnecessarily cast from void*. Remove these casts.
> []
> > diff --git a/drivers/message/fusion/mptbase.c b/drivers/message/fusion/mptbase.c
> []
> > @@ -4975,7 +4975,7 @@ GetLanConfigPages(MPT_ADAPTER *ioc)
> >  
> >  	if (hdr.PageLength > 0) {
> >  		data_sz = hdr.PageLength * 4;
> > -		ppage0_alloc = (LANPage0_t *) pci_alloc_consistent(ioc->pcidev, data_sz, &page0_dma);
> > +		ppage0_alloc = pci_alloc_consistent(ioc->pcidev, data_sz, &page0_dma);
> >  		rc = -ENOMEM;
> >  		if (ppage0_alloc) {
> >  			memset((u8 *)ppage0_alloc, 0, data_sz);
> 
> If you are removing unnecessary casts, it'd be better to remove
> all of them in the same file or subsystem at once.
> 
> Also this memset and cast isn't actually necessary any more
> as pci_alloc_consistent already zeros memory.
> 
> etc...
> 

Good suggestion. Thanks for the feedback :-)