Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp1566153pxa; Thu, 20 Aug 2020 14:51:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwQpNf59BCjfeUm52C97NrX8gK811oF1OEtCoFGEsPnntIpGm7HCdSPiMqUZMph/EVCE33Z X-Received: by 2002:a05:6402:1c1d:: with SMTP id ck29mr663068edb.4.1597960298047; Thu, 20 Aug 2020 14:51:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597960298; cv=none; d=google.com; s=arc-20160816; b=cFCkHX7PXcXQL4UiqiGMQ6/CG/Pe4HHDxc5x6L9wtK1CRJojhxFJqNhARgvFw9weWl 9fkp5HpM5AxOMrHtYJGxnipLXLg9aPsSfxvpVPDTbq5ikcBJqZsIjjjc6ArTexlcIWN4 yoqTtPHY9/bGJxzqU9GHk0V1szPgawmOV/gFzqSfK8iMMkMQjibeHqVtfexVvHNPn32/ LZoD1FYEi2cic8Nu9DssrjDkMn0yV0zfFR9o+PhwLyQ22TVqdPsPMeQA+sXLIhauxRwc pV8L0GT6fzjBf+EWi1Tra9DZn6Fuv88FIkozyKKxhSliG//TZLvAagu6//nnkZW+ahYj t/tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject:ironport-sdr :ironport-sdr; bh=BmnIpvwkQOelEZo0slxfpfJhti531qS+GeiEk45GxNo=; b=ncyN8YVoGeHCDiky65MQbY7dBpkdhyse7ywqZHFBWYSWCkMuYKIPeAKvYUrtVUknHk CexpflEgY064cXxNElfzBAgj5Nc36ugccJ8/y6id5pCGGhXLeN3O+kI/0ZsI5sLKzjQi 1QrA8QzlxO3t/JrZMJkK7JjzjFODhuIw3Iu7MdtIIOueW03lRTVHLoAFIei/EOn7STKT QNNmgII9Dvjz3RA+ilJgu6ac5w5rGJcTyCoXtZB5r8Ea1Lo5AvUSm31lmIZA7RfDhyew PSaSzfFxGcnQtHoz0kyF2TA3AQ3IRnuJfB0g8DfUKwyChr4L5bR2H/LLO+Wt/SsTMjpK aOGA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h18si2353816edw.184.2020.08.20.14.51.14; Thu, 20 Aug 2020 14:51:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728266AbgHTUIX (ORCPT + 99 others); Thu, 20 Aug 2020 16:08:23 -0400 Received: from mga11.intel.com ([192.55.52.93]:21682 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728130AbgHTUIW (ORCPT ); Thu, 20 Aug 2020 16:08:22 -0400 IronPort-SDR: oow43m4BK5Y/WcYwDrhk8eqKpldJRoaOvPzwZcaHJWDNJblrwDAFjsdnsmru8B0vuCvfERv5RW UPIA5RPHTLQw== X-IronPort-AV: E=McAfee;i="6000,8403,9718"; a="153009389" X-IronPort-AV: E=Sophos;i="5.76,334,1592895600"; d="scan'208";a="153009389" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Aug 2020 13:08:21 -0700 IronPort-SDR: bLyUAl6R/afAZiw81j+zMOkvylyeoEYWvrImqUb/a1PF6axwOwMSXo/qh2Oh4aaE8lnD4pLWQ6 mZSEKREivzXA== X-IronPort-AV: E=Sophos;i="5.76,334,1592895600"; d="scan'208";a="327547741" Received: from nguerr1-mobl1.amr.corp.intel.com (HELO [10.251.25.200]) ([10.251.25.200]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Aug 2020 13:08:21 -0700 Subject: Re: FSGSBASE causing panic on 5.9-rc1 To: Tom Lendacky , Jim Mattson Cc: Andy Lutomirski , Sean Christopherson , Joerg Roedel , Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Linux Kernel Mailing List , X86 ML , "Chang S. Bae" , Thomas Gleixner , Sasha Levin , Borislav Petkov , Peter Zijlstra , Ingo Molnar References: <39d57e4d-5db4-f536-6f5e-6b0414c0dccc@amd.com> <7dedb0ab-56a6-5d96-577b-21ab1ecdad24@amd.com> <20200820151049.GA26595@sjchrist-ice> <362f5a45-b808-25ad-b99b-449e05717c4a@amd.com> <45e16c5c-ce99-33da-99c8-ea52ef0945db@amd.com> <68478297-ff21-fa38-a37b-2e1e515fdc5e@amd.com> <50e7c7f6-d212-4e90-09b7-2c568087084e@amd.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: Date: Thu, 20 Aug 2020 13:07:36 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/20/20 12:05 PM, Tom Lendacky wrote: >> I added a quick hack to save TSC_AUX to a new variable in the SVM >> struct and then restore it right after VMEXIT (just after where GS is >> restored in svm_vcpu_enter_exit()) and my guest is no longer crashing. > > Sorry, I mean my host is no longer crashing. Just to make sure I've got this: 1. Older CPUs didn't have X86_FEATURE_RDPID 2. FSGSBASE patches started using RDPID in the NMI entry path when supported *AND* FSGSBASE was enabled 3. There was a latent SVM bug which did not restore the RDPID data before NMIs were reenabled after VMEXIT 4. If an NMI comes in the window between VMEXIT and the wrmsr(TSC_AUX)... boom If FSGSBASE reverted is disabled (as Tom did on the command-line), then the RDPID path isn't hit. Fun.