Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 20 Aug 2020 16:27:38 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Peiyong Lin <lpy@google.com>
Cc:     amit.kucheria@linaro.org, android-kernel@google.com,
        gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
        mingo@redhat.com, paul.walmsley@sifive.com, pavel@ucw.cz,
        prahladk@google.com, rafael.j.wysocki@intel.com,
        ulf.hansson@linaro.org, yamada.masahiro@socionext.com,
        zzyiwei@android.com, sidaths@google.com
Subject: Re: [PATCH v3] Add power/gpu_frequency tracepoint.
Message-ID: <20200820162738.33053904@oasis.local.home>
In-Reply-To: <20200820194134.2176242-1-lpy@google.com>
References: <20200813175037.48a16064@oasis.local.home>
        <20200820194134.2176242-1-lpy@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 20 Aug 2020 12:41:34 -0700
Peiyong Lin <lpy@google.com> wrote:

> Historically there is no common trace event for GPU frequency, in
> downstream Android each different hardware vendor implements their own
> way to expose GPU frequency, for example as a debugfs node.  This patch
> standardize it as a common trace event in upstream linux kernel to help
> the ecosystem have a common implementation across hardware vendors.
> Toolings in the Linux ecosystem will benefit from this especially in the
> downstream Android, where this information is critical to graphics
> developers.
> 
> Signed-off-by: Peiyong Lin <lpy@google.com>

Just from the tracing point of view (not from the content of the trace
point of view).

Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

-- Steve