Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
Date:   Fri, 21 Aug 2020 08:46:16 +0530
To:     Paul Cercueil <paul@crapouillou.net>
Cc:     Lars-Peter Clausen <lars@metafoo.de>,
        madhuparnabhowmik10@gmail.com, dan.j.williams@intel.com,
        vkoul@kernel.org, dmaengine@vger.kernel.org,
        linux-kernel@vger.kernel.org, andrianov@ispras.ru,
        ldv-project@linuxtesting.org
Subject: Re: [PATCH] drivers/dma/dma-jz4780: Fix race condition between probe
 and irq handler
Message-ID: <20200821031616.GA7874@madhuparna-HP-Notebook>
References: <20200816072253.13817-1-madhuparnabhowmik10@gmail.com>
 <ZM2DFQ.KQQJYLJ02WTD3@crapouillou.net>
 <e1961c04-e2aa-fe3a-fb84-bb3b33fae5dc@metafoo.de>
 <VHLDFQ.HR10VPMY1GHD3@crapouillou.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <VHLDFQ.HR10VPMY1GHD3@crapouillou.net>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Aug 20, 2020 at 08:46:43PM +0200, Paul Cercueil wrote:
>=20
>=20
> Le jeu. 20 ao=FBt 2020 =E0 20:23, Lars-Peter Clausen <lars@metafoo.de> a =
=E9crit :
> > On 8/20/20 1:59 PM, Paul Cercueil wrote:
> > > Hi,
> > >=20
> > > Le dim. 16 ao=FBt 2020 =E0 12:52, madhuparnabhowmik10@gmail.com a =E9=
crit
> > > :
> > > > From: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
> > > >=20
> > > > In probe IRQ is requested before zchan->id is initialized which
> > > > can be
> > > > read in the irq handler. Hence, shift request irq and enable
> > > > clock after
> > > > other initializations complete. Here, enable clock part is not
> > > > part of
> > > > the race, it is just shifted down after request_irq to keep the
> > > > error
> > > > path same as before.
> > > >=20
> > > > Found by Linux Driver Verification project (linuxtesting.org).
> > > >=20
> > > > Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
> > >=20
> > > I don't think there is a race at all, the interrupt handler won't be
> > > =7Fcalled before the DMA is registered.
> > >=20
> > From a purely formal verification perspective there is a bug. The
> > interrupt could fire if i.e. the hardware is buggy or something. In
> > general it is a good idea to not request the IRQ until all the resources
> > that are used in the interrupt handler are properly set up. Even if you
> > know that in practice the interrupt will never fire this early.
> >=20
>
> Fair enough, I'm fine with that, but the patch should be reworked so that
> the clk_prepare_enable() call is not moved.
>

Sure, I will send the v2 of the patch with this change soon.

Thanks,
Madhuparna
> Cheers,
> -Paul
>=20
>=20